Page MenuHomePhabricator

Treat temporary account as "temp" user_type when account creation triggering abusefilter
Closed, DeclinedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • When the temporary account is auto-created, and it also triggers the Abusefilter.

What happens?:

What should have happened instead?:

  • The user_type should be treated as temp.

Event Timeline

If we set user_type to temp, it might be logically awkward, as at the time of the action, the temp actor (the temporary account) does not exist, and the only logical actor is the IP. I'd instead propose an autocreate_type parameter for distinguishing between different types of autocreation, like temp, centralauth, etc.

If we set user_type to temp, it might be logically awkward, as at the time of the action, the temp actor (the temporary account) does not exist, and the only logical actor is the IP. I'd instead propose an autocreate_type parameter for distinguishing between different types of autocreation, like temp, centralauth, etc.

I agree with this and am inclined to decline this task.

The only potential inconsistency here would be that user_type will still be 'ip' when a temporary user creates a registered account. This behaviour is actually correct though, because if user_type was reported as 'temp' in this situation, we'd probably also want the temp account name as user_name, but this would make it possible for users with access to temp account IPs to associate the creating temp account's IP to the created registered account (which is a security issue).

Just to note, the simple condition accountname regex '^~2' can be used to detect temporary account creations, and I think it would be better to file a separate feature request if someone wants a new variable/function that may help with this.

Just to note, the simple condition accountname regex '^~2' can be used to detect temporary account creations, and I think it would be better to file a separate feature request if someone wants a new variable/function that may help with this.

I don’t think using a regex is the correct way. I know the current definition is indeed ^~2, but imagine it’s the year 2999 and we must change. Though that’s a long time from now, but it is guaranteed to break one day, and by the time the change must be made, it might be too messy to handle.

I agree that this matter should be handled in a separate ticket. I may raise my concerns and give further suggestions in that ticket.