Page MenuHomePhabricator

[MEX] 3.1.2 - add statement opens edit statement modal
Closed, ResolvedPublic

Description

when I click the add button for statements then select a property, it opens the add statement modal

  • The add new statement modal is very similar to the edit statement modal, but the property field has a blue background - to mimic what the users know from desktop and to highlight this important action.
  • Once the user selects the property, the field for value, rank, and options to add qualifier and reference appear.
  • In order to reject the already selected property, the user needs to cancel the operation with the button on the footer, which would close this modal and take him back to the edit statement screen where he was before (basically the same as the arrow to go back).
  • Once property and value are selected, the publish button becomes blue.

Publishing has the same behavior as when publishing an edit on a statement:

  • if there is a delay we see a loading bar and a message saying publishing in progress
  • if it fails we get an error message on the same modal
  • if the publish is successful, the user is redirected to the main page/display page at the scroll height of the new statement and sees a success message.

Add statement:

Screenshot 2025-10-09 at 15.49.21.png (878×1 px, 145 KB)

Figma file for adding statement

Details

Event Timeline

task time

  • starting screen should be the main/display view of the item
  • what does 'remove' do any do we need it if we have cancel ?
  • why isn't 'add value' listed ?

@Alice.moutinho

(i am not deleting this comment for transparency reasons, nevertheless this comment is non-sensical)

@karapayneWMDE

  • indeed there are 2 ways to add a statement and i neglected one of them: you can add a statement to a statement (covered - add value) and you can add a completely new statement from the display/view of the item (not covered). I will add this to the design.
  • the remove is to remove the property once it has been already selected and you are already selecting the value, and being able to start over. On desktop we have a weird behavior to handle this... i wanted to avoid it but i guess this is also not optimal if nobody understood it (thinking emoji). Ill revisit this
  • i followed the desktop logic: you can add a new statement to a statement (that is what add value does) after the new main statement is published only.

see here:

Screenshot 2025-10-09 at 09.07.14.png (336×2 px, 51 KB)

@karapayneWMDE after talking to Arian it became clear that i was combining "add value to statement" and "add statement" but this actually despite similar, doesn't go together.

so now i fixed this ticket to be only add statement, but i am missing a ticket for "add value to statement"! should i just create one?

Screenshot 2025-10-09 at 15.54.55.png (1×1 px, 172 KB)

Change #1198067 had a related patch set uploaded (by Hasan Akgün (WMDE); author: Hasan Akgün (WMDE)):

[mediawiki/extensions/Wikibase@master] Add statement opens edit statement modal

https://gerrit.wikimedia.org/r/1198067

ArthurTaylor removed ArthurTaylor as the assignee of this task.
ArthurTaylor claimed this task.
ArthurTaylor subscribed.

Change #1198067 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Add statement opens edit statement modal

https://gerrit.wikimedia.org/r/1198067