Page MenuHomePhabricator

YiR: Allow users to hide year in review in Settings
Closed, ResolvedPublic

Description

Background

Users need are able to clear their reading history in the app, but we also want users to be able to clear their Year in Review reports, or hide it from showing.

Requirements

  • Add toggle into Settings called "Year in Review" that is automatically on.
  • If the toggle is turned off by the user:
    • Clear any year in review reports that have been calculated
    • Remove Year in Review entry point from MORE
    • Do not show announcement
  • Show confirmation modal for someone who turns off the Year in Review
  • The toggle should remain in the App permanently, even when Year in Review feature has been disabled from the Config, so that it can continue to apply for future versions

Designs

Settings item
https://www.figma.com/design/DHj33gafvUmkiUahLSJgIM/Android---%3E-Year-in-Review-v3?node-id=21-4958&t=5BDIU1TUI1vtOsOY-4

Confirmation
https://www.figma.com/design/DHj33gafvUmkiUahLSJgIM/Android---%3E-Year-in-Review-v3?node-id=1-9583&t=5BDIU1TUI1vtOsOY-4

Reference

iOS implementation T376310

Event Timeline

@Dbrant

can we make sure that the right-most action in the confirmation dialog is "No thanks" and "Yes, I'm sure" is to its left?

TY

can we make sure that the right-most action in the confirmation dialog is "No thanks" and "Yes, I'm sure" is to its left?

The Material dialog component requires the "affirmative" button to be the rightmost button, and the "negative" button to its left, and this is how all other dialogs are arranged.
To make it behave differently, we would need to make the affirmative button be "No thanks", which would be inconsistent and confusing for maintainability.

ah makes sense, yeah I was thinking the "positive" action for us would be to keep YIR active, but I see what you're saying.

ABorbaWMF subscribed.

Working for me on 2.7.50557-r-2025-11-14, on OnePlus 8 on Android 13, and Pixel 6 on Android 16. Tested on all themes.