Page MenuHomePhabricator
Create Task
Maniphest T405522

Temporary account IP reveal: Users who lack abusefilter-log-detail right get non-functional IP reveal on Special:AbuseLog
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  • Be a temporary account viewer, accept the privacy policy in the preferences
  • Visit Special:Abuselog
  • Click any "Show IP" button

What happens?:
The message "unavailable" is shown

What should have happened instead?:
The IP should be revealed

Other information (browser name/version, screenshots, etc.):

T388124 introduced support for IP reveal on Special:AbuseLog.

A temporary account IP viewer on itwiki is reporting that he cannot check IPs of temporary accounts in the abuselog. He can see the "show IP" button, but instead the checkuser-tempaccount-reveal-ip-missing message appears ("unavailable").

This happens for every AbuseFilter hit. However, for the very same temporary accounts, the IPs can be successfully revealed on Special:Contribs.

This may be the same issue already mentioned by @Johannnes89 here.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Fix test when CheckUser is not loadedHasharmediawiki/extensions/AbuseFiltermaster+25 -2
Check more generically if a user can view temp account IPsTchandersmediawiki/extensions/AbuseFiltermaster+131 -7
Check more generically if a user can view temp account IPsTchandersmediawiki/extensions/AbuseFiltermaster+159 -7
Handle AbuseFilterCanViewTemporaryAccountIPs hookTchandersmediawiki/extensions/CheckUsermaster+39 -1
Customize query in gerrit

Related Objects

Event Timeline

Titore created this task.Sep 24 2025, 8:48 PM
Restricted Application added a project: Trust and Safety Product Team. · View Herald TranscriptSep 24 2025, 8:48 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Dreamy_Jazz mentioned this in T388124: CheckUser IP reveal: Support IP reveal on Special:AbuseLog.Sep 24 2025, 8:54 PM
Dreamy_Jazz moved this task from Inbox to Engineering on the Trust and Safety Product Team board.Sep 24 2025, 9:00 PM
Dreamy_Jazz subscribed.

Hi. I can't seem to reproduce the issue. When I use "Show IP" on a temporary account at https://it.wikipedia.org/w/index.php?title=Speciale:RegistroAbusi I get to see the IP address.

I think this may be because I have the right to inspect AbuseFilter logs (the abusefilter-log-detail right). I'm guessing that the temporary account IP viewer in question does not have access to view the details of AbuseFilter log entries?

The code we have to enable IP reveal on Special:AbuseLog will return nothing if the user does not have the right to inspect details about AbuseFilter logs. It seems that on itwiki only admins and arbcom members have the rights to do this (based on Special:UserGroupRights).

Therefore, I think to solve this task we will need to do some of:

  • Allow IP reveal on Special:AbuseLog if a user lacks abusefilter-log-detail
  • Hide the "Show IP" links if the user lacks access to look at the details of the given AbuseFilter log entry
Dreamy_Jazz renamed this task from "Unavailable" when revealing AbuseLog's IPs to Users who lack access to see details about AbuseFilter log entries still get "Show IP" button in Special:AbuseLog that doesn't work.Sep 24 2025, 9:02 PM
Dreamy_Jazz renamed this task from Users who lack access to see details about AbuseFilter log entries still get "Show IP" button in Special:AbuseLog that doesn't work to AbuseFilter temporary account IP reveal: Users who lack abusefilter-log-detail right get non-functional IP reveal on Special:AbuseLog.
Dreamy_Jazz renamed this task from AbuseFilter temporary account IP reveal: Users who lack abusefilter-log-detail right get non-functional IP reveal on Special:AbuseLog to Temporary account IP reveal: Users who lack abusefilter-log-detail right get non-functional IP reveal on Special:AbuseLog.
Titore added a comment.Sep 24 2025, 10:22 PM
In T405522#11211981, @Dreamy_Jazz wrote:

It seems that on itwiki only admins and arbcom members have the rights to do this (based on Special:UserGroupRights).

Yes, that's right. AbuseLog is quite barebones for non-admins on itwiki, though it used to show IPs, of course. I just want to emphasize that the user can still reveal IPs of those accounts, he just have to do it under their contribs, so it seems odd to me to just disallow it from there.

SCP-2000 subscribed.Sep 25 2025, 3:52 AM
Johannnes89 added a comment.Sep 25 2025, 5:57 AM
In T405522#11211981, @Dreamy_Jazz wrote:

Hi. I can't seem to reproduce the issue. When I use "Show IP" on a temporary account at https://it.wikipedia.org/w/index.php?title=Speciale:RegistroAbusi I get to see the IP address.

I think this may be because I have the right to inspect AbuseFilter logs (the abusefilter-log-detail right). I'm guessing that the temporary account IP viewer in question does not have access to view the details of AbuseFilter log entries?

The code we have to enable IP reveal on Special:AbuseLog will return nothing if the user does not have the right to inspect details about AbuseFilter logs. It seems that on itwiki only admins and arbcom members have the rights to do this (based on Special:UserGroupRights).

Therefore, I think to solve this task we will need to do some of:

  • Allow IP reveal on Special:AbuseLog if a user lacks abusefilter-log-detail
  • Hide the "Show IP" links if the user lacks access to look at the details of the given AbuseFilter log entry

The same issue appears with private filters if users don't have the abusefilter-log-private right (T388124#11212752). Even if they can't see log details non-admin patrollers still check abuse logs as an indicator of abuse and should be able to access the IP just like anywhere else.

NDG subscribed.Sep 25 2025, 6:10 AM
Tchanders added a project: Trust and Safety Product Sprint (Sprint Dadar Gulung (September 8 - September 26)).Sep 25 2025, 6:21 AM
• Niharika moved this task from Inbox to Global wiki rollout on the Temporary accounts board.Sep 25 2025, 10:11 AM
• Niharika edited projects, added: Temporary accounts (Global wiki rollout); removed: Temporary accounts.
Dreamy_Jazz moved this task from Priority Backlog to Ready on the Trust and Safety Product Sprint (Sprint Dadar Gulung (September 8 - September 26)) board.Sep 25 2025, 4:23 PM
OKryva-WMF edited projects, added: Product Safety and Integrity (Sprint Apfel Strudel (Sep 29 - Oct 17)); removed: Trust and Safety Product Sprint (Sprint Dadar Gulung (September 8 - September 26)).Sep 26 2025, 12:53 PM
OKryva-WMF moved this task from Priority backlog to Ready on the Product Safety and Integrity (Sprint Apfel Strudel (Sep 29 - Oct 17)) board.Sep 26 2025, 12:53 PM
Tchanders claimed this task.EditedOct 1 2025, 10:19 AM
Tchanders moved this task from Ready to In progress on the Product Safety and Integrity (Sprint Apfel Strudel (Sep 29 - Oct 17)) board.
Tchanders subscribed.

It sounds like what we need is for anyone with IP reveal rights always to be able to see the IP address for an AbuseFilter log whose performer is a temporary account, regardless of other permissions.

We can have an additional check in AbuseFilterLogDetailsLookup::getIPsForAbuseFilterLogs for:

  • whether afl_user is a temporary user and
  • whether the performer can reveal IPs (this will need to be delegated to CheckUserPermissionManager since it's an awkward check, possibly via a hook)
gerritbot added a comment.Oct 2 2025, 5:57 PM

Change #1193154 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/AbuseFilter@master] WIP Check more generically if a user can view temp account IPs

https://gerrit.wikimedia.org/r/1193154

gerritbot added a project: Patch-For-Review.Oct 2 2025, 5:57 PM
gerritbot added a comment.Oct 3 2025, 10:08 AM

Change #1193385 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/CheckUser@master] Handle AbuseFilterCanViewTemporaryAccountIPs hook

https://gerrit.wikimedia.org/r/1193385

OKryva-WMF removed a project: Trust and Safety Product Team.Oct 3 2025, 2:09 PM
Tchanders moved this task from In progress to Needs review on the Product Safety and Integrity (Sprint Apfel Strudel (Sep 29 - Oct 17)) board.Oct 6 2025, 11:48 AM
• Niharika moved this task from To triage to In progress on the Temporary accounts (Global wiki rollout) board.Oct 7 2025, 8:29 AM
gerritbot added a comment.Oct 7 2025, 3:42 PM

Change #1194233 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/AbuseFilter@master] Check more generically if a user can view temp account IPs

https://gerrit.wikimedia.org/r/1194233

gerritbot added a comment.Oct 8 2025, 10:54 AM

Change #1193154 abandoned by Tchanders:

[mediawiki/extensions/AbuseFilter@master] Check more generically if a user can view temp account IPs

https://gerrit.wikimedia.org/r/1193154

gerritbot added a comment.Oct 8 2025, 10:55 AM

Change #1193385 abandoned by Tchanders:

[mediawiki/extensions/CheckUser@master] Handle AbuseFilterCanViewTemporaryAccountIPs hook

Reason:

Going with Ic21c498c015c7cedc91a17d223e73f38e4b31d5f

https://gerrit.wikimedia.org/r/1193385

gerritbot added a comment.Oct 10 2025, 2:28 PM

Change #1194233 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@master] Check more generically if a user can view temp account IPs

https://gerrit.wikimedia.org/r/1194233

Maintenance_bot removed a project: Patch-For-Review.Oct 10 2025, 2:31 PM
ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.23; 2025-10-14).Oct 10 2025, 3:00 PM
Tchanders moved this task from Needs review to Needs QA on the Product Safety and Integrity (Sprint Apfel Strudel (Sep 29 - Oct 17)) board.Oct 14 2025, 12:49 PM
OKryva-WMF edited projects, added: Product Safety and Integrity (Sprint Mint Choc Chip Ice Cream (Oct 20 - Nov 7)); removed: Product Safety and Integrity (Sprint Apfel Strudel (Sep 29 - Oct 17)).Oct 17 2025, 1:47 PM
OKryva-WMF moved this task from Backlog to Needs QA on the Product Safety and Integrity (Sprint Mint Choc Chip Ice Cream (Oct 20 - Nov 7)) board.Oct 17 2025, 1:48 PM
Djackson-ctr moved this task from Needs QA to Done on the Product Safety and Integrity (Sprint Mint Choc Chip Ice Cream (Oct 20 - Nov 7)) board.Oct 18 2025, 5:16 AM
Djackson-ctr subscribed.

New Code Changes have been implemented and verified (Abuse Filter Log will reveal the IP Address when Show IP button is selected).

gerritbot added a comment.Oct 20 2025, 11:38 AM

Change #1197239 had a related patch set uploaded (by Hashar; author: Hashar):

[mediawiki/extensions/AbuseFilter@master] Fix test when CheckUser is not loaded

https://gerrit.wikimedia.org/r/1197239

gerritbot added a project: Patch-For-Review.Oct 20 2025, 11:38 AM
gerritbot added a comment.Oct 20 2025, 2:22 PM

Change #1197239 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@master] Fix test when CheckUser is not loaded

https://gerrit.wikimedia.org/r/1197239

Maintenance_bot removed a project: Patch-For-Review.Oct 20 2025, 2:31 PM
ReleaseTaggerBot edited projects, added: MW-1.45-notes (1.45.0-wmf.24; 2025-10-21); removed: MW-1.45-notes (1.45.0-wmf.23; 2025-10-14).Oct 20 2025, 3:00 PM
• Niharika closed this task as Resolved.Jan 28 2026, 1:15 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits