Page MenuHomePhabricator

Authenticated data should not be in the anonymous store
Closed, ResolvedPublicPRODUCTION ERROR

Description

Error
normalized_message
Authenticated data should not be in the anonymous store
FrameLocationCall
from/srv/mediawiki/php-1.45.0-wmf.20/includes/session/MultiBackendSessionStore.php(216)
#0/srv/mediawiki/php-1.45.0-wmf.20/includes/session/SessionBackend.php(183)MediaWiki\Session\MultiBackendSessionStore->get(MediaWiki\Session\SessionInfo)
#1/srv/mediawiki/php-1.45.0-wmf.20/includes/session/SessionManager.php(980)MediaWiki\Session\SessionBackend->__construct(MediaWiki\Session\SessionId, MediaWiki\Session\SessionInfo, MediaWiki\Session\MultiBackendSessionStore, Monolog\Logger, MediaWiki\HookContainer\HookContainer, int)
#2/srv/mediawiki/php-1.45.0-wmf.20/includes/session/SessionManager.php(155)MediaWiki\Session\SessionManager->getSessionFromInfo(MediaWiki\Session\SessionInfo, MediaWiki\Request\WebRequest)
#3/srv/mediawiki/php-1.45.0-wmf.20/includes/Request/WebRequest.php(874)MediaWiki\Session\SessionManager->getSessionForRequest(MediaWiki\Request\WebRequest)
#4/srv/mediawiki/php-1.45.0-wmf.20/includes/Setup.php(516)MediaWiki\Request\WebRequest->getSession()
#5/srv/mediawiki/php-1.45.0-wmf.20/includes/WebStart.php(86)require_once(string)
#6/srv/mediawiki/php-1.45.0-wmf.20/api.php(37)require(string)
#7/srv/mediawiki/w/api.php(3)require(string)
#8{main}
Impact

[warnings] 2 occurrences in the last 24 hours

Notes

Event Timeline

Actually, this is not a duplicate; it is about the get() path, and the other one is the set() code path. Reopening.

The root cause might be the same for both actually.

Change #1194188 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/core@master] session: Write cache write flags in `SessionStore::set()`

https://gerrit.wikimedia.org/r/1194188

Change #1194281 had a related patch set uploaded (by Gergő Tisza; author: Derick Alangi):

[mediawiki/core@wmf/1.45.0-wmf.21] session: Log cache write flags in `SessionStore::set()`

https://gerrit.wikimedia.org/r/1194281

Change #1194282 had a related patch set uploaded (by Gergő Tisza; author: Derick Alangi):

[mediawiki/core@wmf/1.45.0-wmf.22] session: Log cache write flags in `SessionStore::set()`

https://gerrit.wikimedia.org/r/1194282

Change #1194188 merged by jenkins-bot:

[mediawiki/core@master] session: Log cache write flags in `SessionStore::set()`

https://gerrit.wikimedia.org/r/1194188

Change #1194281 merged by jenkins-bot:

[mediawiki/core@wmf/1.45.0-wmf.21] session: Log cache write flags in `SessionStore::set()`

https://gerrit.wikimedia.org/r/1194281

Change #1194282 merged by jenkins-bot:

[mediawiki/core@wmf/1.45.0-wmf.22] session: Log cache write flags in `SessionStore::set()`

https://gerrit.wikimedia.org/r/1194282

Mentioned in SAL (#wikimedia-operations) [2025-10-07T21:30:44Z] <tgr@deploy2002> Started scap sync-world: Backport for [[gerrit:1194261|session: Log actual class name in preventSessionsForUser exception (T406566)]], [[gerrit:1194262|session: Log actual class name in preventSessionsForUser exception (T406566)]], [[gerrit:1194281|session: Log cache write flags in SessionStore::set() (T405633 T405634)]], [[gerrit:1194282|session: Log cache write flags in SessionStore::set() (T4056

Mentioned in SAL (#wikimedia-operations) [2025-10-07T21:34:47Z] <tgr@deploy2002> tgr: Backport for [[gerrit:1194261|session: Log actual class name in preventSessionsForUser exception (T406566)]], [[gerrit:1194262|session: Log actual class name in preventSessionsForUser exception (T406566)]], [[gerrit:1194281|session: Log cache write flags in SessionStore::set() (T405633 T405634)]], [[gerrit:1194282|session: Log cache write flags in SessionStore::set() (T405633 T405634)]] synced

Mentioned in SAL (#wikimedia-operations) [2025-10-07T21:40:21Z] <tgr@deploy2002> Finished scap sync-world: Backport for [[gerrit:1194261|session: Log actual class name in preventSessionsForUser exception (T406566)]], [[gerrit:1194262|session: Log actual class name in preventSessionsForUser exception (T406566)]], [[gerrit:1194281|session: Log cache write flags in SessionStore::set() (T405633 T405634)]], [[gerrit:1194282|session: Log cache write flags in SessionStore::set() (T405

Change #1194582 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/core@master] session: Check that `$anonUserId` is not null (like other cases)

https://gerrit.wikimedia.org/r/1194582

Change #1194663 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/core@master] session: Improve logging for MultiBackendSessionStore

https://gerrit.wikimedia.org/r/1194663

Change #1194582 abandoned by D3r1ck01:

[mediawiki/core@master] session: Check that `$anonUserId` is not null (like other cases)

Reason:

Per If9c4a13f7e49349cf344e32a4f6e2714e9e44e3a, we're not using userID anymore.

https://gerrit.wikimedia.org/r/1194582

Change #1194663 merged by jenkins-bot:

[mediawiki/core@master] session: Improve logging for MultiBackendSessionStore

https://gerrit.wikimedia.org/r/1194663

Change #1194963 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/core@wmf/1.45.0-wmf.21] session: Improve logging for MultiBackendSessionStore

https://gerrit.wikimedia.org/r/1194963

Change #1194964 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/core@wmf/1.45.0-wmf.22] session: Improve logging for MultiBackendSessionStore

https://gerrit.wikimedia.org/r/1194964

Change #1194963 merged by jenkins-bot:

[mediawiki/core@wmf/1.45.0-wmf.21] session: Improve logging for MultiBackendSessionStore

https://gerrit.wikimedia.org/r/1194963

Change #1194964 merged by jenkins-bot:

[mediawiki/core@wmf/1.45.0-wmf.22] session: Improve logging for MultiBackendSessionStore

https://gerrit.wikimedia.org/r/1194964

Mentioned in SAL (#wikimedia-operations) [2025-10-09T16:10:27Z] <tgr@deploy2002> Started scap sync-world: Backport for [[gerrit:1194963|session: Improve logging for MultiBackendSessionStore (T402808 T405633 T405634)]], [[gerrit:1194964|session: Improve logging for MultiBackendSessionStore (T402808 T405633 T405634)]]

Mentioned in SAL (#wikimedia-operations) [2025-10-09T16:14:09Z] <tgr@deploy2002> tgr, d3r1ck01: Backport for [[gerrit:1194963|session: Improve logging for MultiBackendSessionStore (T402808 T405633 T405634)]], [[gerrit:1194964|session: Improve logging for MultiBackendSessionStore (T402808 T405633 T405634)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2025-10-09T16:30:34Z] <tgr@deploy2002> Finished scap sync-world: Backport for [[gerrit:1194963|session: Improve logging for MultiBackendSessionStore (T402808 T405633 T405634)]], [[gerrit:1194964|session: Improve logging for MultiBackendSessionStore (T402808 T405633 T405634)]] (duration: 20m 07s)

Change #1195029 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/core@master] session: Avoid logging in session store if UserInfo is available

https://gerrit.wikimedia.org/r/1195029

Logs look clear now. The other case is still open until they resolved.

Change #1195029 abandoned by D3r1ck01:

[mediawiki/core@master] session: Avoid logging in session store if UserInfo is available

https://gerrit.wikimedia.org/r/1195029