1.45.0-wmf.23 deployment blockers
Closed, ResolvedPublic5 Estimated Story PointsRelease
Actions

Assigned To

Authored By

	thcipriani
	Sep 25 2025, 9:54 PM

Details

Backup Train Conductor: jnuche
Release Version: 1.45.0-wmf.23
Release Date: Oct 13 2025, 12:00 AM

2025 week 42 1.45-wmf.23 Changes wmf/1.45.0-wmf.23

This MediaWiki Train Deployment is scheduled for the week of Monday, October 13th:

Monday October 13th	Tuesday, October 14th	Wednesday, October 15th	Thursday, October 16th	Friday
Backports only.	Branch `wmf.23` and deploy to Group 0 Wikis.	Deploy `wmf.23` to Group 1 Wikis.	Deploy `wmf.23` to all Wikis.	No deployments on fridays

See https://wikitech.wikimedia.org/wiki/Deployments for full schedule.

How this works

Any serious bugs affecting wmf.23 should be added as subtasks beneath this one.
- Use this form to create one.
Any open subtask(s) block the train from moving forward. This means no further deployments until the blockers are resolved.
If something is serious enough to warrant a rollback then you should bring it to the attention of deployers on the #wikimedia-operations IRC channel.
If you have a risky change in this week's train add a comment to this task using the Risky patch template
For more info about deployment blockers, see Holding the train.

Other Deployments

Previous: 1.45.0-wmf.22

Next: 1.45.0-wmf.24

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
group2 to 1.45.0-wmf.23	operations/mediawiki-config	master	+341 -341
group1 to 1.45.0-wmf.23	operations/mediawiki-config	master	+576 -576
group0 to 1.45.0-wmf.23	operations/mediawiki-config	master	+140 -140
testwikis to 1.45.0-wmf.23	operations/mediawiki-config	master	+3 -3
Branch commit for wmf/1.45.0-wmf.23	mediawiki/core	wmf/1.45.0-wmf.23	+1 K -3

Customize query in gerrit

Related Objects

Mentioned In: T407535: Verify 1.45.0-wmf.23 deployment
T406986: CTT tasks week of 2025-10-10
Mentioned Here: T407323: PHP Warning: DOMNode::appendChild(): Document Fragment is empty
T407184: PHP Deprecated: Use of MediaWiki\Parser\ParserOutput::getImages was deprecated in MediaWiki 1.43. [Called from MediaWiki\Extension\GlobalUsage\Hooks::onLinksUpdateComplete]

Event Timeline

thcipriani created this task.Sep 25 2025, 9:54 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 25 2025, 9:54 PM

thcipriani assigned this task to Aklapper.Sep 25 2025, 9:57 PM

thcipriani triaged this task as Medium priority.

thcipriani updated Other Assignee, added: jnuche.

thcipriani set the point value for this task to 5.

thcipriani added projects: Release-Engineering-Team (Priority Backlog 📥), Essential-Work.

Risky Patch! 🚂🔥

Change: https://gerrit.wikimedia.org/r/1192248, https://gerrit.wikimedia.org/r/1194157, https://gerrit.wikimedia.org/r/1192250, https://gerrit.wikimedia.org/r/1192252, https://gerrit.wikimedia.org/r/1187837
Summary:
- The patches change the signature of AbstractProvider::__construct() by adding a new parameter (and using it). Unfortunately, the constructor is extended in other extensions, which makes this a tricky operation (as we cannot change two extensions at the same time). The code itself does not add significant risks (it has no user visible effect at the moment), but it can get very tricky to revert, which is why we're mentioning it here.
Test plan:
- The patches are a no-op for now. Monitoring for exceptions in Logstash should be sufficient to notice any issues.
Places to monitor:
Revert plan: Rollback train + escalate to Growth engineers
- If you do need to revert the code, it is possible (and Growth does not have any objections per se), but you will need to revert all five patches, regardless of which one causes the error. You're also likely to run into CI complaints on reverts, as the reverting needs to be done in an appropriate order.
Affected wikis: all.dblist
IRC contact: Urbanecm (primary), Michael_WMF (secondary), both CET timezone
UBN Task Projects/tags: Growth-Team, MediaWiki-extensions-CommunityConfiguration
- In addition to tasks/IRC, Growth's attention can be caught in #talk-to-growth on WMF Slack; @growth-engineers can be used to ping all Growth engineers.
Would you like to backport this change rather than ride the train?: No

I just sold this train for very good moneys to @hashar, I hope will also be very good train, enjoy

Macro antoine-approve:

OSleger-WMF mentioned this in T406986: CTT tasks week of 2025-10-10.Oct 10 2025, 1:28 PM

@Urbanecm_WMF @Michael Thank you for the risky patch mention. I will run the train on Tuesday at 10:00 CEST, If I see anything related to AbstractProvider::__construct, I would let you know.

Restricted Application removed a subscriber: Urbanecm. · View Herald TranscriptOct 13 2025, 1:20 PM

Sounds good @hashar! Please note the errors might also come from subclasses (they should all have "provider" in their name though, and CommunityConfiguration in their stacktrace).

Change #1195791 had a related patch set uploaded (by TrainBranchBot; author: trainbranchbot):

[mediawiki/core@wmf/1.45.0-wmf.23] Branch commit for wmf/1.45.0-wmf.23

https://gerrit.wikimedia.org/r/1195791

gerritbot added a project: Patch-For-Review.Oct 14 2025, 1:07 AM

Change #1195791 merged by jenkins-bot:

[mediawiki/core@wmf/1.45.0-wmf.23] Branch commit for wmf/1.45.0-wmf.23

https://gerrit.wikimedia.org/r/1195791

Maintenance_bot removed a project: Patch-For-Review.Oct 14 2025, 1:30 AM

Change #1195795 had a related patch set uploaded (by TrainBranchBot; author: MediaWiki PreSync):

[operations/mediawiki-config@master] testwikis to 1.45.0-wmf.23

https://gerrit.wikimedia.org/r/1195795

Change #1195795 merged by jenkins-bot:

[operations/mediawiki-config@master] testwikis to 1.45.0-wmf.23

https://gerrit.wikimedia.org/r/1195795

Mentioned in SAL (#wikimedia-operations) [2025-10-14T03:03:32Z] <mwpresync@deploy2002> Started scap sync-world: testwikis to 1.45.0-wmf.23 refs T405679

Maintenance_bot removed a project: Patch-For-Review.Oct 14 2025, 3:30 AM

Mentioned in SAL (#wikimedia-operations) [2025-10-14T03:48:34Z] <mwpresync@deploy2002> Finished scap sync-world: testwikis to 1.45.0-wmf.23 refs T405679 (duration: 45m 02s)

Change #1195980 had a related patch set uploaded (by TrainBranchBot; author: Hashar):

[operations/mediawiki-config@master] group0 to 1.45.0-wmf.23

https://gerrit.wikimedia.org/r/1195980

Change #1195980 merged by jenkins-bot:

[operations/mediawiki-config@master] group0 to 1.45.0-wmf.23

https://gerrit.wikimedia.org/r/1195980

Maintenance_bot removed a project: Patch-For-Review.Oct 14 2025, 8:31 AM

Mentioned in SAL (#wikimedia-operations) [2025-10-14T08:37:23Z] <hashar@deploy2002> rebuilt and synchronized wikiversions files: group0 to 1.45.0-wmf.23 refs T405679

Looks good so far, there was a single type of error for ParserOutput::getImages being deprecated. Filed as T407184, that got fixed and we have determinate it is not worth backporting.

Change #1196371 had a related patch set uploaded (by TrainBranchBot; author: SpiderPig jobrunner/apiserver):

[operations/mediawiki-config@master] group1 to 1.45.0-wmf.23

https://gerrit.wikimedia.org/r/1196371

Change #1196371 merged by jenkins-bot:

[operations/mediawiki-config@master] group1 to 1.45.0-wmf.23

https://gerrit.wikimedia.org/r/1196371

Mentioned in SAL (#wikimedia-operations) [2025-10-15T08:19:37Z] <hashar@deploy2002> rebuilt and synchronized wikiversions files: group1 to 1.45.0-wmf.23 refs T405679

Maintenance_bot removed a project: Patch-For-Review.Oct 15 2025, 8:30 AM

There are some PHP warning with the parser TOC code which I have filed as T407323. I have reached out to Isabelle to gauge the impact, it is being investigated. Meanwhile I am holing the train for a bit.

In T405679#11280168, @hashar wrote:

There are some PHP warning with the parser TOC code which I have filed as T407323. I have reached out to Isabelle to gauge the impact, it is being investigated. Meanwhile I am holing the train for a bit.

That was determinated to not have any user-facing impact, it is merely log spam and not worth blocking the train.

hashar removed a subtask: T407323: PHP Warning: DOMNode::appendChild(): Document Fragment is empty.Oct 16 2025, 8:16 AM

Change #1196624 had a related patch set uploaded (by TrainBranchBot; author: SpiderPig jobrunner/apiserver):

[operations/mediawiki-config@master] group2 to 1.45.0-wmf.23

https://gerrit.wikimedia.org/r/1196624

gerritbot added a project: Patch-For-Review.Oct 16 2025, 8:22 AM

Change #1196624 merged by jenkins-bot:

[operations/mediawiki-config@master] group2 to 1.45.0-wmf.23

https://gerrit.wikimedia.org/r/1196624

Maintenance_bot removed a project: Patch-For-Review.Oct 16 2025, 8:30 AM

Mentioned in SAL (#wikimedia-operations) [2025-10-16T08:32:00Z] <hashar@deploy2002> rebuilt and synchronized wikiversions files: group2 to 1.45.0-wmf.23 refs T405679

Edtadros mentioned this in T407535: Verify 1.45.0-wmf.23 deployment.Oct 16 2025, 5:56 PM

thcipriani closed this task as Resolved.Oct 17 2025, 2:26 PM

1.45.0-wmf.23 deployment blockersClosed, ResolvedPublic5 Estimated Story PointsReleaseActions