Page MenuHomePhabricator

The "e" keyboard shortcut in the Wikidata Query Service doesn't work properly
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:

  • The Query Examples modal starts appearing, but immediately starts disappearing again

What should have happened instead?:

  • It should open properly

Why it happens:

  • On App.js#L400, the function that is triggered is $( 'button#open-example' ).click();. However, there are two $( 'button#open-example' ) on the page (one of them normally hidden), so both of them are clicked in quick succession, leading to the modal closing again.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

Related Changes in Gerrit:
Related Changes in GitLab:
TitleReferenceAuthorSource BranchDest Branch
Fix 'e' keyboard shortcutrepos/wmde/wikidata-query-gui!43jhsobymainmain
Customize query in GitLab

Event Timeline

Change #1191692 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[operations/deployment-charts@master] wikidata-query-gui: Bump query-gui image version

https://gerrit.wikimedia.org/r/1191692

Change #1191692 merged by jenkins-bot:

[operations/deployment-charts@master] wikidata-query-gui: Bump query-gui image version

https://gerrit.wikimedia.org/r/1191692

jhsoby claimed this task.