Page MenuHomePhabricator

[MEX] M4.1.6 -FUNC - quantities
Closed, ResolvedPublic

Description

as a user, i would like to be able to select monolingual text and and quantities when these are the correct values for a property.

mono: T414416

Quantities

Screenshot 2026-01-13 at 11.52.32.png (818×2 px, 163 KB)

Acceptance Criteria

  • quantity specification comprises 2 fields: 1x simple input + 1x lookup
  • Only the input is mandatory, the lookup is optional
  • once the user selects a property on the property selector that triggers this type of data, both fields (input + lookup) appear - plus the rank, qualifier and reference - and the input becomes active
  • once the user finishes his input on the input field: if he presses enter/finish etc lookup becomes active.
  • if the text input has been active and the user leaves without filling something in: error state for the field becomes active
  • Leaving the lookup unselected does not trigger the error state.
  • If the input field has a acceptable value inside: publish button becomes active
  • the display on the main statement page is as is shown on figma
  • test coverage !

Figma for quantity

Event Timeline

Alice.moutinho renamed this task from Text input that triggers mandatory dropdown to Text input that triggers aditional dropdown.Oct 14 2025, 12:23 PM
Alice.moutinho renamed this task from Text input that triggers aditional dropdown to monolingual text & quantities: properties with value type that enables an additional selection.Oct 14 2025, 12:41 PM
karapayneWMDE renamed this task from monolingual text & quantities: properties with value type that enables an additional selection to [MEX] M4.1.2 monolingual text & quantities: properties with value type that enables an additional selection.Oct 15 2025, 9:19 AM
karapayneWMDE renamed this task from [MEX] M4.1.2 monolingual text & quantities: properties with value type that enables an additional selection to [MEX] M4.4 monolingual text & quantities: properties with value type that enables an additional selection.Nov 24 2025, 8:39 AM
karapayneWMDE renamed this task from [MEX] M4.4 monolingual text & quantities: properties with value type that enables an additional selection to [MEX] M4.2 monolingual text & quantities: properties with value type that enables an additional selection.Nov 24 2025, 8:41 AM
karapayneWMDE renamed this task from [MEX] M4.2 monolingual text & quantities: properties with value type that enables an additional selection to [MEX] M4.1.2 monolingual text & quantities: properties with value type that enables an additional selection.Nov 24 2025, 8:48 AM

@Alice.moutinho Are there no labels for the “language” and “unit” inputs? AFAIK using the placeholder as a label is kind of an antipattern (there’s an old related task at T214307 that we never got around to working on).

karapayneWMDE renamed this task from [MEX] M4.1.2 monolingual text & quantities: properties with value type that enables an additional selection to [MEX] M4.1.2 -FUNC - quantities.Jan 13 2026, 10:23 AM
karapayneWMDE updated the task description. (Show Details)

Change #1233153 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/Wikibase@master] [WIP] Refactor snak view to contain slots

https://gerrit.wikimedia.org/r/1233153

Change #1233175 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/Wikibase@master] [WIP] Introduce support for quantity datatype

https://gerrit.wikimedia.org/r/1233175

Change #1233153 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Refactor snak view to contain slots

https://gerrit.wikimedia.org/r/1233153

Change #1235323 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/Wikibase@master] [WIP] Refactor apiItemLookup to make it abstract of snaks

https://gerrit.wikimedia.org/r/1235323

@ArthurTaylor Fixed some logical bugs, fixed the Jest tests, created a new Jest test .. the E2E test is failing for editEntityDatatypes.cy.ts.

Change #1238288 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/WikibaseLexeme@master] Make menuitem selection more reliable in cypress tests

https://gerrit.wikimedia.org/r/1238288

Change #1235323 abandoned by Arthur taylor:

[mediawiki/extensions/Wikibase@master] Refactor apiItemLookup to make it abstract of snaks

Reason:

Merged into Icb5d8bd7f3953fcecbfe0b4b6b2940b66a6a6964

https://gerrit.wikimedia.org/r/1235323

karapayneWMDE renamed this task from [MEX] M4.1.2 -FUNC - quantities to [MEX] M4.1.6 -FUNC - quantities.Feb 10 2026, 4:28 PM

Change #1238288 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Make menuitem selection more reliable in cypress tests

https://gerrit.wikimedia.org/r/1238288

Change #1233175 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Introduce support for quantity datatype

https://gerrit.wikimedia.org/r/1233175