| Alice.moutinho | |
| Sep 26 2025, 1:55 PM |
| F66749469: Screenshot 2025-10-14 at 10.00.29.png | |
| Oct 14 2025, 8:04 AM |
| F66749441: 2025-10-14-094612_703x563_scrot.png | |
| Oct 14 2025, 7:46 AM |
| F66709460: Screenshot 2025-09-29 at 10.01.27.png | |
| Sep 29 2025, 8:02 AM |
| F66709458: Screenshot 2025-09-26 at 15.21.27.png | |
| Sep 29 2025, 8:01 AM |
| F66709450: Screenshot 2025-09-29 at 09.57.54.png | |
| Sep 29 2025, 7:59 AM |
As an editor, I want to be able to see and edit qualifiers of a statement.
This will only be editable for string data types.
If the data type triggers a drop down it will be done on the same page.
Other data types will be editable later and will remain as they are currently displayed.
Qualifiers on edit mode:
Figma file for qualifiers on edit mode
Acceptance Criteria
Related ticket T402431
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Show existing qualifiers in edit mode | mediawiki/extensions/Wikibase | master | +1 K -504 |
Change #1193820 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):
[mediawiki/extensions/Wikibase@master] Show existing qualifiers in edit mode
Hi Arthur, i think you saw it: i had forgotten the edit snak type option... did you include it? i fixed the figma file... if you did not include the snak type selection we would make another ticket for it here!
ps. thanks for noticing, i am fixing a lot of designs :)
Hi @Alice.moutinho ,
Yes, I added a snak-type selector for those fields. It looks a bit different from what I see in the Figma:
Hi @ArthurTaylor great :) Could we reduce the padding on both sides somewhat? or are these padding related to the menu button (and then we cannot fix it)?
@Alice.moutinho yes, in principle. For 'first pass', we are not aiming for pixel perfect, but it doesn't hurt to get things right the first time. One problem I see is that in the real code, for the Rank Selector, the icon is inside the CdxSelect (whereas in the designs it is outside). Since we probably want the same padding for all snak type selectors (main snak and qualifier / reference snaks), I was looking at the alignment of the start of the mainSnak input with the start of the text of the Rank Selector. How should those be aligned? Or does that not matter?
Change #1193820 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Show existing qualifiers in edit mode