Page MenuHomePhabricator
Create Task
Maniphest T405743

[MEX] 3 cleanup for beta release
Closed, ResolvedPublic
Actions

Assigned To
karapayneWMDE
Authored By
Alice.moutinho
Sep 26 2025, 2:11 PM
Tags
Referenced Files
F70211890: 2025-11-14-110724_481x504_scrot.png
Fri, Nov 14, 10:09 AM
F66738307: image.png
Oct 8 2025, 9:20 AM
F66738305: image.png
Oct 8 2025, 9:20 AM
F66738301: image.png
Oct 8 2025, 9:20 AM
F66738298: image.png
Oct 8 2025, 9:20 AM
F66738294: image.png
Oct 8 2025, 9:20 AM
F66738290: image.png
Oct 8 2025, 9:20 AM
F66738282: image.png
Oct 8 2025, 9:20 AM
View All 12 Files
Subscribers
Aklapper
Alice.moutinho
Arian_Bozorg
ArthurTaylor
karapayneWMDE
mahmoud.abdelsattar.wmde
Sadiya.Mohammed_WMDE

Description

Before we release on Wikidata behind a feature flag we must make sure that the UI looks correct, although not pixel perfect.

Below is a list of UI updates that need to be made before we can release on Wikidata behind a feature flag:

Adjust indentation of qualifiers
Incorrect:

image.png (292×435 px, 12 KB)

Correct:

indentation.png (646×846 px, 54 KB)

Fix right padding of edit button
Incorrect:

image.png (60×442 px, 2 KB)

Correct:

image.png (176×444 px, 5 KB)

Update edit button font size to 16
Incorrect:

image.png (60×442 px, 2 KB)

Correct:

image.png (176×444 px, 5 KB)

Make sure there is no cropping of ranking button
Incorrect:

image.png (95×143 px, 2 KB)

Correct:

image.png (162×424 px, 5 KB)

Ranking icon on coordiante location to be aligned verticaly with the numeral coordinates
Incorrect:

image.png (310×444 px, 11 KB)

Correct:

Screenshot 2025-09-26 at 15.11.17.png (586×1 px, 377 KB)

Update line spacing between link and dimensions on commons datatype
Incorrect:

image.png (191×436 px, 25 KB)

Correct:

image.png (460×411 px, 105 KB)

Figma file

Acceptance Criteria

  • All UI updates have been completed

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Fix up some layout issues in MEX / wbui2025mediawiki/extensions/Wikibasemaster+55 -23
cleanup for beta releasemediawiki/extensions/Wikibasemaster+182 -141
Customize query in gerrit

Event Timeline

Alice.moutinho created this task.Sep 26 2025, 2:11 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 26 2025, 2:11 PM
Alice.moutinho renamed this task from Ui cleanup ffor beta release to Ui cleanup for beta release.Sep 26 2025, 2:12 PM
Alice.moutinho updated the task description. (Show Details)Sep 26 2025, 2:26 PM
Maintenance_bot added a project: Wikidata.Sep 26 2025, 2:31 PM
Alice.moutinho updated the task description. (Show Details)Sep 26 2025, 2:36 PM
Arian_Bozorg renamed this task from Ui cleanup for beta release to [MEX] 3 cleanup for beta release.Oct 8 2025, 9:20 AM
Arian_Bozorg removed Arian_Bozorg as the assignee of this task.
Arian_Bozorg updated the task description. (Show Details)
Arian_Bozorg moved this task from MEX Incoming column to Ready for Task Time (Story Writing) on the Wikidata-Omega board.
Arian_Bozorg subscribed.
Arian_Bozorg added a comment.Oct 8 2025, 2:34 PM

Notes from task time:

  • the ranking icon is different on the figma file
  • map are showing below the ranking icon on the figma file
Arian_Bozorg moved this task from Ready for Task Time (Story Writing) to The Backlog on the Wikidata-Omega board.Oct 8 2025, 2:48 PM
Sadiya.Mohammed_WMDE claimed this task.Oct 21 2025, 9:46 AM
Sadiya.Mohammed_WMDE moved this task from The Backlog to The Board on the Wikidata-Omega board.Oct 21 2025, 9:53 AM
Sadiya.Mohammed_WMDE edited projects, added Wikidata-Omega (The Board); removed Wikidata-Omega.
Sadiya.Mohammed_WMDE moved this task from new to the board to In Development on the Wikidata-Omega (The Board) board.
Sadiya.Mohammed_WMDE removed Sadiya.Mohammed_WMDE as the assignee of this task.Oct 29 2025, 8:26 AM
Sadiya.Mohammed_WMDE moved this task from In Development to Ready for Peer Review on the Wikidata-Omega (The Board) board.
Sadiya.Mohammed_WMDE subscribed.

I can't figure out the rank selector, and it was taking too much time. I discussed it with Lucas before his holiday and suggested that I leave it for someone else or pair program with someone to figure it out. The other parts, tho, have been worked on and are ready for review

ArthurTaylor assigned this task to Sadiya.Mohammed_WMDE.Nov 4 2025, 11:03 AM
gerritbot added a comment.Nov 6 2025, 10:40 AM

Change #1198350 had a related patch set uploaded (by Sadiya.mohammed13; author: Sadiya.mohammed13):

[mediawiki/extensions/Wikibase@master] cleanup for beta release

https://gerrit.wikimedia.org/r/1198350

gerritbot added a project: Patch-For-Review.Nov 6 2025, 10:40 AM
Sadiya.Mohammed_WMDE removed Sadiya.Mohammed_WMDE as the assignee of this task.Nov 10 2025, 2:29 PM
Sadiya.Mohammed_WMDE moved this task from Ready for Peer Review to In Development on the Wikidata-Omega (The Board) board.

Not sure if I should put it in review, cause as I said in the last comment, the ticket is not completed

gerritbot added a comment.Nov 12 2025, 3:20 PM

Change #1204604 had a related patch set uploaded (by Sadiya.mohammed13; author: Sadiya.mohammed13):

[mediawiki/extensions/Wikibase@master] add value to a new statements/ edit statements

https://gerrit.wikimedia.org/r/1204604

ArthurTaylor claimed this task.Fri, Nov 14, 10:03 AM
ArthurTaylor moved this task from In Development to In Peer Review on the Wikidata-Omega (The Board) board.
ArthurTaylor added a comment.Fri, Nov 14, 10:09 AM

The spacing of the references looks different, but not right:

2025-11-14-110724_481x504_scrot.png (504×481 px, 28 KB)

There is no gap between the up/down arrow and the '3 references', and the indentation of the references themselves doesn't seem to match the design. I think the arrow itself is also supposed to be underneath the rank selector

ArthurTaylor removed ArthurTaylor as the assignee of this task.Fri, Nov 14, 10:10 AM
ArthurTaylor moved this task from In Peer Review to Ready for Development on the Wikidata-Omega (The Board) board.
ArthurTaylor subscribed.
ArthurTaylor claimed this task.Mon, Nov 17, 7:42 AM
ArthurTaylor moved this task from Ready for Development to In Development on the Wikidata-Omega (The Board) board.
gerritbot added a comment.Mon, Nov 17, 11:45 AM

Change #1206352 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/Wikibase@master] Fix up some layout issues in MEX / wbui2025

https://gerrit.wikimedia.org/r/1206352

gerritbot added a comment.Tue, Nov 18, 10:15 AM

Change #1198350 abandoned by Arthur taylor:

[mediawiki/extensions/Wikibase@master] cleanup for beta release

Reason:

Abandoned in favour of I07a7466e7c0525c3710

https://gerrit.wikimedia.org/r/1198350

ArthurTaylor removed ArthurTaylor as the assignee of this task.Tue, Nov 18, 10:37 AM
ArthurTaylor moved this task from In Development to Ready for Peer Review on the Wikidata-Omega (The Board) board.
ArthurTaylor assigned this task to Sadiya.Mohammed_WMDE.Tue, Nov 18, 10:54 AM
ArthurTaylor moved this task from Ready for Peer Review to In Peer Review on the Wikidata-Omega (The Board) board.
ArthurTaylor removed Sadiya.Mohammed_WMDE as the assignee of this task.Thu, Nov 20, 11:49 AM
ArthurTaylor moved this task from In Peer Review to Ready for Peer Review on the Wikidata-Omega (The Board) board.
mahmoud.abdelsattar.wmde claimed this task.Fri, Nov 21, 8:26 AM
mahmoud.abdelsattar.wmde moved this task from Ready for Peer Review to In Peer Review on the Wikidata-Omega (The Board) board.
mahmoud.abdelsattar.wmde removed mahmoud.abdelsattar.wmde as the assignee of this task.Fri, Nov 21, 9:01 AM
mahmoud.abdelsattar.wmde moved this task from In Peer Review to Product Verification on the Wikidata-Omega (The Board) board.
mahmoud.abdelsattar.wmde subscribed.
gerritbot added a comment.Fri, Nov 21, 9:25 AM

Change #1206352 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Fix up some layout issues in MEX / wbui2025

https://gerrit.wikimedia.org/r/1206352

karapayneWMDE assigned this task to Alice.moutinho.Mon, Nov 24, 6:15 PM
karapayneWMDE subscribed.

Could you review what's on beta in regards to this task and confirm we've met all the a/cs please?

Alice.moutinho added a comment.Mon, Dec 1, 8:20 AM

will do @karapayneWMDE so sorry i only just saw this

Alice.moutinho added a comment.Mon, Dec 1, 10:08 AM

@karapayneWMDE checked! everything in the ticket is fixed.

Alice.moutinho removed Alice.moutinho as the assignee of this task.Mon, Dec 1, 10:20 AM
karapayneWMDE closed this task as Resolved.Mon, Dec 1, 1:51 PM
karapayneWMDE claimed this task.
karapayneWMDE moved this task from Product Verification to Done - Moving a task here will move it to the completed tasks workboard, resolve the ticket, and assign it to whomever made the move on the Wikidata-Omega (The Board) board.
karapayneWMDE edited projects, added Wikidata-Omega (Completed Tasks); removed Wikidata-Omega (The Board).
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits