Page MenuHomePhabricator

Moves not shown on Special:Watchlist if "Expand watchlist to show all changes, not just the most recent" is de-selected
Open, Needs TriagePublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Someone (not necessarily you) moved one of the pages on your watchlist.
  • The moved page is then subsequently edited.

What happens?: The move is not shown on Special:Watchlist if "Expand watchlist to show all changes, not just the most recent" is de-selected.

What should have happened instead?: The move is still shown on Special:Watchlist even if "Expand watchlist to show all changes, not just the most recent" is de-selected.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

One needs to see all log entries that affect pages on the watchlist. A move should not be hidden just because the moved page has subsequently been edited post-move.

The criteria for recent changes to be shown on Special:Watchlist if "Expand watchlist to show all changes, not just the most recent" is de-selected should be the following:

  • If rc_source is mw.edit or mw.new, then rc_this_oldid needs to match the page_latest of the relevant page.
  • If rc_source is mw.categorize, then only show the most recent page added to or removed from the category, regardless of whether the page has been subsequently edited after adding or removing the category.
  • If rc_source is mw.log, then always show all relevant changes.
  • Finally, extensions using other types in rc_source (e.g. wb and flow) would need their own criteria for determining whether a change should count as the "most recent".

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

@GTrang I can see how this has impacted your workflow, but I'm not sure your proposed outcome is correct:

The move is still shown on Special:Watchlist even if "Expand watchlist to show all changes, not just the most recent" is de-selected.

When an edit happens after a page move, the move is no longer the most recent change. The existing user interface allows for showing/hiding changes before the most recent change, so I think your proposed solution does not honor the meaning of those words.

It sounds like there is a need to show logged actions such as page moves, but still hide content edits before the most recent rev. Perhaps we need to add a new filter option to support that?

Was this previously working as you describe? If so, I suspect that it was emergent behavior. Note that there is ongoing work around consolidating change source fields used in rc/watchlist queries, so we may see changes in behavior as patches get deployed:
T403142
T404416