Page MenuHomePhabricator

Use of Html::successBox doesn't seem to be styled on Special:AccountSecurity
Closed, ResolvedPublic

Description

Added in rEOAT75c6f4eb9529: New UI for Special:AccountSecurity for T401774: Redesign UI for listing 2FA methods and adding new methods/T403683: Rename 2FA methods to friendlier names, the use of Html::successBox doesn't result in anything styled.. Should it?

It's fairly unnoticeable at the top as is.

Screenshot 2025-09-27 at 17.28.23.png (329×196 px, 14 KB)

Noticed while testing the patch for T404314: Redirect to Special:AccountSecurity once a new authentication method is added which reuses the same code, and displays similarly... not very noticeably.

<div class="cdx-message--success cdx-message cdx-message--block"><span class="cdx-message__icon"></span><div class="cdx-message__content"><strong>Authenticator app</strong> removed.</div></div>

Event Timeline

Reedy renamed this task from Use of Html::successBox doesn't seem to be styled to Use of Html::successBox doesn't seem to be styled on Special:AccountSecurity.Sep 27 2025, 4:48 PM
Reedy triaged this task as Low priority.

Change #1193007 had a related patch set uploaded (by Catrope; author: Catrope):

[mediawiki/extensions/OATHAuth@master] Load CdxMessage styles as part of Special:OATHManage styles

https://gerrit.wikimedia.org/r/1193007

It worked for me locally, but it looks like that was because I use Vector-2022, which already ships the cdx-message styles because it uses them for something else. In legacy Vector (and probably every other skin), it was broken per your screenshot.

Change #1193007 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@master] Load CdxMessage styles as part of Special:OATHManage styles

https://gerrit.wikimedia.org/r/1193007