Note that this functionality already exists: https://2f3545fe76.catalyst.wmcloud.org/w/index.php?title=Kristallsee&action=history

Currently, the tag Newcomer task: Revise Tone is linking to the (non-existing) section https://www.mediawiki.org/wiki/Help:Growth/Tools/Newcomer_Tasks#revise-tone

Though copy will be simple to adjust.

It goes without saying that we should not create a tag that confuses this task with Tone check, developed by the Editing team.

Are the messages system for different steps of the tutorial ready?

In T405856#11229530, @Trizek-WMF wrote:

Are the messages system for different steps of the tutorial ready?

Not even close. You should be able to see the latest version of the questions here https://www.figma.com/design/jtk84LZxotsHlyMTH56tls/T396164-improve-tone-suggested-edit?node-id=67-339&p=f&t=ckMon57H9JLPMDaT-0 but how we can actually make the i18n work is still an open and unsolved question. I created a task for looking into that: T406038: {Spike} Prepare spreadsheet for translation of Quiz-Copy.

Note from estimation: We didn't know whether this needs any further changes, since the tag is already there. Moving it from Up Next, as it was not estimable.

In T405856#11246850, @Urbanecm_WMF wrote:

Note from estimation: We didn't know whether this needs any further changes, since the tag is already there. Moving it from Up Next, as it was not estimable.

By this point, this should be mainly i18n changes: Newcomer task: Revise Tone -> Suggested: revise tone.

Now that I think about it, let me just do it, this is not worth the overhead of our processes.

Change #1194153 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/GrowthExperiments@master] i18n(Revise Tone): Adjust copy for change tag

https://gerrit.wikimedia.org/r/1194153

In T405856#11249303, @Michael wrote:

Now that I think about it, let me just do it, this is not worth the overhead of our processes.

Sounds good with me! We were very unclear what is left to do here, so that's why it was not estimated. +2'ed the patch.

Change #1194153 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] i18n(Revise Tone): Adjust copy for change tag

https://gerrit.wikimedia.org/r/1194153

@Michael Is there anything else we need to do here?

In any case: Can you (or maybe @KStoller-WMF) update the A/Cs to match reality? In the current case, I wouldn't know what to QA against were I the one testing this.

From the last meeting, I would not tag the edit as "Revise Tone" if the user ends up editing anything but the highlighted paragraph. Otherwise, the tagging will confuse the reviewers.

migr updated https://gitlab.wikimedia.org/repos/test-platform/catalyst/patchdemo/-/merge_requests/212

Draft: Growth: Make Revise Tone tasks work out-of-the-box

We're not the ones merging the associated change, but maybe a written +1 wouldn't hurt, if you approve of it: https://gitlab.wikimedia.org/repos/test-platform/catalyst/patchdemo/-/merge_requests/109

(And if you have concerns, please say so!)

migr opened https://gitlab.wikimedia.org/repos/test-platform/catalyst/ci-charts/-/merge_requests/99

Growth: Make Revise Tone tasks work out-of-the-box

jnuche merged https://gitlab.wikimedia.org/repos/test-platform/catalyst/ci-charts/-/merge_requests/99

Growth: Make Revise Tone tasks work out-of-the-box

jnuche merged https://gitlab.wikimedia.org/repos/test-platform/catalyst/patchdemo/-/merge_requests/212

Growth: Make Revise Tone tasks work out-of-the-box

As far as I can see, all code attached to this patch was reviewed & merged. Not sure what is left to do here, do we need to fix anything else?

QA Note: This can currently be tested on a new Patchdemo:

Steps to reproduce:

1. log in
2. go to your preferences and check all the boxes under the "Newcomer editor features" heading
3. go to Special:Homepage and click on a Revise Tone task
4. edit and save the article
5. check in the article history that the "Suggested: revise tone" tag appears

@Michael, Thanks for the steps, I'm curious if I create the patchdemo using the Gerrit link in T405856#11249375 will it include all of the gitlab merges made well after? I can't see how it would but I only ask because the Gerrit changeset number or Change-Id are the only ways I know how to generate a new patchdemo.

@Edtadros No, all changes have been merged into master. So the way to test these is to create a new patch-demo without any changes:

1. go to https://patchdemo.wmcloud.org/
2. start with the Wikimedia preset (the default) and explicitly add GrowthExperiments to the list of selected repos (see screenshot)

3. Click the blue "Create Demo" button

Test Result

Status: ✅ PASS
Test Details: T401195#11279755

This task’s QA is covered under T401195’s Revise Tone QA. In the master QA suite, we will validate that edits made via Revise Tone receive correct tags.