Page MenuHomePhabricator

Spacing between recovery codes buttons on Special:AccountSecurity isn't consistent
Closed, ResolvedPublic

Description

Screenshot 2025-09-29 at 09.08.41.png (200×615 px, 22 KB)

Event Timeline

I've narrowed down the problem here at least:

+++ b/src/HTMLForm/RecoveryCodesTrait.php
@@ -118,7 +118,7 @@ trait RecoveryCodesTrait {
        public function createRecoveryCodesCopyButton(): string {
                return Html::rawElement( 'button',
                        [
-                               'class' => 'cdx-button mw-oathauth-recoverycodes-copy-button',
+                               'class' => 'cdx-button',
                                'type' => 'button',
                        ], Html::element( 'span', [
                                'class' => 'cdx-button__icon',

I assume mw-oathauth-recoverycodes-copy-button isn't contributing anything of value for the new OATH UI, so I'll remove it in https://gerrit.wikimedia.org/r/1182964.

Er, that class is apparently still needed for the clipboard copying to work...

TheDJ claimed this task.
TheDJ subscribed.

Seems like this was fixed:

Screenshot 2025-10-14 at 15.10.50.png (410×1 px, 50 KB)