Page MenuHomePhabricator
Create Task
Maniphest T405922

Various core service factories doesn't work correctly when wiki ID contains a hyphen
Open, Needs TriagePublic
Actions

Description

For details, see T404118#11195674 and following comments. In short, it does the comparison $this->dbLoadBalancerFactory->getLocalDomainID() === $wikiId, but the LocalDomainID is encoded such that hyphen are replaced away, and thus it won't match a wiki ID obtained from, for example, WikiMap::getCurrentWikiID.

It looks like the fix would be to use WikiMap::getCurrentWikiID instead of getLocalDomainID, but this doesn't help with the fact that there seems to be confusion between wiki IDs and DB domains.

This pattern is used in at least 5 places (UserGroupManagerFactory, BlockRestrictionStoreFactory, DatabaseBlockStoreFactory, ActorStoreFactory, UserFactory).

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
user: Fix wiki ID comparison in UserGroupManagerFactoryDaimona Eaytoymediawiki/coremaster+2 -4
Customize query in gerrit

Related Objects

Event Timeline

Daimona created this task.Sep 29 2025, 3:25 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 29 2025, 3:25 PM
Daimona mentioned this in T404118: Fix CentralAuth for catalyst environments.Sep 29 2025, 3:26 PM
Daimona claimed this task.Sep 29 2025, 3:30 PM
gerritbot added a comment.Sep 29 2025, 3:35 PM

Change #1192158 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/core@master] user: Fix wiki ID comparison in UserGroupManagerFactory

https://gerrit.wikimedia.org/r/1192158

gerritbot added a project: Patch-For-Review.Sep 29 2025, 3:35 PM
Daimona added a comment.Sep 29 2025, 7:56 PM

I'm realizing now that we use the same pattern in 4 more places (BlockRestrictionStoreFactory, DatabaseBlockStoreFactory, ActorStoreFactory, UserFactory). I'm not sure what to do then. It'd be great if this confusion between domain ID and wiki ID could be clarified.

Daimona renamed this task from UserGroupManagerFactory::getUserGroupManager doesn't work correctly when wiki ID contains a hyphen to Various core service factories doesn't work correctly when wiki ID contains a hyphen.Oct 8 2025, 7:58 PM
Daimona updated the task description. (Show Details)
Daimona added a comment.Oct 8 2025, 8:03 PM
In T405922#11226682, @Daimona wrote:

I'm realizing now that we use the same pattern in 4 more places (BlockRestrictionStoreFactory, DatabaseBlockStoreFactory, ActorStoreFactory, UserFactory).

And I'm propagating the same code to RevisionStoreFactory as well, for T406777.

Daimona mentioned this in T407132: Introduce a value object for wiki IDs.Oct 13 2025, 3:13 PM
Daimona mentioned this in T224020: Create a class to represent the identity of wikis on the same wiki farm.Oct 13 2025, 4:19 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits