Page MenuHomePhabricator
Create Task
Maniphest T406003

Share the UI generation between Special:UserRights and Special:GlobalGroupMembership
Closed, ResolvedPublic
Actions

Description

In T405575: Share logic between Special:UserRights and Special:GlobalGroupMembership we want to unify Special:UserRights and Special:GlobalGroupMembership as much as possible. We can do so by introducing a new base abstract class, which will store the common logic. This class will be built incrementally, starting from the UI generation, which is conceptually almost the same on both special pages.

Acceptance criteria

  • The code for generating forms now lives in the base class
  • There are no functional changes to either of the special pages

Note: This task doesn't cover rewriting UI to a modern component library. It will be done later in T117884.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
S:GlobalGroupMembership: Add guard clauses for target typemediawiki/extensions/CentralAuthmaster+24 -4
UserRights: Refactor passing target to abstract methodsmediawiki/coremaster+78 -36
Start refactoring Special:UserRightsmediawiki/coremaster+550 -336
Adapt GlobalUserrights to changes in SpecialUserRightsmediawiki/extensions/GlobalUserrightsmaster+33 -5
UserRights: Add guard clauses for target typemediawiki/coremaster+38 -7
S:GlobalGroupMembership: Refactor displaying current groupsmediawiki/extensions/CentralAuthmaster+8 -37
S:GlobalGroupMembership: Accept target param, drop some methodsmediawiki/extensions/CentralAuthmaster+6 -38
S:GlobalGroupMembership: Drop showLogFragmentmediawiki/extensions/CentralAuthmaster+3 -11
S:GlobalGroupMembership: Drop getGroupName and doesWritesmediawiki/extensions/CentralAuthmaster+0 -14
S:GlobalGroupMembership: Accept target param in more methodsmediawiki/extensions/CentralAuthmaster+5 -15
UserRights: Extract showLogFragment to base classmediawiki/coremaster+37 -14
UserRights: Move getGroupName and doesWrites to base classmediawiki/coremaster+16 -10
UserGroupsSpecialPage: Pass $target to more methodsmediawiki/coremaster+28 -24
Hard deprecate SpecialUserRights::canProcessExpiriesmediawiki/coremaster+7 -2
Special:UserRights: Add testsmediawiki/coremaster+119 -0
UserRights: Remove canProcessExpiriesmediawiki/coremaster+106 -120
UserRights: Refactor displaying the current user groupsmediawiki/coremaster+139 -79
GlobalGroupMembership: Accept target as parameter in overriden methodsmediawiki/extensions/CentralAuthmaster+10 -10
UserRights: Properly disable Watch checkbox for remote usersmediawiki/coremaster+27 -22
S:GlobalGroupMembership: Fix Watch checkbox suppressionmediawiki/extensions/CentralAuthmaster+5 -0
S:GlobalGroupMembership: Extend UserGroupsSpecialPagemediawiki/extensions/CentralAuthmaster+88 -268
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

mszwarc created this task.Sep 30 2025, 9:02 AM
Tchanders moved this task from Priority backlog to Ready on the Product Safety and Integrity (Sprint Apfel Strudel (Sep 29 - Oct 17)) board.Sep 30 2025, 9:49 AM
mszwarc moved this task from Ready to In progress on the Product Safety and Integrity (Sprint Apfel Strudel (Sep 29 - Oct 17)) board.Sep 30 2025, 11:14 AM
gerritbot added a comment.Oct 1 2025, 9:23 AM

Change #1192850 had a related patch set uploaded (by Mszwarc; author: Mszwarc):

[mediawiki/core@master] Start refactoring Special:UserRights

https://gerrit.wikimedia.org/r/1192850

gerritbot added a project: Patch-For-Review.Oct 1 2025, 9:23 AM

Change #1192851 had a related patch set uploaded (by Mszwarc; author: Mszwarc):

[mediawiki/extensions/CentralAuth@master] S:GlobalGroupMembership: Extend UserGroupsSpecialPage

https://gerrit.wikimedia.org/r/1192851

gerritbot added a comment.Oct 2 2025, 7:17 AM

Change #1193018 had a related patch set uploaded (by Mszwarc; author: Mszwarc):

[mediawiki/core@master] UserRights: Properly disable Watch checkbox for remote users

https://gerrit.wikimedia.org/r/1193018

gerritbot added a comment.Oct 2 2025, 7:18 AM

Change #1193019 had a related patch set uploaded (by Mszwarc; author: Mszwarc):

[mediawiki/core@master] UserRights: Refactor passing target to abstract methods

https://gerrit.wikimedia.org/r/1193019

gerritbot added a comment.Oct 2 2025, 7:18 AM

Change #1193020 had a related patch set uploaded (by Mszwarc; author: Mszwarc):

[mediawiki/extensions/CentralAuth@master] S:GlobalGroupMembership: Fix Watch checkbox suppression

https://gerrit.wikimedia.org/r/1193020

gerritbot added a comment.Oct 2 2025, 7:18 AM

Change #1193021 had a related patch set uploaded (by Mszwarc; author: Mszwarc):

[mediawiki/extensions/CentralAuth@master] GlobalGroupMembership: Accept target as parameter in overriden methods

https://gerrit.wikimedia.org/r/1193021

gerritbot added a comment.Oct 3 2025, 7:34 AM

Change #1193315 had a related patch set uploaded (by Mszwarc; author: Mszwarc):

[mediawiki/core@master] UserRights: Refactor displaying the current user groups

https://gerrit.wikimedia.org/r/1193315

gerritbot added a comment.Oct 3 2025, 7:34 AM

Change #1193316 had a related patch set uploaded (by Mszwarc; author: Mszwarc):

[mediawiki/extensions/CentralAuth@master] S:GlobalGroupMembership: Refactor displaying current groups

https://gerrit.wikimedia.org/r/1193316

gerritbot added a comment.Oct 3 2025, 10:36 AM

Change #1192850 merged by jenkins-bot:

[mediawiki/core@master] Start refactoring Special:UserRights

https://gerrit.wikimedia.org/r/1192850

gerritbot added a comment.Oct 3 2025, 10:36 AM

Change #1192851 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] S:GlobalGroupMembership: Extend UserGroupsSpecialPage

https://gerrit.wikimedia.org/r/1192851

gerritbot added a comment.Oct 3 2025, 10:38 AM

Change #1193018 merged by jenkins-bot:

[mediawiki/core@master] UserRights: Properly disable Watch checkbox for remote users

https://gerrit.wikimedia.org/r/1193018

gerritbot added a comment.Oct 3 2025, 10:38 AM

Change #1193020 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] S:GlobalGroupMembership: Fix Watch checkbox suppression

https://gerrit.wikimedia.org/r/1193020

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.22; 2025-10-07).Oct 3 2025, 11:00 AM
gerritbot added a comment.Oct 3 2025, 12:43 PM

Change #1193408 had a related patch set uploaded (by Mszwarc; author: Mszwarc):

[mediawiki/core@master] Special:UserRights: Add tests

https://gerrit.wikimedia.org/r/1193408

gerritbot added a comment.Oct 3 2025, 3:07 PM

Change #1193019 merged by jenkins-bot:

[mediawiki/core@master] UserRights: Refactor passing target to abstract methods

https://gerrit.wikimedia.org/r/1193019

gerritbot added a comment.Oct 3 2025, 3:38 PM

Change #1193021 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] GlobalGroupMembership: Accept target as parameter in overriden methods

https://gerrit.wikimedia.org/r/1193021

gerritbot added a comment.Oct 3 2025, 4:36 PM

Change #1193315 merged by jenkins-bot:

[mediawiki/core@master] UserRights: Refactor displaying the current user groups

https://gerrit.wikimedia.org/r/1193315

gerritbot added a comment.Oct 3 2025, 4:36 PM

Change #1193316 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] S:GlobalGroupMembership: Refactor displaying current groups

https://gerrit.wikimedia.org/r/1193316

gerritbot added a comment.Oct 6 2025, 7:48 AM

Change #1193779 had a related patch set uploaded (by Mszwarc; author: Mszwarc):

[mediawiki/core@master] UserRights: Remove canProcessExpiries

https://gerrit.wikimedia.org/r/1193779

gerritbot added a comment.Oct 6 2025, 11:19 AM

Change #1193779 abandoned by Mszwarc:

[mediawiki/core@master] UserRights: Remove canProcessExpiries

Reason:

canProcessExpiries should be deprecated first

https://gerrit.wikimedia.org/r/1193779

gerritbot added a comment.Oct 6 2025, 12:43 PM

Change #1193831 had a related patch set uploaded (by Mszwarc; author: Mszwarc):

[mediawiki/core@master] Hard deprecate SpecialUserRights::canProcessExpiries

https://gerrit.wikimedia.org/r/1193831

gerritbot added a comment.Oct 6 2025, 1:07 PM

Change #1193408 merged by jenkins-bot:

[mediawiki/core@master] Special:UserRights: Add tests

https://gerrit.wikimedia.org/r/1193408

gerritbot added a comment.Oct 6 2025, 1:09 PM

Change #1193839 had a related patch set uploaded (by Mszwarc; author: Mszwarc):

[mediawiki/core@master] UserGroupsSpecialPage: Pass $target to more methods

https://gerrit.wikimedia.org/r/1193839

gerritbot added a comment.Oct 6 2025, 1:09 PM

Change #1193840 had a related patch set uploaded (by Mszwarc; author: Mszwarc):

[mediawiki/extensions/CentralAuth@master] S:GlobalGroupMembership: Accept target param in more methods

https://gerrit.wikimedia.org/r/1193840

Tchanders mentioned this in T404436: Investigate implementing requirements for membership of local groups.Oct 6 2025, 1:51 PM
gerritbot added a comment.Oct 7 2025, 5:53 AM

Change #1193831 merged by jenkins-bot:

[mediawiki/core@master] Hard deprecate SpecialUserRights::canProcessExpiries

https://gerrit.wikimedia.org/r/1193831

ReleaseTaggerBot edited projects, added MW-1.45-notes (1.45.0-wmf.23; 2025-10-14); removed MW-1.45-notes (1.45.0-wmf.22; 2025-10-07).Oct 7 2025, 6:00 AM
gerritbot added a comment.Oct 7 2025, 7:36 AM

Change #1194117 had a related patch set uploaded (by Mszwarc; author: Mszwarc):

[mediawiki/core@master] UserRights: Extract showLogFragment to base class

https://gerrit.wikimedia.org/r/1194117

gerritbot added a comment.Oct 7 2025, 7:36 AM

Change #1194118 had a related patch set uploaded (by Mszwarc; author: Mszwarc):

[mediawiki/extensions/CentralAuth@master] S:GlobalGroupMembership: Drop showLogFragment

https://gerrit.wikimedia.org/r/1194118

gerritbot added a comment.Oct 7 2025, 9:49 AM

Change #1194146 had a related patch set uploaded (by Mszwarc; author: Mszwarc):

[mediawiki/core@master] UserRights: Move getGroupName and doesWrites to base class

https://gerrit.wikimedia.org/r/1194146

gerritbot added a comment.Oct 7 2025, 9:49 AM

Change #1194147 had a related patch set uploaded (by Mszwarc; author: Mszwarc):

[mediawiki/extensions/CentralAuth@master] S:GlobalGroupMembership: Drop getGroupName and doesWrites

https://gerrit.wikimedia.org/r/1194147

gerritbot added a comment.Oct 7 2025, 10:50 AM

Change #1194162 had a related patch set uploaded (by Mszwarc; author: Mszwarc):

[mediawiki/core@master] UserRights: Add guard clauses for target type

https://gerrit.wikimedia.org/r/1194162

gerritbot added a comment.Oct 7 2025, 10:50 AM

Change #1194163 had a related patch set uploaded (by Mszwarc; author: Mszwarc):

[mediawiki/extensions/CentralAuth@master] S:GlobalGroupMembership: Add guard clauses for target type

https://gerrit.wikimedia.org/r/1194163

gerritbot added a comment.Oct 7 2025, 11:36 AM

Change #1194178 had a related patch set uploaded (by Mszwarc; author: Mszwarc):

[mediawiki/extensions/GlobalUserrights@master] Adapt GlobalUserrights to changes in SpecialUserRights

https://gerrit.wikimedia.org/r/1194178

mszwarc moved this task from In progress to Needs review on the Product Safety and Integrity (Sprint Apfel Strudel (Sep 29 - Oct 17)) board.Oct 7 2025, 12:35 PM

Moving this task to Needs Review, as I've implemented all the refactorings related to UI that I planned.

gerritbot added a comment.Oct 7 2025, 1:10 PM

Change #1193839 merged by jenkins-bot:

[mediawiki/core@master] UserGroupsSpecialPage: Pass $target to more methods

https://gerrit.wikimedia.org/r/1193839

gerritbot added a comment.Oct 7 2025, 1:13 PM

Change #1194146 merged by jenkins-bot:

[mediawiki/core@master] UserRights: Move getGroupName and doesWrites to base class

https://gerrit.wikimedia.org/r/1194146

gerritbot added a comment.Oct 7 2025, 1:13 PM

Change #1194117 merged by jenkins-bot:

[mediawiki/core@master] UserRights: Extract showLogFragment to base class

https://gerrit.wikimedia.org/r/1194117

gerritbot added a comment.Oct 7 2025, 1:41 PM

Change #1194196 had a related patch set uploaded (by Mszwarc; author: Mszwarc):

[mediawiki/extensions/CentralAuth@master] S:GlobalGroupMembership: Accept target param, drop some methods

https://gerrit.wikimedia.org/r/1194196

gerritbot added a comment.Oct 7 2025, 2:03 PM

Change #1193840 abandoned by Mszwarc:

[mediawiki/extensions/CentralAuth@master] S:GlobalGroupMembership: Accept target param in more methods

Reason:

It was squashed into 1194196 to unblock CI

https://gerrit.wikimedia.org/r/1193840

gerritbot added a comment.Oct 7 2025, 2:04 PM

Change #1194147 abandoned by Mszwarc:

[mediawiki/extensions/CentralAuth@master] S:GlobalGroupMembership: Drop getGroupName and doesWrites

Reason:

It was squashed into 1194196 to unblock CI

https://gerrit.wikimedia.org/r/1194147

gerritbot added a comment.Oct 7 2025, 2:04 PM

Change #1194118 abandoned by Mszwarc:

[mediawiki/extensions/CentralAuth@master] S:GlobalGroupMembership: Drop showLogFragment

Reason:

It was squashed into 1194196 to unblock CI

https://gerrit.wikimedia.org/r/1194118

gerritbot added a comment.Oct 7 2025, 2:04 PM

Change #1194196 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] S:GlobalGroupMembership: Accept target param, drop some methods

https://gerrit.wikimedia.org/r/1194196

gerritbot added a comment.Oct 9 2025, 10:09 AM

Change #1194163 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] S:GlobalGroupMembership: Add guard clauses for target type

https://gerrit.wikimedia.org/r/1194163

gerritbot added a comment.Oct 9 2025, 10:11 AM

Change #1194162 merged by jenkins-bot:

[mediawiki/core@master] UserRights: Add guard clauses for target type

https://gerrit.wikimedia.org/r/1194162

gerritbot added a comment.Oct 9 2025, 11:05 AM

Change #1194178 abandoned by Mszwarc:

[mediawiki/extensions/GlobalUserrights@master] Adapt GlobalUserrights to changes in SpecialUserRights

Reason:

There will be more changes needed, as work progresses in T405575, so let's not waste our time on this, given that we're not its maintainers.

https://gerrit.wikimedia.org/r/1194178

mszwarc closed this task as Resolved.Oct 9 2025, 11:06 AM
mszwarc moved this task from Needs review to Done on the Product Safety and Integrity (Sprint Apfel Strudel (Sep 29 - Oct 17)) board.

The UI part refactor is done

Maintenance_bot removed a project: Patch-For-Review.Oct 9 2025, 11:30 AM
Tacsipacsi subscribed.Oct 10 2025, 8:13 AM
Tchanders mentioned this in T410076: Allow technically enforcing policies for restricted global groups.Nov 13 2025, 6:43 PM
• matmarex mentioned this in T395365: Modernise and unify UI for Special:UserRights and Special:GlobalUserRights.Feb 9 2026, 4:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits