Maniphest T406075

safe guard checks for functions on parsed objects
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	ecarg
	Sep 30 2025, 9:53 PM

Tags

Referenced Files

None

Subscribers

Description

I found one full request flow from one request-id of this but running it locally, it didn't render the error:

Z1.isValidated() is not a function ex

These I was not able reproduce locally; there wasn't a full request lifecycle linked to the request-id's of these error logs that would aid me in reproducing them:

Z1.isFullyResolved is not a function ex
this.functor_ is not a function ex

These I was able to reproduce and address them in the MR:

TypeError: cannot read properties of undefined (reading 'z6k1') ex
TypeError: Cannot convert undefined or null to object ex
TypeError: Cannot read properties of null (reading 'Z9K1'). ex

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	wikifunctions: Upgrade orchestrator from 2025-11-18-175356 to 2025-11-26-175208	operations/deployment-charts	master	+1 -1

Customize query in gerrit

Related Changes in GitLab:

	Title	Reference	Author	Source Branch	Dest Branch
	fail fast when objects are undefined and add debug logs	repos/abstract-wiki/wikifunctions/function-orchestrator!460	ecarg	grace/T406075/add-safe-guards-on-json-objs	main

Customize query in GitLab

Event Timeline

ecarg created this task.Sep 30 2025, 9:53 PM

ecarg changed the task status from Open to In Progress.

ecarg triaged this task as Medium priority.

ecarg updated the task description. (Show Details)

ecarg updated the task description. (Show Details)

ecarg opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/460

Draft: safe-guard parsed json objects before validating

Jdforrester-WMF edited projects, added Abstract Wikipedia team (26Q1 (Jul–Sep)); removed Abstract Wikipedia team.Oct 1 2025, 5:53 PM

Jdforrester-WMF moved this task from Incoming to In Engineering on the Abstract Wikipedia team (26Q1 (Jul–Sep)) board.

Jdforrester-WMF moved this task from In Engineering to In Code review on the Abstract Wikipedia team (26Q1 (Jul–Sep)) board.Oct 2 2025, 4:18 PM

Jdforrester-WMF edited projects, added Abstract Wikipedia team (26Q2 (Oct–Dec)); removed Abstract Wikipedia team (26Q1 (Jul–Sep)).Oct 3 2025, 3:27 PM

Jdforrester-WMF moved this task from Incoming to In Code review on the Abstract Wikipedia team (26Q2 (Oct–Dec)) board.Oct 7 2025, 3:00 PM

Jdforrester-WMF added a project: Essential-Work.Oct 16 2025, 2:10 PM

ecarg updated the task description. (Show Details)Nov 14 2025, 7:00 AM

ecarg updated the task description. (Show Details)

ecarg updated the task description. (Show Details)Nov 14 2025, 7:36 AM

ecarg updated the task description. (Show Details)Nov 14 2025, 10:49 PM

ecarg updated the task description. (Show Details)

ecarg updated the task description. (Show Details)Nov 15 2025, 2:16 AM

ecarg updated the task description. (Show Details)Nov 15 2025, 3:28 AM

apine merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/460

fail fast when objects are undefined and add debug logs

Maintenance_bot removed a project: Patch-For-Review.Tue, Nov 25, 11:30 PM

Change #1211875 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2025-11-18-175356 to 2025-11-26-175208

https://gerrit.wikimedia.org/r/1211875

gerritbot added a project: Patch-For-Review.Thu, Nov 27, 1:21 AM

Change #1211875 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2025-11-18-175356 to 2025-11-26-175208

https://gerrit.wikimedia.org/r/1211875

Maintenance_bot removed a project: Patch-For-Review.Thu, Nov 27, 1:30 AM

Some of these are pending local reproducibility and will be completed in followup tasks; new error returns addressed in the linked MR are resolved