Page MenuHomePhabricator

IPReputation/PreAuthenticationProvider: Do not block on IPoid response
Closed, ResolvedPublic

Description

Summary

IPReputation's PreAuthenticationProvider class (code) calls IPoid, and logs information derived from IPoid in Logstash and Prometheus. This should be done in a deferred update, because we do not need testForAccountCreation to prevent requests based on this information.

Technical notes

As part of this work, we can remove the config for IPReputationIPoidCheckAtAccountCreationLogOnly and make that the default behavior -- IPReputation/PreAuthenticationProvider should just log, never deny an action, and the logging should happen in a deferred update

Acceptance criteria

  • Remove the code that can deny a request based on IPoid data
  • Place the logging code in a deferred update

Event Timeline

Change #1193867 had a related patch set uploaded (by STran; author: STran):

[mediawiki/extensions/IPReputation@master] Don't block testForAccountCreation on IPoid data

https://gerrit.wikimedia.org/r/1193867

Change #1193867 merged by jenkins-bot:

[mediawiki/extensions/IPReputation@master] Don't block testForAccountCreation on IPoid data

https://gerrit.wikimedia.org/r/1193867