Duplicate images from other wikis
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	matthiasmullie
	Oct 1 2025, 3:07 PM

Description

From T402966#11232544:

Go to https://24f17e0e4a.catalyst.wmcloud.org/wiki/London?imageBrowsing=1&useskin=minerva#/imagebrowsing/File:London_Skyline_(125508655).jpeg

Observed: I am seeing a few duplicates in testing.

Screenshot 2025-10-01 at 11.40.28.png (1×990 px, 673 KB)

Expected: No duplicates
(I'll flesh out this ticket with more detail tomorrow)

Requirement

When viewing the Image Browsing feature, no duplicate images from other wikis should appear in the carousel or detail view. The image results must be unique and sorted primarily by frequency of reuse across Wikimedia projects. The feature must correctly merge and order results even when different services (e.g., search relevance and globalusage) return items in varying sequences.

BDD

Feature: Prevent duplicate images and ensure proper sorting in Image Browsing

Scenario: Image Browsing displays unique images across multiple wiki sources
  Given the user opens an article with Image Browsing enabled
  When the carousel loads images from multiple sources (including globalusage)
  Then each image should appear only once

Test Steps

Test Case 1: Verify no duplicate images appear in Image Browsing

Navigate to https://24f17e0e4a.catalyst.wmcloud.org/wiki/London?imageBrowsing=1&useskin=minerva#/imagebrowsing/File:London_Skyline_(125508655).jpeg
Observe the image carousel and detail view
AC1: No duplicate images appear in the carousel or detail view

QA Results - Patchdemo

AC	Status	Details
1	✅	T406139#11265354

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Fix fetching media from other wikis	mediawiki/extensions/ReaderExperiments	master	+29 K -41

Customize query in gerrit

Related Objects

Mentioned In: T405992: Image Browsing: UI Bug Bash
Mentioned Here: T402966: Image Browsing: Create the UI for "images from other wikis"

Event Timeline

matthiasmullie created this task.Oct 1 2025, 3:07 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 1 2025, 3:07 PM

matthiasmullie claimed this task.Oct 1 2025, 3:07 PM

ovasileva updated the task description. (Show Details)Oct 1 2025, 4:10 PM

ovasileva triaged this task as High priority.Oct 1 2025, 4:12 PM

ovasileva removed a project: Reader Growth Team (Sprint 6).

ovasileva added a project: Reader Growth Team.

matthiasmullie edited projects, added Reader Growth Team (Sprint 1 (Sep 20 - Oct 13) Q2 2025/2026); removed Reader Growth Team.Oct 1 2025, 7:57 PM

matthiasmullie mentioned this in T405992: Image Browsing: UI Bug Bash.Oct 2 2025, 9:48 PM

matthiasmullie moved this task from Committed to Doing on the Reader Growth Team (Sprint 1 (Sep 20 - Oct 13) Q2 2025/2026) board.Oct 6 2025, 3:59 PM

Change #1194187 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):

[mediawiki/extensions/ReaderExperiments@master] Fix fetching media from other wikis

https://gerrit.wikimedia.org/r/1194187

gerritbot added a project: Patch-For-Review.Oct 7 2025, 12:37 PM

matthiasmullie moved this task from Doing to Code Review on the Reader Growth Team (Sprint 1 (Sep 20 - Oct 13) Q2 2025/2026) board.Oct 7 2025, 12:41 PM

There were some issues where the code was assuming results coming in in releveance order, but that was not the case (and to make things worse, globalusage was coming in in yet another order)
It was not only causing duplicates (caused by the first problem), but also dropped perfectly valid results (caused by the 2nd)

Anwyay, there's a patch that should fix this. And it also changes the sort to be more heavily based on how extensively media is re-used, which is more in line with how we present this feature (and subjectively yields much better results for the articles I tested on)

Change #1194187 merged by jenkins-bot:

[mediawiki/extensions/ReaderExperiments@master] Fix fetching media from other wikis

https://gerrit.wikimedia.org/r/1194187

Maintenance_bot removed a project: Patch-For-Review.Oct 9 2025, 7:31 PM

bvibber moved this task from Code Review to QA on the Reader Growth Team (Sprint 1 (Sep 20 - Oct 13) Q2 2025/2026) board.Oct 9 2025, 7:41 PM

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.23; 2025-10-14).Oct 9 2025, 8:00 PM

Edtadros attached a referenced file: F66716455: Screenshot 2025-10-01 at 11.40.28.png. (Show Details)Oct 10 2025, 5:51 PM

Edtadros updated the task description. (Show Details)Oct 10 2025, 6:09 PM

Edtadros updated the task description. (Show Details)Oct 10 2025, 6:19 PM

Test Result - Patchdemo

Status: ✅ PASS
Environment: patchdemo (https://24f17e0e4a.catalyst.wmcloud.org)
OS: macOS Sequoia 15.5
Browser: Chrome Canary (latest as of test date)
Device: MS
Emulated Device: NA

Test Case 1: Verify no duplicate images appear in Image Browsing