Splitting a bug report from T393240.
This can be reproduced by making a change via Special:CommunityConfiguration/BlockedDomain. The expected behaviour is that MediaWiki:BlockedExternalDomains.json holds an array, not an object.
Splitting a bug report from T393240.
This can be reproduced by making a change via Special:CommunityConfiguration/BlockedDomain. The expected behaviour is that MediaWiki:BlockedExternalDomains.json holds an array, not an object.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Move sorting values into DataProvider | mediawiki/extensions/CommunityConfiguration | master | +28 -11 |
Change #1192891 had a related patch set uploaded (by Urbanecm; author: Urbanecm):
[mediawiki/extensions/CommunityConfiguration@master] Move sorting values into DataProvider
Change #1192891 merged by jenkins-bot:
[mediawiki/extensions/CommunityConfiguration@master] Move sorting values into DataProvider
Status: ⬜ Not QA Testable
Rationale: Backend/config storage issue (objects vs arrays) not visible in UI interactions.
This should be testable with admin permissions, as the storage is on-wiki (MediaWiki:BlockedExternalDomains.json, specifically). For example, as of writing, MediaWiki:BlockedExternalDomains.json@cswiki looks like this (permalink):
{ "0": { "domain": "atchina.com.cn", "notes": "[[.dm.bat]] a jiné od jakéhosi čínského automatu (importováno z [[Special:PermaLink/22560138|MediaWiki:Spam-blacklist]])" }, "1": { "domain": "caws.cn", "notes": "[[.dm.bat]] a jiné od jakéhosi čínského automatu (importováno z [[Special:PermaLink/22560138|MediaWiki:Spam-blacklist]])" }, // ... }
As you can see, it is an object with a numeric index. If I use Special:CommunityConfiguration/BlockedDomain to save something (for example, I blocked test-domain.example), the format should fix. On cswiki, it doesn't work yet (as it is on wmf.21, and the patch is in wmf.22), but it should once the train rolls forward.
I think we should test that:
I'm not sure if you need any extra permissions for this – if needed, I'm happy to assign adminship on test.wikipedia.org and/or beta wikis.
The second of those bullets appears to be validated in production based on https://en.wikipedia.org/w/index.php?title=MediaWiki:BlockedExternalDomains.json&diff=prev&oldid=1316015275 occurring.