Page MenuHomePhabricator
Create Task
Maniphest T406153

venmo donation create new cid instead of use old cid
Closed, ResolvedPublic
Actions

Description

With same email address, 68566305 still get created with new venmo donation, need to update the logic to honor the venmo external id

  • if venmo user id and email match, return oldest cid
  • if no venmo user id before but a venmo donation, do not check the firstname lastname, email is sufficient already return oldest cid
  • We were getting @xxxx for our venmo id with braintree venmo, while Gravy do not return @ in front, add to gravy (add a logic to check if venmo user name do not have @ add it)

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Reapply the data cleanup after we have the convert patch deploiedWfanwikimedia/fundraising/crmmaster+13 -0
Add more lowConfidence payment method sourcesWfanwikimedia/fundraising/crmmaster+63 -12
Reapply the data cleanup after we have the convert patch deploiedWfanwikimedia/fundraising/crmmaster+13 -0
Tie venmo username to use prefix @ for allWfanwikimedia/fundraising/crmmaster+7 -3
Align braintree venmo and gravy venmo usernameWfanwikimedia/fundraising/crmmaster+15 -0
Customize query in gerrit

Related Objects

Event Timeline

AnnWF created this task.Oct 1 2025, 5:16 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 1 2025, 5:16 PM
XenoRyet moved this task from Triage to Chaos Crew Backlog on the Fundraising-Backlog board.Oct 6 2025, 8:28 PM
AnnWF claimed this task.Oct 8 2025, 11:45 AM
AnnWF moved this task from Backlog to In Progress on the Fundraising Tech - Chaos Crew board.
AnnWF moved this task from In Progress to Ready for Review on the Fundraising Tech - Chaos Crew board.Oct 14 2025, 6:08 PM
AnnWF added a comment.Oct 14 2025, 6:12 PM

https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1196140

AnnWF updated the task description. (Show Details)Oct 15 2025, 9:29 PM
gerritbot added a comment.Oct 16 2025, 1:16 AM

Change #1196546 had a related patch set uploaded (by Wfan; author: Wfan):

[wikimedia/fundraising/crm@master] Add more lowConfidence payment method sources

https://gerrit.wikimedia.org/r/1196546

gerritbot added a project: Patch-For-Review.Oct 16 2025, 1:16 AM

Change #1196140 had a related patch set uploaded (by Wfan; author: Wfan):

[wikimedia/fundraising/crm@master] Add more lowConfidence payment method sources

https://gerrit.wikimedia.org/r/1196140

gerritbot added a comment.Oct 30 2025, 12:22 AM

Change #1199884 had a related patch set uploaded (by Wfan; author: Wfan):

[wikimedia/fundraising/crm@master] Align braintree venmo and gravy venmo username

https://gerrit.wikimedia.org/r/1199884

AnnWF moved this task from Ready for Review to Being Reviewed on the Fundraising Tech - Chaos Crew board.Nov 3 2025, 8:18 PM
gerritbot added a comment.Nov 4 2025, 6:57 PM

Change #1199884 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Align braintree venmo and gravy venmo username

https://gerrit.wikimedia.org/r/1199884

gerritbot added a comment.Nov 5 2025, 10:37 PM

Change #1202319 had a related patch set uploaded (by Wfan; author: Wfan):

[wikimedia/fundraising/crm@master] Tie venmo username to use the one without @ for all Since it's not stable pass over to civi

https://gerrit.wikimedia.org/r/1202319

gerritbot added a comment.Nov 6 2025, 12:52 AM

Change #1202319 merged by Wfan:

[wikimedia/fundraising/crm@master] Tie venmo username to use prefix @ for all

https://gerrit.wikimedia.org/r/1202319

gerritbot added a comment.Nov 25 2025, 8:13 PM

Change #1211229 had a related patch set uploaded (by Wfan; author: Wfan):

[wikimedia/fundraising/crm@master] Reapply the data cleanup after we have the convert patch deploied

https://gerrit.wikimedia.org/r/1211229

gerritbot added a comment.Nov 25 2025, 8:34 PM

Change #1211232 had a related patch set uploaded (by Wfan; author: Wfan):

[wikimedia/fundraising/crm@master] Reapply the data cleanup after we have the convert patch deploied

https://gerrit.wikimedia.org/r/1211232

gerritbot added a comment.Nov 25 2025, 8:34 PM

Change #1211232 abandoned by Wfan:

[wikimedia/fundraising/crm@master] Reapply the data cleanup after we have the convert patch deploied

https://gerrit.wikimedia.org/r/1211232

gerritbot added a comment.Dec 6 2025, 2:31 AM

Change #1196140 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Add more lowConfidence payment method sources

https://gerrit.wikimedia.org/r/1196140

XenoRyet triaged this task as Low priority.Dec 8 2025, 9:01 PM
gerritbot added a comment.Jan 9 2026, 8:18 PM

Change #1211229 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Reapply the data cleanup after we have the convert patch deploied

https://gerrit.wikimedia.org/r/1211229

AnnWF moved this task from Being Reviewed to Done on the Fundraising Tech - Chaos Crew board.Jan 12 2026, 8:48 PM
XenoRyet closed this task as Resolved.Jan 12 2026, 8:57 PM
XenoRyet set Final Story Points to 8.
Damilare mentioned this in T414520: Fundraising Sprint Y Priorities.Jan 13 2026, 6:57 PM
Damilare mentioned this in T415697: Fundraising Sprint A Priorities.Jan 27 2026, 6:13 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits