For most checks, we wouldn't want to steal focus and hide the keyboard as the user may still be typing, but for paste check the user is not usually using the keyboard in that moment, so stealing focus seems less disruptive.
Description
Description
Details
Details
- Other Assignee
- Ryasmeen
Related Changes in Gerrit:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Paste check: Show the check immediately on mobile | mediawiki/extensions/VisualEditor | master | +21 -0 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T265163 Create a system to encode best practices into editing experiences | |||
| In Progress | nayoub | T359107 Paste Check: Prompt people pasting text to consider risk of copyright violation | |||
| Open | None | T405127 [MILESTONE] Deploy Paste Check to all Wikipedias | |||
| Open | ppelberg | T392954 [FY25-26] WE 1.1: Increase constructive edits | |||
| Resolved | MNeisler | T399669 [WE 1.1.1] Run an A/B test to evaluate impact of Paste Check | |||
| Resolved | Esanders | T406164 Paste check: show the check card immediately on mobile |
Event Timeline
Comment Actions
Change #1192941 had a related patch set uploaded (by Esanders; author: Esanders):
[mediawiki/extensions/VisualEditor@master] Paste check: Show the check immediately on mobile
Comment Actions
Test wiki created on Patch demo by ESanders (WMF) using patch(es) linked to this task:
https://c8489caee1.catalyst.wmcloud.org/wiki/Douglas Adams?mobileaction=toggle_view_mobile&ecenable=2#/editor/0
Comment Actions
Test wiki created on Patch demo by ESanders (WMF) using patch(es) linked to this task:
https://9466d77614.catalyst.wmcloud.org/wiki/Douglas Adams?mobileaction=toggle_view_mobile&ecenable=2#/editor/0
Comment Actions
Test wiki on Patch demo by ESanders (WMF) using patch(es) linked to this task was deleted:
Comment Actions
Next step
Let's move forward with Approach #2 upon pasting, hide the person's keyboard in order to show them the Paste Check card.
Note: this is what Ed implemented in T406164#11236427.
Thinking
Per offline discussion, there are two obvious ways we can show Paste Check to someone on mobile:
- Approach #1: upon pasting, show people the Edit Check gutter while keeping their keyboard up
- Approach #2: upon pasting, hide the person's keyboard in order to show them the Paste Check card
Both approaches bear the risk of interrupting someone and therefore, lowering the likelihood that they shift their attention away from what they were doing/wanting to do to engage with what Paste Check is asking them, perhaps unexpectedly, to consider.
With the above said, I think someone will be more likely to engage with Paste Check if we present to them as early as possible, before they're likely to have made changes that build upon the paste.
We will evaluate the extent to which this is true by way of T400098 and T399669 wherein we will look at the proportion of Paste Checks people dismiss. I've updated both tickets to include a mention of this decision so we can consider it when reviewing the results of these analyses.
Comment Actions
Change #1192941 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Paste check: Show the check immediately on mobile
Comment Actions
Found and filed an issue : https://phabricator.wikimedia.org/T407089, while testing this.
Comment Actions
Also, T407426: On mobile: The pagination arrows disappear after undoing the removal of a pasted content
Comment Actions
@DLynch: Would you say the two issues filed above surfaced as a result of this fix, or should we close this?
Comment Actions
Those seem like they'd be unrelated, and the other tickets exist already anyway, so either way we might as well close this one if you're satisfied with the basic "paste check shows immediately after a paste" behavior.