Minor table fixup rendering diff from pipe in table row attribute position
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	ABreault-WMF
	Oct 2 2025, 1:34 AM

Description

From https://sl.wikipedia.org/wiki/Svetovno_prvenstvo_v_nogometu_1974

{|
|- style=font-size:85%|0 – 2 
| hi
|}

Legacy

<table>

<tbody><tr style="font-size:85%&#124;0">
<td>hi
</td></tr></tbody></table>

Parsoid

<table id="mwAg">
<tbody id="mwAw"><tr style="font-size:85%" id="mwBA"> 
<td id="mwBQ">hi</td></tr>
</tbody></table>

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
Bump wikimedia/parsoid to 0.23.0-a20	mediawiki/vendor	master	+353 -207
Grammar: Allow pipe in table attribute value	mediawiki/services/parsoid	master	+82 -9
Grammar: Allow pipe in table attribute value	mediawiki/services/parsoid	master	+4 -4

Customize query in gerrit

Event Timeline

ABreault-WMF created this task.Oct 2 2025, 1:34 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 2 2025, 1:34 AM

I am inclined to decline this as an edge-case wont-fix, and even Parsoid is accidentally doing what the user intended, we can take it and let it be?

I'm not sure the user's intention should be our guide here since they seem to want 0 – 2 to be content of something

Pipe is a valid character to be part of a table row attribute. What if you wanted to do

{|
|- data-something="test|123"
| hi
|}

I think it's at least worth looking at the grammar to see if it's an easy fix

Fair enough.

SLopes-WMF moved this task from Needs Triage to Bugs & Crashers on the Parsoid board.Oct 2 2025, 2:24 PM

The example wikitext |- style=font-size:85%|0 – 2 probably wants to be

|- style=font-size:85%
|0 – 2

indicating a small score line. I think

Pipe is a valid character to be part of a table row attribute.

Would definitely be the edge case view and that at least people should be required to mark up intentional | to be inside quotation marks or template syntax when on the same line as a |-, with the option to emit a lint elsewise. IDK how much work that is. (Exemplary search that returns some 5.5k pages and a timeout where I caught the template and other double/triple-curly-bracket context as a second reason.)

In T406187#11237743, @Izno wrote:

(Exemplary search that returns some 5.5k pages and a timeout where I caught the template and other double/triple-curly-bracket context as a second reason.)

I was curious to see how this was being used and found a page I found a non-template "|" use. That itself turned out to be not interesting, but I found a totally unrelated bug on that page! :-) https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/1193288 ..

OSleger-WMF claimed this task.Nov 25 2025, 4:24 PM

OSleger-WMF added a project: Content-Transform-Team (Work In Progress).Feb 2 2026, 3:26 PM

OSleger-WMF moved this task from Backlog to In Progress on the Content-Transform-Team (Work In Progress) board.

MSantos added a project: OKR-Work.Feb 9 2026, 4:01 PM

Change #1238378 had a related patch set uploaded (by OSleger; author: OSleger):

[mediawiki/services/parsoid@master] Grammar: Allow pipe in table attribute value

https://gerrit.wikimedia.org/r/1238378

gerritbot added a project: Patch-For-Review.Feb 10 2026, 3:36 PM

Change #1239697 had a related patch set uploaded (by OSleger; author: OSleger):

[mediawiki/services/parsoid@master] Grammar: Allow pipe in table attribute value

https://gerrit.wikimedia.org/r/1239697

Change #1238378 abandoned by OSleger: