Page MenuHomePhabricator

Show visible error messages for unknown status
Closed, ResolvedPublic

Description

Entities are put into Category:Pages with Community Wishlist errors in a few cases. Sometimes a class=error message is shown in the output, but for others there's no visible indication of what the error actually is. For these, an error message should be shown when there's an unknown status (when the status chip shows the default 'Under review').

Derived Requirement

Ensure that when an entity is assigned an unknown status (resulting in the default “Under review” status chip), a visible error message with class=error is displayed on the page to clearly indicate that an error has occurred, matching the behavior of other known error cases in *Category:Pages with Community Wishlist errors*.

Test Steps

Test Case 1: Verify error visibility for unknown status entities

  1. Identify or create a test entity that triggers an unknown status (default “Under review” chip).
  2. Navigate to the entity’s page in the Community Wishlist.
  3. Observe the rendered output on the page.
  4. ✅❓❌⬜ AC1: Confirm that a visible error message styled with class=error appears on the page.
  5. ✅❓❌⬜ AC2: Confirm that the error message is displayed, consistent with other error cases.

Test Case 2: Verify absence of error message for valid statuses

  1. Navigate to entities with valid statuses (e.g., “in-progress,” “Completed”).
  2. Observe their page output.
  3. ✅❓❌⬜ AC3: Confirm that no class=error message is shown for entities with valid statuses.

Test Case 3: Verify categorization consistency

  1. Open Category:Pages with Community Wishlist errors.
  2. Locate entities that previously had unknown statuses.
  3. Change it back to a valid status (e.g., "in-progress)
  4. ✅❓❌⬜ AC4: Confirm that pages with unknown statuses changes back to a valid status that you entered
  5. ✅❓❌⬜ AC5: Confirm that these categorized pages now does not display the associated error message on the entity’s page.

QA Results - Meta Beta

ACStatusDetails
1Pass per T406188#11347917
2Pass per T406188#11347917
3T406188#11313101
4T406188#11313101
5T406188#11313101

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Actually, it seems that for unknown statuses we save the default value to the database, the default is what gets shown in the index pages. So I'm not sure it makes sense to show 'unknown' on the entity pages.

Should we just show the default for unknown statuses? Either that, or don't save the default to the DB and also show 'unknown' on the index pages.

Change #1193313 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/CommunityRequests@master] Show default status in FA index and entities' indicators

https://gerrit.wikimedia.org/r/1193313

I think that as cr_status is a NOT NULL field, it's simpler to honour its value and display the default everywhere there's an invalid status. Invalid statuses only come about by editing the wikitext of the pages (or when migrating Wishlists), so it's pretty rare.

Change #1193313 merged by jenkins-bot:

[mediawiki/extensions/CommunityRequests@master] Show default status in FA index and entities' indicators

https://gerrit.wikimedia.org/r/1193313

Change #1195101 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/CommunityRequests@master] Add error message for invalid statuses

https://gerrit.wikimedia.org/r/1195101

MusikAnimal changed the task status from Open to In Progress.Oct 14 2025, 5:55 AM

In T402027 I'm removing the 'unknown' status. (No that that changes this task.)

HMonroy changed the task status from In Progress to Open.Oct 22 2025, 3:58 AM
HMonroy moved this task from Feedback and Review to QA on the Community-Tech (Sea Lion Squad) board.
Samwilson changed the task status from Open to In Progress.Oct 22 2025, 4:05 AM
Samwilson moved this task from QA to In Development on the Community-Tech (Sea Lion Squad) board.

One last bit to update here: update the wish-type error message to use the new getErrorMessage() method.

Change #1195101 merged by jenkins-bot:

[mediawiki/extensions/CommunityRequests@master] Add error message for invalid statuses

https://gerrit.wikimedia.org/r/1195101

Change #1197744 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/CommunityRequests@master] Use new AbstractRenderer::getErrorMessage() for unknown wish type

https://gerrit.wikimedia.org/r/1197744

Change #1198047 had a related patch set uploaded (by Adarsh2406; author: Samwilson):

[mediawiki/extensions/CommunityRequests@master] Add error message for invalid statuses

https://gerrit.wikimedia.org/r/1198047

Change #1197744 abandoned by Samwilson:

[mediawiki/extensions/CommunityRequests@master] Use new AbstractRenderer::getErrorMessage() for unknown wish type

https://gerrit.wikimedia.org/r/1197744

Samwilson renamed this task from Show visible error messages for unknown status and if there are missing fields to Show visible error messages for unknown status.Oct 24 2025, 2:15 AM
Samwilson changed the task status from In Progress to Open.
Samwilson updated the task description. (Show Details)

Change #1198047 abandoned by Adarsh2406:

[mediawiki/extensions/CommunityRequests@master] Add error message for invalid statuses

https://gerrit.wikimedia.org/r/1198047

Change #1198047 restored by Adarsh2406:

[mediawiki/extensions/CommunityRequests@master] Add error message for invalid statuses

https://gerrit.wikimedia.org/r/1198047

@Samwilson When you have a chance, can you please review AC1, AC2 and Possible Issue? Thanks!

Test Result - Meta Beta

Status: ✅ PASS / ❓Need More Info / ❌ FAIL
Environment: Meta Beta
OS: macOS Tahoe 26.0.1
Browser: Chrome 141
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Verify error visibility for unknown status entities

  1. Identify or create a test entity that triggers an unknown status (default “Under review” chip).
  2. Navigate to the entity’s page in the Community Wishlist.
  3. Observe the rendered output on the page.
  4. ✅❓ AC1: Confirm that a visible error message styled with class=error appears on the page.

Just wanted to see if you wanted the blank status to look like that

✅ Status- Invalid❓Status-
  1. AC2: Confirm that the error message is displayed in red, consistent with other error cases.

Error message is not in red
See AC1

Test Case 2: Verify absence of error message for valid statuses

  1. Navigate to entities with valid statuses (e.g., “in-progress,” “Completed”).
  2. Observe their page output.
  3. AC3: Confirm that no class=error message is shown for entities with valid statuses.

Test Case 3: Verify categorization consistency

  1. Open Category:Pages with Community Wishlist errors.
  2. Locate entities that previously had unknown statuses.
  3. Change it back to a valid status (e.g., "in-progress)
  4. AC4: Confirm that pages with unknown statuses changes back to a valid status that you entered

  1. AC5: Confirm that these categorized pages now does not display the associated error message on the entity’s page.

See AC4

❓Possible Issue

Will mobile show the status?

DesktopMobile
2025-10-27_10-42-18.png (1×1 px, 215 KB)
2025-10-27_10-42-03.png (1×949 px, 126 KB)
GMikesell-WMF changed the task status from Open to In Progress.Oct 27 2025, 5:45 PM
GMikesell-WMF updated the task description. (Show Details)
GMikesell-WMF updated the task description. (Show Details)
GMikesell-WMF moved this task from QA to In Development on the Community-Tech (Sea Lion Squad) board.

Change #1198047 abandoned by Adarsh2406:

[mediawiki/extensions/CommunityRequests@master] Add error message for invalid statuses

https://gerrit.wikimedia.org/r/1198047

(Sorry for my slow response here!)

Just wanted to see if you wanted the blank status to look like that

Yep, that's fine, as it's indicating that the status is blank.

Error message is not in red

I don't think this matters too much, as it's in a prominent place and is unlikely to happen very often.

Will mobile show the status?

No, that part of the skin is not shown on mobile. This is an existing bug: T75299: Indicators (protected icon, featured icon, coordinates) are not shown in Minerva

@Samwilson Ok sounds good! You may want to update the description regarding "message is shown in red in the output", since that's where I got it from. If those are fine and the other bug is part of another, I will mark this task as Resolved. Thanks for all your work!

GMikesell-WMF updated Other Assignee, removed: GMikesell-WMF.
GMikesell-WMF updated the task description. (Show Details)

Oops, good point, sorry about that! Fixed (belatedly).