Description
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Fix Pashto special page aliases | mediawiki/core | master | +8 -8 | |
| Localize messages for Pashto | mediawiki/core | master | +379 -77 |
Related Objects
Event Timeline
Please submit that file as a patch to Gerrit rather than just uploading it on Phabricator.
@ShahZamanPathan: Hi, please use a Developer Account to submit the proposed code changes as a Git branch directly into Gerrit which makes it easier to review and provide feedback. If you don't want to set up Git/Gerrit, you can also use the Gerrit Patch Uploader. Thanks again!
I don't have any information about this, is it possible that someone else can do this from here?
@ShahZamanPathan Hi, I'm not sure why you added a link to GitHub? We use Gerrit (not Github) for code review; see the previous comments.
Change #1193569 had a related patch set uploaded (by Pppery; author: Gerrit Patch Uploader):
[mediawiki/core@master] Localize messages for Pashto
Well, okay, I decided to do what shouldn't have been my responsibility and put the patch on Gerrit, and it turned out it had multiple PHP syntax errors. Sigh.
@ShahZamanPathan go to https://gerrit.wikimedia.org/ -- it's pretty self-explanatory once you're there. But here are some links:
- https://www.mediawiki.org/wiki/Gerrit explains it.
- https://www.mediawiki.org/wiki/Gerrit/Tutorial is a tutorial.
- You can upload patches via https://gerrit-patch-uploader.toolforge.org/
@ShahZamanPathan: Likely an outdated browser version and/or an unsupported operating system getting blocked due to being close to some AI/LLM scraper patterns. Those are questions for https://meta.wikimedia.org/wiki/Tech though.
Not planning on doing further work on this. I've already spent way more time than I should wrangling what should be others' responsibilities.
@Pppery Appreciate the efforts you have already put into this task. I will look into the next steps.
@ShahZamanPathan There is one last thing to check on the patch. Could you take a look at my recent comment on it in Gerrit? Thank you!
Change #1193569 merged by jenkins-bot:
[mediawiki/core@master] Localize messages for Pashto
@srishakatux Although the project has been merged, but it still has two minor errors, if possible that should be corrected.
@Bugreporter2
'FileDuplicateSearch' => [ 'غبرگونې_دوتنې_لېږل', 'دوه_گونې_دوتنې_پلټل' ],
It should be...
'FileDuplicateSearch' => [ 'غبرگونې_دوتنې_پلټل', 'دوه_گونې_دوتنې_پلټل' ],
'LinkAccounts' => [ 'اړوند_گڼونه' ],
It should be...
'LinkAccounts' => [ 'اړوند_گڼونونه' ],
'Allmessages' => [ 'ټول-پيغامونه' ],
It should be...
'Allmessages' => [ 'ټول_پيغامونه' ],
Change #1260152 had a related patch set uploaded (by Srishakatux; author: Srishakatux):
[mediawiki/core@master] Fix Pashto special page aliases
@ShahZamanPathan Thanks for checking for the errors. I've uploaded a patch. I will let someone review it.
I think there are many more that have spelling errors, I will check them all, then share them with you here.
In $specialPageAliases
The following pages do not automatically link to theiroriginal page, but will take you back to the original page after clicking a second time:
'Invalidateemail' => [ 'برېښليک_تاييد_نه_منل', 'برېښليک_تاييد_ردول' ],
'ComparePages' => [ 'مخونو_پرتلنه', 'مخونه_پرتلل' ], here just 'مخونه_پرتلل' has this problem 'مخونو_پرتلنه' is working well
'Revisiondelete' => [ 'بياليدنه_ړنگول' ],
There is no pages for:
'GoToInterwiki' => [ 'ويکي_خپلمنځيته_ورتلل', 'ويکيخپلمنځيورتگ' ], also has spelling mistake in 'ويکي_خپلمنځيته_ورتلل', it should be 'ويکي_خپلمنځي_ته_ورتلل'
'JavaScriptTest' => [ 'جاواسکريپټ_ازمويل' ],
'PageLanguage' => [ 'مخ_ژبه' ],
'UnlinkAccounts' => [ 'گڼونونه_بېلول' ],
There is a spelling mistakes in these specialPageAliases:
'Log' => [ 'يادښتونه،_يادښت' ], it should be 'Log' => [ 'يادښتونه', 'يادښت' ],
'Uncategorizedimages' => [ 'ناوېشلي_انځورونه،_ناوېشلې_دوتنې' ], it should be 'Uncategorizedimages' => [ 'ناوېشلي_انځورونه', 'ناوېشلې_دوتنې' ],
There is a bad request in these specialPageAliases:
'RunJobs' => [ 'دندې_پرمخ_وړل' ],
In $specialPageAliases
Addressed the spelling fixes. I think the rest are more MediaWiki behavior/configuration related changes and are unrelated to the localization changes in this patch. For the pages that can't be linked right now, it is likely because their corresponding extensions or special pages aren't enabled. That said, the translations can stay in this patch for when they do get enabled in the future.
@ShahZamanPathan That would be a separate patch as the changes will go into the ParserFunctions MediaWiki extension.
@srishakatux i suggested the following words for correction in patch 4, but not resolved, is it need to suggest it again in patch 5 or not?
#in $namespaceAliases
'ځﺎﻧګړی' => NS_SPECIAL, It should be 'ځانگړی' => NS_SPECIAL,
'د_کارونکي_خبرې_اترې' => NS_USER_TALK, It should be 'د_کارن_خبرې_اترې'
'انځور' => NS_FILE, It should be 'دوتنه' => NS_FILE,
'د_انځور_خبرې_اترې' => NS_FILE_TALK, It should be 'د_دوتنې_خبرې_اترې' => NS_FILE_TALK,
'ميډياويکي' => NS_MEDIAWIKI, It should be 'ميډياويکي' => NS_MEDIAWIKI,
'د_ميډياويکي_خبرې_اترې' => NS_MEDIAWIKI_TALK, It should be NS_MEDIAWIKI_TALK => 'د_مېډياويکي_خبرې_اترې',
@ShahZamanPathan I left a comment about this in the patch here https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1260152. See my recent comment. What do you think?
Change #1260152 merged by jenkins-bot:
[mediawiki/core@master] Fix Pashto special page aliases
@srishakatux the Fix Pashto special page aliases has been merged, but it still not working, is it need more time?
Deploying is a separate step after merging. See more at https://wikitech.wikimedia.org/wiki/Deployments/Train.
Because there is no regular deployment train this week, it is expected that these changes will be deployed by Friday next week.