Page MenuHomePhabricator

Pinned sticky containers "jump" when the sticky header appears
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:
Before the sticky header appears, the pinnable menus are placed at the very top of the page. But once it appears (with a CSS transition), the pinnable menus "jump" down to give space to the header.

What should have happened instead?:
Since the sticky header appears with a smooth transition, the transition for the pinnable menus should similarly be smooth.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

Event Timeline

Change #1193134 had a related patch set uploaded (by Jon Harald Søby; author: Jon Harald Søby):

[mediawiki/skins/Vector@master] Add transition to sticky pinned containers

https://gerrit.wikimedia.org/r/1193134

Change #1193134 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Add transition to sticky pinned containers

https://gerrit.wikimedia.org/r/1193134

I am not sure what I am seeing is fixed or not. I still see the menu's flash (and not transition) but the refresh happens too fast to know what is actually happening.

@Sneha This is what it looks like in my localhost wiki when I scroll down on a long page, and then refresh. Using the current master branch of the Vector skin repo.

Thanks for sharing the video @jhsoby it looks great! I was checking in the wrong place. I thought it was on beta already.

Actually I see it on beta cluster too and see the improvement compared to how it is in production.

HFan-WMF claimed this task.
HFan-WMF subscribed.

Looks fantastic on Beta. Thanks so much for fixing this, Jon!!

Great! Thanks for reviewing and checking. :-)