Page MenuHomePhabricator
Create Task
Maniphest T406277

handle `undefined|null` properties
Closed, ResolvedPublic
Actions

Description

Error logs error TypeError: Cannot read properties of undefined or null show that these should be better handled. We can safe-guard these and also validate inputs early.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
wikifunctions: Upgrade orchestrator from 2025-10-06-225918 to 2025-10-14-194525operations/deployment-chartsmaster+1 -1
Customize query in gerrit

Event Timeline

ecarg created this task.Oct 2 2025, 10:27 PM
ecarg changed the task status from Open to In Progress.
ecarg triaged this task as Medium priority.
CodeReviewBot added a project: Patch-For-Review.Oct 2 2025, 11:28 PM

ecarg opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/463

Draft: handle undefined|null reference string

ecarg added a comment.EditedOct 3 2025, 7:35 PM

Notes:

  • this is happening with Z9K1 as well as Z6K1 ex
CodeReviewBot added a comment.Oct 8 2025, 12:34 PM

apine merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/463

handle undefined|null reference string

Maintenance_bot removed a project: Patch-For-Review.Oct 8 2025, 1:31 PM
Jdforrester-WMF edited projects, added Abstract Wikipedia team (26Q2 (Oct–Dec)); removed Abstract Wikipedia team.Oct 8 2025, 5:33 PM
Jdforrester-WMF moved this task from Incoming to Ready to deploy on the Abstract Wikipedia team (26Q2 (Oct–Dec)) board.
gerritbot added a comment.Oct 15 2025, 1:29 PM

Change #1196439 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2025-10-06-225918 to 2025-10-14-194525

https://gerrit.wikimedia.org/r/1196439

gerritbot added a project: Patch-For-Review.Oct 15 2025, 1:29 PM
gerritbot added a comment.Oct 15 2025, 2:02 PM

Change #1196439 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2025-10-06-225918 to 2025-10-14-194525

https://gerrit.wikimedia.org/r/1196439

Jdforrester-WMF moved this task from Ready to deploy to Needs Sign-off on the Abstract Wikipedia team (26Q2 (Oct–Dec)) board.Oct 15 2025, 2:06 PM
Jdforrester-WMF subscribed.

This is now deployed; please confirm if it's resolved.

Maintenance_bot removed a project: Patch-For-Review.Oct 15 2025, 2:31 PM
Jdforrester-WMF added a project: Essential-Work.Oct 16 2025, 2:10 PM
ecarg closed this task as Resolved.EditedNov 18 2025, 5:44 AM

Marking as resolved. This was a temporary bandaid but other occurrences in the code rendered similar error logs down the road. Additionally, was encouraged not to use optional chaining recently so those have since been removed.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits