Page MenuHomePhabricator
Create Task
Maniphest T406279

Unknown wish types show as broken i18n message and does not put page in error category
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To
• dmaza
Authored By
MusikAnimal
Oct 2 2025, 10:37 PM
Project Tags
Referenced Files
F69823302: 2025-11-03_12-05-46.webm
Nov 3 2025, 11:02 PM
F69822925: 2025-11-03_12-03-12.png
Nov 3 2025, 11:02 PM
F66752669: 2025-10-15_09-02-34.mp4
Oct 15 2025, 4:08 PM
F66752661: 2025-10-15_08-59-26.png
Oct 15 2025, 4:08 PM
F66752655: 2025-10-15_08-55-22.mp4
Oct 15 2025, 4:08 PM
F66752643: 2025-10-15_08-47-48.png
Oct 15 2025, 4:08 PM
Subscribers
Aklapper
GMikesell-WMF
MusikAnimal

Description

Steps to replicate the issue (include links if applicable):

  • Manually edit a wish and remove any value that was present for the "type" field
  • Save

What happens?:

You see "Type of wish: ⧼-label⧽"

What should have happened instead?:

  • It should show an error if you are on preview mode
  • If the wish is saved, it should default to unknown and put the wish in Category:Pages with Community Wishlist errors

Derived Requirement

Ensure that when a Wish page has an invalid or missing type field:

  • During preview mode, an error message is displayed indicating that the type field is missing or invalid.
  • When the page is saved, the wish automatically defaults its type to “unknown” and the page is placed under the Category:Pages with Community Wishlist errors for tracking. Additionally, the interface should never display broken i18n messages such as “⧼-label⧽” in place of the wish type.
Test Steps

Test Case 1: Verify preview behavior for missing wish type

  1. Open an existing Wish page in edit mode.
  2. Remove the value for the “type” field.
  3. Click Show preview.
  4. ✅❓❌⬜ AC1: Confirm that an error message is displayed indicating that the type field is missing or invalid.

Test Case 2: Verify that invalid i18n label is not shown

  1. In preview mode, inspect the “Type of wish” field.
  2. ✅❓❌⬜ AC2: Confirm that “⧼-label⧽” or other broken i18n placeholders do not appear on the page.

Test Case 3: Verify save behavior for missing wish type

  1. Save the page after removing the “type” field value.
  2. ✅❓❌⬜ AC3: Confirm that the wish is automatically assigned a default type = “unknown” after saving.

Test Case 4: Verify category assignment for error tracking

  1. After saving the wish with no type, scroll to the bottom of the page.
  2. ✅❓❌⬜ AC4: Confirm that the page is categorized under Category:Pages with Community Wishlist errors.

Test Case 5: Verify behavior for restoring a valid type

  1. Edit the same wish again and reassign a valid “type” (e.g., “Technical”).
  2. Save the page.
  3. ✅❓❌⬜ AC5: Confirm that the valid type is displayed correctly and the page is no longer listed under the error category.

QA Results - Meta Beta

ACStatusDetails
1✅T406279#11338099
2✅T406279#11338099
3✅T406279#11338099
4✅T406279#11338099
5✅T406279#11338099

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Use new AbstractRenderer::getErrorMessage() for unknown wish typeSamwilsonmediawiki/extensions/CommunityRequestsmaster+13 -28
Fix broken i18n display for invalid wish typesDmazamediawiki/extensions/CommunityRequestsmaster+68 -7
Customize query in gerrit

Related Objects

Event Timeline

MusikAnimal created this task.Oct 2 2025, 10:37 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 2 2025, 10:37 PM
MusikAnimal added a project: MediaWiki-extensions-CommunityRequests.Oct 2 2025, 10:37 PM
MusikAnimal renamed this task from Unknown wish types show as broken i18n message and does not page in error category to Unknown wish types show as broken i18n message and does not put page in error category.Oct 4 2025, 3:09 AM
MusikAnimal moved this task from Backlog to Entities on the MediaWiki-extensions-CommunityRequests board.Oct 5 2025, 12:16 AM
• KSiebert moved this task from Entities to v2 on the MediaWiki-extensions-CommunityRequests board.Oct 7 2025, 7:16 PM
• dmaza changed the task status from Open to In Progress.Oct 9 2025, 3:53 PM
• dmaza claimed this task.
• dmaza moved this task from Ready (prioritized + estimated) to In Development on the Community-Tech (Sea Lion Squad) board.
gerritbot added a comment.Oct 10 2025, 12:48 PM

Change #1195207 had a related patch set uploaded (by Dmaza; author: Dmaza):

[mediawiki/extensions/CommunityRequests@master] Show error when wish type is invalid

https://gerrit.wikimedia.org/r/1195207

gerritbot added a project: Patch-For-Review.Oct 10 2025, 12:48 PM
• dmaza moved this task from In Development to Feedback and Review on the Community-Tech (Sea Lion Squad) board.Oct 10 2025, 12:55 PM
MusikAnimal updated the task description. (Show Details)Oct 12 2025, 3:24 AM
MusikAnimal triaged this task as Medium priority.Oct 14 2025, 4:13 PM
MusikAnimal moved this task from v2 to Entities on the MediaWiki-extensions-CommunityRequests board.
gerritbot added a comment.Oct 15 2025, 6:26 AM

Change #1195207 merged by jenkins-bot:

[mediawiki/extensions/CommunityRequests@master] Fix broken i18n display for invalid wish types

https://gerrit.wikimedia.org/r/1195207

jenkins-bot mentioned this in rECOR88a42cc1632b: Fix broken i18n display for invalid wish types.Oct 15 2025, 6:27 AM
Maintenance_bot removed a project: Patch-For-Review.Oct 15 2025, 6:30 AM
ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.24; 2025-10-21).Oct 15 2025, 8:00 AM
• dmaza updated the task description. (Show Details)Oct 15 2025, 2:26 PM
• dmaza moved this task from Feedback and Review to QA on the Community-Tech (Sea Lion Squad) board.
GMikesell-WMF subscribed.Oct 15 2025, 4:08 PM

@dmaza Please review AC1, AC3, AC4 & AC5 below.

Test Result - Meta Beta

Status: ✅ PASS / ❓Need More Info / ❌ FAIL
Environment: Meta Beta
OS: macOS Tahoe 26.0
Browser: Chrome 141
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Verify preview behavior for missing wish type

  1. Open an existing Wish page in edit mode.
  2. Remove the value for the “type” field.
  3. Click Show preview.
  4. ❓ AC1: Confirm that an error message is displayed indicating that the type field is missing or invalid.

Are the double quotes supposed to show at the beginning of "is not a valid wish type" when you delete the value in type?

2025-10-15_08-47-48.png (1,157×1,103 px, 257 KB)

Test Case 2: Verify that invalid i18n label is not shown

  1. In preview mode, inspect the “Type of wish” field.
  2. ✅ AC2: Confirm that “⧼-label⧽” or other broken i18n placeholders do not appear on the page.

See AC1

Test Case 3: Verify save behavior for missing wish type

  1. Save the page after removing the “type” field value.
  2. ❓ AC3: Confirm that the wish is automatically assigned a default type = “unknown” after saving.

Is this the default you want when the value is deleted in type. "I'm not sure or I don't know" or "unknown"?

Test Case 4: Verify category assignment for error tracking

  1. After saving the wish with no type, scroll to the bottom of the page.
  2. ❌ AC4: Confirm that the page is categorized under Category:Pages with Community Wishlist errors.

Not showing up at the bottom

2025-10-15_08-59-26.png (922×1,113 px, 163 KB)

Test Case 5: Verify behavior for restoring a valid type

  1. Edit the same wish again and reassign a valid “type” (e.g., “feature”).
  2. Save the page.
  3. ❌ AC5: Confirm that the valid type is displayed correctly and the page is no longer listed under the error category.

Type is updated but the error category like AC4, does not show and can't fully QA that it disappears

GMikesell-WMF updated the task description. (Show Details)Oct 15 2025, 4:09 PM
GMikesell-WMF updated Other Assignee, added: GMikesell-WMF.
GMikesell-WMF moved this task from QA to In Development on the Community-Tech (Sea Lion Squad) board.
gerritbot added a comment.Oct 22 2025, 5:31 AM

Change #1197744 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/CommunityRequests@master] Use new AbstractRenderer::getErrorMessage() for unknown wish type

https://gerrit.wikimedia.org/r/1197744

gerritbot added a project: Patch-For-Review.Oct 22 2025, 5:31 AM
gerritbot added a comment.Oct 24 2025, 2:12 AM

Change #1197744 abandoned by Samwilson:

[mediawiki/extensions/CommunityRequests@master] Use new AbstractRenderer::getErrorMessage() for unknown wish type

https://gerrit.wikimedia.org/r/1197744

Maintenance_bot removed a project: Patch-For-Review.Oct 24 2025, 2:30 AM
• dmaza added a comment.Nov 3 2025, 3:59 PM

❓ AC1: Confirm that an error message is displayed indicating that the type field is missing or invalid.

Double quotes are indicating empty. I think it's fine considering that this is only on preview mode

❓ AC3: Confirm that the wish is automatically assigned a default type = “unknown” after saving.

That's fine. The english translation is "I'm not sure or I don't know" which is what you are getting

❌ AC4: Confirm that the page is categorized under Category:Pages with Community Wishlist errors.

Interesting. I have no idea why the category doesn't show. See https://meta.wikimedia.beta.wmcloud.org/wiki/Category:Pages_with_Community_Wishlist_errors. You can see W14 listed there.

• dmaza added a comment.Nov 3 2025, 4:39 PM

@GMikesell-WMF TIL The category is not showing because there is a preference to show/hide hidden categories. Preferences > Appearance > Advance Options > Show hidden categories.

• dmaza changed the task status from In Progress to Open.Nov 3 2025, 4:39 PM
• dmaza moved this task from In Development to QA on the Community-Tech (Sea Lion Squad) board.
GMikesell-WMF added a comment.Nov 3 2025, 11:02 PM

@dmaza Confirmed unknown wish types show as broken i18n message and does not put page in error category as seen in videos and screenshots below. I will mark this as Resolved. Thanks for all your work!

Test Result - Meta Beta

Status: ✅ PASS
Environment: Meta Beta
OS: macOS Tahoe 26.0
Browser: Chrome 142
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Verify preview behavior for missing wish type

  1. Open an existing Wish page in edit mode.
  2. Remove the value for the “type” field.
  3. Click Show preview.
  4. ✅ AC1: Confirm that an error message is displayed indicating that the type field is missing or invalid.

Are the double quotes supposed to show at the beginning of "is not a valid wish type" when you delete the value in type?
UPDATE: Pass per T406279#11336216

2025-10-15_08-47-48.png (1,157×1,103 px, 257 KB)

Test Case 2: Verify that invalid i18n label is not shown

  1. In preview mode, inspect the “Type of wish” field.
  2. ✅ AC2: Confirm that “⧼-label⧽” or other broken i18n placeholders do not appear on the page.

See AC1

Test Case 3: Verify save behavior for missing wish type

  1. Save the page after removing the “type” field value.
  2. ✅ AC3: Confirm that the wish is automatically assigned a default type = “unknown” after saving.

Is this the default you want when the value is deleted in type. "I'm not sure or I don't know" or "unknown"?
UPDATE: Pass per T406279#11336216

Test Case 4: Verify category assignment for error tracking

  1. After saving the wish with no type, scroll to the bottom of the page.
  2. ✅AC4: Confirm that the page is categorized under Category:Pages with Community Wishlist errors.

UPDATE: Thanks for the info: Preferences > Appearance > Advance Options > Show hidden categories.

2025-11-03_12-03-12.png (1,183×1,100 px, 231 KB)

Test Case 5: Verify behavior for restoring a valid type

  1. Edit the same wish again and reassign a valid “type” (e.g., “feature”).
  2. Save the page.
  3. ✅ AC5: Confirm that the valid type is displayed correctly and the page is no longer listed under the error category.

GMikesell-WMF closed this task as Resolved.Nov 3 2025, 11:02 PM
GMikesell-WMF updated the task description. (Show Details)
GMikesell-WMF updated Other Assignee, removed: GMikesell-WMF.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits