Page MenuHomePhabricator

Article Feedback - Feedback from my watched pages
Closed, ResolvedPublic

Description

Provide a filtered version of the central feedback page, which will only show feedback from my watchlist.

The page's title will say:

'Feedback for my watchlist'
(instead of 'Central Feedback Page')

... and the subtitle below will say:

'For <user name>. Please promote good feedback and help improve this article. <Learn more »>'

The URL could include the user name, as so:

http://en.wikipedia.org/wiki/Special:ArticleFeedbackv5/watchlist/Fabrice_Florin

All of the other features of the central feedback page would also be supported by this page.

Note that this feature would only be available for logged in users that have items selected in their watchlist.

That special page would be accessed through a prominent link on the watchlist page, in a location to be specified on a separate ticket, in consultation with Pau Giner.

It may also be possible to make this feature accessible as a filter or link on the central feedback page, subject to upcoming recommendations from Pau Giner.


Version: unspecified
Severity: major
URL: http://www.mediawiki.org/wiki/Article_feedback/Version_5/Feature_Requirements#Feedback_from_my_watchlist

Details

Reference
bz38628

Event Timeline

bzimport raised the priority of this task from to Unbreak Now!.Nov 22 2014, 12:57 AM
bzimport added a project: ArticleFeedbackv5.
bzimport set Reference to bz38628.

The URL could include the user name, as so:

http://en.wikipedia.org/wiki/Special:ArticleFeedbackv5/watchlist/Fabrice_Florin

This would enable me to see feedback on your watchlist - is it ok for us to expose someone's watchlist publicly?

If not, we could drop the username from the url (since you can only see your own, it's a bit pointless to add the username to the url)
Then we're only left with: http://en.wikipedia.org/wiki/Special:ArticleFeedbackv5/watchlist -> but this should, given the current url scheme, yield feedback on the article named "watchlist", so we're having somewhat of a uri clash
Anyway, that's quite an unimportant discussion right now.

More of a problem turns out to be the filter totals.
Fetching the feedback list = no problem
More of a problem is the filter totals however. To keep things scalable, they're being calculated as soon as feedback is given or an action is performed on feedback, for all possible filters and than that total is read upon display (rather than calculating all totals for all filters on display)
The above can not properly be implemented with the watchlist: either we would have to calculate the totals upon display (way too intensive; doesn't scale) or we would have to subscribe to the watchlist-hooks to only calculate these totals upon subscription and from then on use the same principle like the current filters (though less intensive, this doesn't scale either: the larger the pool of feedback/items on watchlist grows, the more problematic this calculation)
Conclusion: there's no way to implement this that scales well, unless:

  • we can drop the totals per filter, for watchlists
  • we don't need accurate totals over the entire list of feedback on your articles, just the feedback given since you subscribed
  • we wait and revise this when we can properly shard the data

The requirements for this feature have been updated on MediaWiki, based on team discussions:
http://www.mediawiki.org/wiki/Article_feedback/Version_5/Feature_Requirements#Feedback_from_my_watchlist

Here is the current specification for these two components:

  • a watchlist version of the central feedback page
  • links to that watchlist version from both the watchlist and central feedback page.

Note that this Bugzilla ticket will supersede the feature requirements on MediaWiki, so whatever we write below is the fina spec.

For example, we want to add the word 'pages', followed by the user name in parenthesis after the sub-title of that watchlist version of the Central feedback page, as so:

'Feedback from my watchlist pages (for <user name>)'


Feedback from my watchlist pages

The goal of this feature is to enable logged-in users to monitor feedback for articles on their watchlist.

A Watchlist feedback page will be accessible form the central feedback page and the user watchlist.

I. Watchlist feedback page
A special 'watchlist' version of the central feedback page will be provided to logged-in users. This filtered page will only show feedback from articles in your watchlist, and will include the same tools as other feedback pages (filtering, sorting, moderating).

This 'watchlist' page will include these elements:

  • Headline (large text): 'Feedback from my watchlist pages'.
  • Link: 'View feedback from all pages' (small text, links to central feedback page)

See preliminary mockup of an earlier version:
http://upload.wikimedia.org/wikipedia/commons/2/2b/Feedback-on-watchlisted-option1.png

We want to add the word 'pages', followed by the user name in parenthesis after the sub-title of that watchlist version of the Central feedback page, as so:

'Feedback from my watchlist pages (for <user name>)'

This link toggles back and forth between 'View feedback from my watchlist pages' and 'View feedback from all pages' -- with the opposite label used for the large headline above it.

The Central feedback page will now include a new text link right below its headline, as so:

  • Headline: '151453 feedback posts from all pages'
  • Link: 'View feedback from my watchlist pages'

'View feedback from pages on my watchlist'

II. Links to Watchlist feedback
This page can be accessed in different ways:

  1. On the watchlist page

Click on this text link in the 'Watchlist options' box
'View feedback from these pages >'

This link will be placed next to the summary of all results ("55 pages on your watchlist"). Here's an example of what this line would say:
'You have 55 pages on your watchlist (excluding talk pages). View feedback from these pages >'

A tooltip over the text link will say: 'View reader feedback from pages on my watchlist.'

Since users are used to checking the 'Watchlist options' box, it seems like a reasonable place for this link in the current watchlist page design.

See a preliminary mockup:
http://commons.wikimedia.org/wiki/File:Watchlist-feedback-integration.png

  1. On the central feedback page

As described above, the central feedback page will now include a link showing the watchlist feedback list ('View feedback from my watchlist pages'). See preliminary mockups with alternative wordings:

  1. With a direct URL

Any logged-in user can view their own watchlist feedback list at this URL: http://en.wikipedia.org/wiki/Special:ArticleFeedbackv5/watchlist

Note: This watchlist links above would only be shown if there is feedback on pages from your watchlist (assuming this request is relatively easy to implement).

Created attachment 10910
My watchlist page with link to feedback page below the title

Hi guys,

Howie and I reviewed all the final feature designs together today, and would like to recommend a few last tweaks to the watchlist pages, as outlined below and shown in the attached mockups. We weighed all the arguments in favor of different visual and wording options and settled on these recommendations after careful deliberation.

Matthias, in the interest of time, please follow these mockups in your first implementation of the feature.

We can always make final copy tweaks later, if we agree they are needed. But this will get the ball rolling.

Thanks,

Fabrice


WATCHLIST FEEDBACK TWEAKS

My watchlist link
Howie made a good point that the link to the feedback page does not logically belong in the Watchlist options box, which is really about changing the look of the list below.

So we determined to put it on the line above the box and below the title, after the preceding links, as so:

[ comic icon ] Feedback from my watchlist pages >

We discussed our various labeling options and concluded that 'watchlist pages' is the best and most concise term available to us at this time for this link. We don't expect it to cause confusion, given that the next line clearly refers to '16 pages on your watchlist', clarifying any questions you might have had about this term.

Central feedback page toggle links
Howie also suggested that we consolidate the toggle links on the central feedback page on a single line, to reduce clutter and match what we are doing with the filters right below it. I agree with that recommendation, as I too was a bit unsettled by the two-line approach we were using earlier.

To accentuate the difference between the title and the toggle link on the same line, I bolded the title on the mockup, added a • bullet separator and reduced the font size on the link, as so:

164,238 feedback posts from all pages • Feedback from watchlist pages

toggles into:

Feedback from my watchlist pages • Feedback from all pages

We think this works better visually and from a UI standpoint -- and it is more consistent with the other functions on this page.

Let's try it out and see how it looks and feels. We can tweak from there, as needed.

Attached:

Created attachment 10911
Central Feedback Page showing all pages (with link to fedback from watchlist pages)

Attached:

Created attachment 10912
Central Feedback Page showing feedback from watch list pages (with link to all pages)

Attached:

This has been pushed to Gerrit (https://gerrit.wikimedia.org/r/#/c/17422/) & prototype.

2 things to note:

  • The url for the AFT watchlist-page is /Special:ArticleFeedbackv5Watchlist
  • The icon for the link on the watchlist page is still missing - can someone send it my way? (the attached mockup is a bit blurry so it made not sense fetching it from there)

Pau has sent me the icon already & that's been pushed to Gerrit & prototype now as well

Thanks, Matthias, good progress!

I just reviewed this page on prototype:
http://prototype.wikimedia.org/release-en/Special:ArticleFeedbackv5Watchlist

It works great from a functional standpoint1

However, I recommend the following copy tweaks, to avoid redundancy, streamline the interface, make it more consistent -- and include suggestions from other team members.

ON THE WATCHLIST PAGE:

My watchlist

For Fabrice Florin (Display watched changes | View and edit watchlist | Edit raw watchlist) • Feedback on my watched pages >>

[instead of 'Feedback from my watchlist pages »']

ON THE CENTRAL FEEDBACK PAGE (default view):

Central Feedback Page

Please promote good feedback and help improve this article. Learn more »

492 feedback posts from all pages • Feedback on my watched pages

[remove '(for Fabrice Florin)' after the last link above, takes too much space, not essential ]

ON THE CENTRAL FEEDBACK PAGE (watchlist view):

Feedback on my watched pages

Please promote good feedback and help improve this article. Learn more »

Feedback on pages watched by Fabrice Florin • View feedback from all pages

[remove '(for Fabrice Florin)' after the top title above, takes too much space at the top, not essential, moved to lower line ]

One more thing, please.

On article feedback pages, please remove 'Feedback from my watchlist pages (for Fabrice Florin)' from the third line, as it unnecessarily clutters the UI.

For example, this page should have no mention of watchlist feedback:
http://prototype.wikimedia.org/release-en/Special:ArticleFeedbackv5/Golden-crowned_Sparrow

It should simply say:

Feedback on Golden-crowned Sparrow View article | Talk | Help

Please promote good feedback and help improve this article. Learn more »

450 posts about this page 80% found what they were looking for

Other than that, it's a great feature, well executed. Thank you!

Updated on Gerrit & prototype

The watchlist feature looks great in prototype, but some of the copy proposed above did not make it to the current version.

It would be great if we could make these updated copy tweaks:

ON THE WATCHLIST PAGE:

  • Feedback from my WATCHED pages >> (link)

[instead of 'Feedback from my watchlist pages »']

ON THE CENTRAL FEEDBACK PAGE (default view):

  • Feedback FROM my watched pages

(better to use 'from' than 'on', for consistency)

ON THE CENTRAL FEEDBACK PAGE (watchlist view):

  • Feedback from my WATCHED pages (title)

[instead of 'Feedback from my watchlist pages']

And while we're at it, let's also tweak the third line, with a smaller font size and this edit:

  • FOR pages watched by Fabrice Florin

[instead of 'Feedback on pages watched by Fabrice Florin']

Note: words in ALL CAPS above should be lower case in the final version. (I'm only using capital letters for emphasis in this comment, because Bugzilla doesn't seem to support bold or italic.)

On a related note, thanks for adding a link on Special Pages for this feature.

http://prototype.wikimedia.org/release-en/Special:SpecialPages

Right now, that link works well, but its label is confusing:

&lt;articlefeedbackv5watchlist&gt;

What is should be saying, for consistency with other links on that page:

'Article feedback - My watched pages'

I also believe that it belongs below, rather than above, this original link, in alphabetical order:

'Article feedback - Central page'

Rather than having three Article feedback links in a row on Special Pages, which can be overwhelming,

I recommend removing the third Article feedback link altogether, as it points to AFT4 data which will soon be missing. ( http://prototype.wikimedia.org/release-en/Special:ArticleFeedback )

Lastly, I recommend that we add the word 'Moodbar' before the label now called 'Feedback dashboard'. I thought we had done this before, but maybe it slipped through the cracks.

Moodbar is correct on enwiki (http://en.wikipedia.org/wiki/Special:SpecialPages) - but that extension isn't maintained on prototype

I also removed "(New: AFT5)" from the SpecialPages link, since we're taking AFT4 out - ok?

Copy is updated. Just didn't touch the font size for "Feedback for pages watched by XYW" on the watchlist feedback page (yet), because it's in sync with the font size of "XYZ feedback posts from all pages" on the central feedback page - should this one be changed as well?

So this is fixed, except for the merge conflict in gerrit?

Indeed. Merge conflict should be fixed now.

It would be good if we could reduce the font size for "Feedback for pages watched by XYZ" on the watchlist feedback page (to the same size as 'View feedback from all pages), to de-emphasize it, so it doesn't compete with the main title. It's only meant as a confirmation, not headline.

However, I recommend keeping the font size of "XYZ feedback posts from all pages" on the central feedback page the same, because that is intended to be a major headline, that describes the whole page.