requestctl clearing all fields on error is not user-friendly when combined with stricter checking
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	MatthewVernon
	Oct 3 2025, 9:36 AM

Description

During this morning's incident ( T406299 ) we logged a note that "new stricter rules for requestctl rules are unfriendly to the user if all form fields are cleared on every error."

Event Timeline

MatthewVernon created this task.Oct 3 2025, 9:36 AM

Restricted Application removed a project: SRE. · View Herald TranscriptOct 3 2025, 9:36 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

MatthewVernon added a parent task: Restricted Task.Oct 3 2025, 9:37 AM

Aklapper removed a parent task: Restricted Task.Oct 3 2025, 11:48 AM

It's certainly the intention of the code to preserve the form data on validation error. I'll take a look at some point today.

swfrench opened https://gitlab.wikimedia.org/repos/sre/hiddenparma/-/merge_requests/116

Fix pending form field preservation on validation failure

swfrench merged https://gitlab.wikimedia.org/repos/sre/hiddenparma/-/merge_requests/116

Fix pending form field preservation on validation failure

Maintenance_bot removed a project: Patch-For-Review.Oct 3 2025, 3:30 PM

The fix for this is now live. I'll follow up separately on some testing improvements that would have caught this.

Jelto awarded a token.Oct 6 2025, 8:42 AM

requestctl clearing all fields on error is not user-friendly when combined with stricter checkingClosed, ResolvedPublicActions

Description

Event Timeline

requestctl clearing all fields on error is not user-friendly when combined with stricter checking
Closed, ResolvedPublic
Actions