Page MenuHomePhabricator
Create Task
Maniphest T406323

Make it possible to run Cite tests without VisualEditor or WikiEditor
Closed, ResolvedPublic
Actions

Description

When running QUnit tests or MediaWiki/core ResourcesTest for the Cite extension I get failures:

QUnit
Error: Unknown module: ext.visualEditor.base
1) ResourcesTest::testValidDependencies
Dependencies that do not exist
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
     'ext.cite.visualEditor' => Array (
+        0 => 'ext.visualEditor.base'
+        1 => 'ext.visualEditor.mediawiki'
+        2 => 'ext.visualEditor.mwcore'
+        3 => 'ext.visualEditor.mwtransclusion'
     )
     'ext.cite.wikiEditor' => Array (
+        0 => 'ext.wikiEditor'
     )
     'test.Cite' => Array (
+        0 => 'test.VisualEditor'
     )
 )

My aim would be, for CI, to avoid adding VisualEditor and WikiEditor when an extension depends solely on Cite.

See also T404790 T403315

This was fixed by making the resource loader module registration optional: https://gerrit.wikimedia.org/r/1198989 The build then fails further when running the Cypress integration tests:

Running:  ve-cite/reuseRefs.cy.js
1) Re-using refs in Visual Editor
      AssertionError: Timed out retrying after 20000ms: Expected to find element: `.ve-init-mw-desktopArticleTarget-toolbar-open`, but never found it.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
tests: test loading VE integration separatelymediawiki/extensions/CiteREL1_43+24 -1
tests: test loading VE integration separatelymediawiki/extensions/Citemaster+31 -0
tests: test loading VE integration separatelymediawiki/extensions/CiteREL1_45+24 -1
tests: test loading VE integration separatelymediawiki/extensions/CiteREL1_44+24 -1
Only run VisualEditor QUnit tests when it is loadedmediawiki/extensions/CiteREL1_43+27 -23
Extend addOptionalDependencies to extend any propertymediawiki/extensions/CiteREL1_43+36 -8
Only enable VisualEditor integration when it is loadedmediawiki/extensions/CiteREL1_43+130 -122
Zuul: disable recursion after Cite got fixedintegration/configmaster+3 -3
Only enable VisualEditor integration when it is loadedmediawiki/extensions/CiteREL1_44+131 -123
Only enable WikiEditor integration when it is loadedmediawiki/extensions/CiteREL1_43+55 -40
[cypress] skip tests when VisualEditor is not loadedmediawiki/extensions/CiteREL1_43+29 -0
[cypress] skip tests when VisualEditor is not loadedmediawiki/extensions/CiteREL1_44+29 -0
[cypress] skip tests when VisualEditor is not loadedmediawiki/extensions/CiteREL1_45+29 -0
Only enable VisualEditor integration when it is loadedmediawiki/extensions/CiteREL1_45+138 -131
Only enable WikiEditor integration when it is loadedmediawiki/extensions/CiteREL1_44+52 -39
Inject ExtensionRegistry as service into CiteHooksmediawiki/extensions/CiteREL1_44+15 -4
Only run VisualEditor QUnit tests when it is loadedmediawiki/extensions/CiteREL1_44+30 -23
Extend addOptionalDependencies to extend any propertymediawiki/extensions/CiteREL1_44+36 -8
[cypress] skip tests when VisualEditor is not loadedmediawiki/extensions/Citemaster+29 -0
Only enable WikiEditor integration when it is loadedmediawiki/extensions/Citemaster+56 -38
Move unrelated hook handlers out of ReferencePreviews classmediawiki/extensions/Citemaster+223 -188
Inject ExtensionRegistry as service into CiteHooksmediawiki/extensions/Citemaster+9 -6
Only enable VisualEditor integration when it is loadedmediawiki/extensions/Citemaster+139 -132
Inject ExtensionRegistry in ReferencePreviewsHooksmediawiki/extensions/Citemaster+11 -4
Extend addOptionalDependencies to extend any propertymediawiki/extensions/Citemaster+36 -8
Only run VisualEditor QUnit tests when it is loadedmediawiki/extensions/Citemaster+34 -27
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

hashar created this task.Oct 3 2025, 11:52 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 3 2025, 11:52 AM
hashar added a parent task: T389998: Allow control over which extra extensions are installed (Math REL1_43 jobs exceed 60min timeout).Oct 3 2025, 11:53 AM
gerritbot added a comment.Oct 3 2025, 12:01 PM

Change #1193400 had a related patch set uploaded (by Hashar; author: Hashar):

[mediawiki/extensions/Cite@master] Extend addOptionalDependencies to extend any property

https://gerrit.wikimedia.org/r/1193400

gerritbot added a project: Patch-For-Review.Oct 3 2025, 12:01 PM
gerritbot added a comment.Oct 3 2025, 12:10 PM

Change #1193402 had a related patch set uploaded (by Hashar; author: Hashar):

[mediawiki/extensions/Cite@master] Only run VisualEditor QUnit tests when it is loaded

https://gerrit.wikimedia.org/r/1193402

gerritbot added a comment.Oct 3 2025, 1:40 PM

Change #1193421 had a related patch set uploaded (by Hashar; author: Hashar):

[mediawiki/extensions/Cite@master] Inject ExtensionRegistry in ReferencePreviewsHooks

https://gerrit.wikimedia.org/r/1193421

gerritbot added a comment.Oct 3 2025, 1:40 PM

Change #1193422 had a related patch set uploaded (by Hashar; author: Hashar):

[mediawiki/extensions/Cite@master] Only enable WikiEditor integration when it is loaded

https://gerrit.wikimedia.org/r/1193422

gerritbot added a comment.Oct 9 2025, 10:09 AM

Change #1193400 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Extend addOptionalDependencies to extend any property

https://gerrit.wikimedia.org/r/1193400

gerritbot added a comment.Oct 9 2025, 10:09 AM

Change #1193402 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Only run VisualEditor QUnit tests when it is loaded

https://gerrit.wikimedia.org/r/1193402

gerritbot added a comment.Oct 9 2025, 10:09 AM

Change #1193421 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Inject ExtensionRegistry in ReferencePreviewsHooks

https://gerrit.wikimedia.org/r/1193421

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.23; 2025-10-14).Oct 9 2025, 11:00 AM
gerritbot added a comment.Oct 9 2025, 6:48 PM

Change #1193422 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Only enable WikiEditor integration when it is loaded

https://gerrit.wikimedia.org/r/1193422

Maintenance_bot removed a project: Patch-For-Review.Oct 9 2025, 7:31 PM
hashar added a comment.Oct 10 2025, 4:10 PM

That is solved for master, I am not sure whether I will backport the 4 patches to the other branches. I am keeping the task open for now.

gerritbot added a comment.Oct 27 2025, 2:12 PM

Change #1198989 had a related patch set uploaded (by Hashar; author: Hashar):

[mediawiki/extensions/Cite@master] Only enable VisualEditor integration when it is loaded

https://gerrit.wikimedia.org/r/1198989

gerritbot added a project: Patch-For-Review.Oct 27 2025, 2:12 PM
gerritbot added a comment.Nov 5 2025, 12:07 PM

Change #1198989 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Only enable VisualEditor integration when it is loaded

https://gerrit.wikimedia.org/r/1198989

Maintenance_bot removed a project: Patch-For-Review.Nov 5 2025, 12:31 PM
ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.2; 2025-11-12).Nov 5 2025, 1:00 PM
gerritbot added a comment.Nov 26 2025, 12:18 PM

Change #1211661 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Move unrelated hook handlers out of ReferencePreviews class

https://gerrit.wikimedia.org/r/1211661

gerritbot added a project: Patch-For-Review.Nov 26 2025, 12:18 PM
gerritbot added a comment.Nov 27 2025, 10:38 AM

Change #1212090 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Inject ExtensionRegistry as service into CiteHooks

https://gerrit.wikimedia.org/r/1212090

gerritbot added a comment.Nov 28 2025, 11:26 AM

Change #1212090 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Inject ExtensionRegistry as service into CiteHooks

https://gerrit.wikimedia.org/r/1212090

ReleaseTaggerBot edited projects, added MW-1.46-notes (1.46.0-wmf.5; 2025-12-02); removed MW-1.46-notes (1.46.0-wmf.2; 2025-11-12).Nov 28 2025, 4:00 PM
hashar updated the task description. (Show Details)Dec 1 2025, 9:35 AM
gerritbot added a comment.Dec 1 2025, 3:15 PM

Change #1213500 had a related patch set uploaded (by Hashar; author: Hashar):

[mediawiki/extensions/Cite@master] [cypress] skip tests when VisualEditor is not loaded

https://gerrit.wikimedia.org/r/1213500

gerritbot added a comment.Dec 2 2025, 11:52 AM

Change #1213500 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] [cypress] skip tests when VisualEditor is not loaded

https://gerrit.wikimedia.org/r/1213500

hashar mentioned this in T411339: CI fails in REL1_43 due to CI infrastructure change to not recursively expand dependencies.Dec 2 2025, 12:02 PM
ReleaseTaggerBot edited projects, added MW-1.46-notes (1.46.0-wmf.7; 2025-12-16); removed MW-1.46-notes (1.46.0-wmf.5; 2025-12-02).Dec 2 2025, 1:00 PM
gerritbot added a comment.Dec 2 2025, 1:18 PM

Change #1211661 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Move unrelated hook handlers out of ReferencePreviews class

https://gerrit.wikimedia.org/r/1211661

Maintenance_bot removed a project: Patch-For-Review.Dec 2 2025, 1:30 PM
gerritbot added a comment.Dec 2 2025, 1:49 PM

Change #1214037 had a related patch set uploaded (by Hashar; author: Hashar):

[mediawiki/extensions/Cite@REL1_43] [cypress] skip tests when VisualEditor is not loaded

https://gerrit.wikimedia.org/r/1214037

gerritbot added a project: Patch-For-Review.Dec 2 2025, 1:49 PM

Change #1214038 had a related patch set uploaded (by Hashar; author: Hashar):

[mediawiki/extensions/Cite@REL1_44] [cypress] skip tests when VisualEditor is not loaded

https://gerrit.wikimedia.org/r/1214038

gerritbot added a comment.Dec 2 2025, 1:49 PM

Change #1214039 had a related patch set uploaded (by Hashar; author: Hashar):

[mediawiki/extensions/Cite@REL1_45] [cypress] skip tests when VisualEditor is not loaded

https://gerrit.wikimedia.org/r/1214039

gerritbot added a comment.Dec 2 2025, 1:51 PM

Change #1214040 had a related patch set uploaded (by Hashar; author: Hashar):

[mediawiki/extensions/Cite@REL1_45] Only enable VisualEditor integration when it is loaded

https://gerrit.wikimedia.org/r/1214040

gerritbot added a comment.Dec 2 2025, 1:57 PM

Change #1214043 had a related patch set uploaded (by Hashar; author: Hashar):

[mediawiki/extensions/Cite@REL1_44] Only enable VisualEditor integration when it is loaded

https://gerrit.wikimedia.org/r/1214043

gerritbot added a comment.Dec 2 2025, 2:12 PM

Change #1214054 had a related patch set uploaded (by Hashar; author: Hashar):

[mediawiki/extensions/Cite@REL1_44] Only enable WikiEditor integration when it is loaded

https://gerrit.wikimedia.org/r/1214054

gerritbot added a comment.Dec 2 2025, 2:27 PM

Change #1214058 had a related patch set uploaded (by Hashar; author: Hashar):

[mediawiki/extensions/Cite@REL1_44] Extend addOptionalDependencies to extend any property

https://gerrit.wikimedia.org/r/1214058

gerritbot added a comment.Dec 2 2025, 2:28 PM

Change #1214059 had a related patch set uploaded (by Hashar; author: Hashar):

[mediawiki/extensions/Cite@REL1_44] Only run VisualEditor QUnit tests when it is loaded

https://gerrit.wikimedia.org/r/1214059

gerritbot added a comment.Dec 2 2025, 2:37 PM

Change #1214062 had a related patch set uploaded (by Hashar; author: Hashar):

[mediawiki/extensions/Cite@REL1_44] Inject ExtensionRegistry in ReferencePreviewsHooks

https://gerrit.wikimedia.org/r/1214062

gerritbot added a comment.Dec 2 2025, 2:45 PM

Change #1214062 abandoned by Hashar:

[mediawiki/extensions/Cite@REL1_44] Inject ExtensionRegistry in ReferencePreviewsHooks

Reason:

That should be done in `CiteHooks`

https://gerrit.wikimedia.org/r/1214062

gerritbot added a comment.Dec 2 2025, 2:46 PM

Change #1214068 had a related patch set uploaded (by Hashar; author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@REL1_44] Inject ExtensionRegistry as service into CiteHooks

https://gerrit.wikimedia.org/r/1214068

gerritbot added a comment.Dec 3 2025, 9:36 AM

Change #1214456 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/config@master] Zuul: [mediawiki/extensions/Popups] disable recursion

https://gerrit.wikimedia.org/r/1214456

hashar added a parent task: T411339: CI fails in REL1_43 due to CI infrastructure change to not recursively expand dependencies.Dec 3 2025, 3:58 PM
gerritbot added a comment.Dec 3 2025, 6:04 PM

Change #1214058 merged by jenkins-bot:

[mediawiki/extensions/Cite@REL1_44] Extend addOptionalDependencies to extend any property

https://gerrit.wikimedia.org/r/1214058

gerritbot added a comment.Dec 3 2025, 6:05 PM

Change #1214059 merged by jenkins-bot:

[mediawiki/extensions/Cite@REL1_44] Only run VisualEditor QUnit tests when it is loaded

https://gerrit.wikimedia.org/r/1214059

gerritbot added a comment.Dec 3 2025, 6:08 PM

Change #1214068 merged by jenkins-bot:

[mediawiki/extensions/Cite@REL1_44] Inject ExtensionRegistry as service into CiteHooks

https://gerrit.wikimedia.org/r/1214068

gerritbot added a comment.Dec 3 2025, 6:08 PM

Change #1214054 merged by jenkins-bot:

[mediawiki/extensions/Cite@REL1_44] Only enable WikiEditor integration when it is loaded

https://gerrit.wikimedia.org/r/1214054

gerritbot added a comment.Dec 4 2025, 4:59 PM

Change #1214040 merged by jenkins-bot:

[mediawiki/extensions/Cite@REL1_45] Only enable VisualEditor integration when it is loaded

https://gerrit.wikimedia.org/r/1214040

gerritbot added a comment.Dec 4 2025, 5:27 PM

Change #1214039 merged by jenkins-bot:

[mediawiki/extensions/Cite@REL1_45] [cypress] skip tests when VisualEditor is not loaded

https://gerrit.wikimedia.org/r/1214039

gerritbot added a comment.Dec 4 2025, 5:30 PM

Change #1214038 merged by jenkins-bot:

[mediawiki/extensions/Cite@REL1_44] [cypress] skip tests when VisualEditor is not loaded

https://gerrit.wikimedia.org/r/1214038

gerritbot added a comment.Dec 4 2025, 5:32 PM

Change #1214037 merged by jenkins-bot:

[mediawiki/extensions/Cite@REL1_43] [cypress] skip tests when VisualEditor is not loaded

https://gerrit.wikimedia.org/r/1214037

gerritbot added a comment.Dec 21 2025, 3:33 PM

Change #1220011 had a related patch set uploaded (by Umherirrender; author: Hashar):

[mediawiki/extensions/Cite@REL1_43] Only enable WikiEditor integration when it is loaded

https://gerrit.wikimedia.org/r/1220011

gerritbot added a comment.Dec 21 2025, 4:50 PM

Change #1220011 merged by jenkins-bot:

[mediawiki/extensions/Cite@REL1_43] Only enable WikiEditor integration when it is loaded

https://gerrit.wikimedia.org/r/1220011

gerritbot added a comment.Jan 7 2026, 7:03 PM

Change #1214043 merged by jenkins-bot:

[mediawiki/extensions/Cite@REL1_44] Only enable VisualEditor integration when it is loaded

https://gerrit.wikimedia.org/r/1214043

hashar added a comment.Thu, Jan 8, 9:38 AM

All patches have been backported. Cite tests no more depends on VisualEditor or WikiEditor in order to pass.

hashar closed this task as Resolved.Thu, Jan 8, 9:39 AM
gerritbot added a comment.Thu, Jan 8, 9:43 AM

Change #1214456 merged by jenkins-bot:

[integration/config@master] Zuul: disable recursion after Cite got fixed

https://gerrit.wikimedia.org/r/1214456

Maintenance_bot removed a project: Patch-For-Review.Thu, Jan 8, 10:31 AM
gerritbot added a comment.Mon, Jan 19, 11:05 AM

Change #1228447 had a related patch set uploaded (by Hashar; author: Hashar):

[mediawiki/extensions/Cite@REL1_43] Only enable VisualEditor integration when it is loaded

https://gerrit.wikimedia.org/r/1228447

gerritbot added a project: Patch-For-Review.Mon, Jan 19, 11:05 AM
gerritbot added a comment.Mon, Jan 19, 12:49 PM

Change #1228482 had a related patch set uploaded (by Hashar; author: Hashar):

[mediawiki/extensions/Cite@REL1_43] Extend addOptionalDependencies to extend any property

https://gerrit.wikimedia.org/r/1228482

gerritbot added a comment.Mon, Jan 19, 12:50 PM

Change #1228483 had a related patch set uploaded (by Hashar; author: Hashar):

[mediawiki/extensions/Cite@REL1_43] Only run VisualEditor QUnit tests when it is loaded

https://gerrit.wikimedia.org/r/1228483

gerritbot added a comment.Wed, Jan 21, 1:43 PM

Change #1228447 merged by jenkins-bot:

[mediawiki/extensions/Cite@REL1_43] Only enable VisualEditor integration when it is loaded

https://gerrit.wikimedia.org/r/1228447

gerritbot added a comment.Wed, Jan 21, 2:52 PM

Change #1228482 merged by jenkins-bot:

[mediawiki/extensions/Cite@REL1_43] Extend addOptionalDependencies to extend any property

https://gerrit.wikimedia.org/r/1228482

gerritbot added a comment.Wed, Jan 21, 2:53 PM

Change #1228483 merged by jenkins-bot:

[mediawiki/extensions/Cite@REL1_43] Only run VisualEditor QUnit tests when it is loaded

https://gerrit.wikimedia.org/r/1228483

hashar added a comment.Wed, Jan 21, 3:10 PM

I got REL1_43 fixed as well :-]

Maintenance_bot removed a project: Patch-For-Review.Wed, Jan 21, 3:32 PM
Hslater mentioned this in T415252: CI fails in REL1_43 due to Cite.Thu, Jan 22, 11:50 AM
gerritbot added a comment.Tue, Jan 27, 2:11 PM

Change #1233713 had a related patch set uploaded (by Hashar; author: Hashar):

[mediawiki/extensions/Cite@REL1_43] tests: VE module is loaded when VisualEditor is loaded

https://gerrit.wikimedia.org/r/1233713

gerritbot added a project: Patch-For-Review.Tue, Jan 27, 2:11 PM
gerritbot added a comment.Tue, Jan 27, 2:49 PM

Change #1233732 had a related patch set uploaded (by Hashar; author: Hashar):

[mediawiki/extensions/Cite@REL1_44] tests: test loading VE integration separately

https://gerrit.wikimedia.org/r/1233732

gerritbot added a comment.Tue, Jan 27, 2:49 PM

Change #1233733 had a related patch set uploaded (by Hashar; author: Hashar):

[mediawiki/extensions/Cite@REL1_45] tests: test loading VE integration separately

https://gerrit.wikimedia.org/r/1233733

gerritbot added a comment.Tue, Jan 27, 2:50 PM

Change #1233734 had a related patch set uploaded (by Hashar; author: Hashar):

[mediawiki/extensions/Cite@master] tests: test loading VE integration separately

https://gerrit.wikimedia.org/r/1233734

gerritbot added a comment.Tue, Jan 27, 2:58 PM

Change #1233732 abandoned by Hashar:

[mediawiki/extensions/Cite@REL1_44] tests: test loading VE integration separately

Reason:

This is not needed on REL1_44 since the test mocks `ExtensionRegistry->isLoaded()`

https://gerrit.wikimedia.org/r/1233732

gerritbot added a comment.Tue, Jan 27, 2:58 PM

Change #1233733 abandoned by Hashar:

[mediawiki/extensions/Cite@REL1_45] tests: test loading VE integration separately

Reason:

This is not needed on REL1_45 since the test mocks `ExtensionRegistry->isLoaded()`

https://gerrit.wikimedia.org/r/1233733

gerritbot added a comment.Tue, Jan 27, 2:59 PM

Change #1233734 abandoned by Hashar:

[mediawiki/extensions/Cite@master] tests: test loading VE integration separately

Reason:

This is not needed on master since the test mocks `ExtensionRegistry->isLoaded()`

https://gerrit.wikimedia.org/r/1233734

gerritbot added a comment.Tue, Jan 27, 3:05 PM

Change #1233713 merged by jenkins-bot:

[mediawiki/extensions/Cite@REL1_43] tests: test loading VE integration separately

https://gerrit.wikimedia.org/r/1233713

Maintenance_bot removed a project: Patch-For-Review.Tue, Jan 27, 3:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits