Page MenuHomePhabricator
Create Task
Maniphest T406372

Codex-PHP: Add support for fake buttons (link buttons)
Open, HighPublic
Actions

Description

CSS-only buttons support link buttons, but we don't have support for these in Codex-PHP. There should be a way to get Codex-PHP to output a link button.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
sandbox: Add additional examples of link buttons to ButtonExampleEileenBlessingdesign/codex-phpmain+31 -3
Buttons: Added support for fake buttonsRishandesign/codex-phpmain+72 -1
Button: Add support for fake buttons (link buttons)ItoroJamesdesign/codex-phpmain+4 -1
button: Add support for fake buttons (link buttons)EileenBlessingdesign/codex-phpmain+77 -6
Add support for fake buttons (link buttons)Vanessa_bedzradesign/codex-phpmain+65 -15
Customize query in gerrit

Related Objects
Search...

Event Timeline

Catrope created this task.Oct 3 2025, 6:29 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 3 2025, 6:29 PM
Catrope triaged this task as High priority.Oct 3 2025, 6:29 PM
Catrope moved this task from Backlog to Ready for Design/Dev on the Codex board.
Catrope added a parent task: T406373: Use fake/link buttons instead of regular buttons in places where that would be better.
Samwilson mentioned this in T409142: Add functionality for adding and editing watchlist labels.Nov 5 2025, 4:40 AM
Samwilson mentioned this in T416813: Use 'add' icon in new-label button.Feb 9 2026, 12:46 AM
Daimona subscribed.Feb 23 2026, 1:44 PM

Just chiming in to say we also have a use case for this in T412087 (F68620259), in case one is needed.

Catrope mentioned this in T418023: Outreachy 32: Vector 2022 Codex PHP migration.Feb 24 2026, 8:07 PM
LGoto added a parent task: T418023: Outreachy 32: Vector 2022 Codex PHP migration.Feb 24 2026, 8:18 PM
Vanny claimed this task.EditedMar 20 2026, 7:23 PM

Hello , I am Vanessa Bedzra
I would like to work on this task
@Catrope

gerritbot added a comment.Mar 22 2026, 8:40 AM

Change #1257891 had a related patch set uploaded (by Vanessa_bedzra; author: Vanessa_bedzra):

[design/codex-php@main] T406372:Add support for fake buttons (link buttons)

https://gerrit.wikimedia.org/r/1257891

gerritbot added a project: Patch-For-Review.Mar 22 2026, 8:40 AM
gerritbot added a comment.Mar 22 2026, 8:51 AM

Change #1257899 had a related patch set uploaded (by Vanessa_bedzra; author: Vanessa_bedzra):

[design/codex-php@main] T406372::Add snapshot test

https://gerrit.wikimedia.org/r/1257899

gerritbot added a comment.Mar 22 2026, 9:07 AM

Change #1257899 abandoned by Vanessa_bedzra:

[design/codex-php@main] T406372::Add snapshot test

https://gerrit.wikimedia.org/r/1257899

Vanny added a comment.Mar 22 2026, 10:06 AM

hi @Catrope , https://gerrit.wikimedia.org/r/c/design/codex-php/+/1257891 PR made, pending review

gerritbot added a comment.Mar 22 2026, 3:50 PM

Change #1257891 had a related patch set uploaded (by Vanessa_bedzra; author: Vanessa_bedzra):

[design/codex-php@main] Add support for fake buttons (link buttons)

https://gerrit.wikimedia.org/r/1257891

gerritbot added a comment.Mar 22 2026, 4:03 PM

Change #1257891 had a related patch set uploaded (by Vanessa_bedzra; author: Vanessa_bedzra):

[design/codex-php@main] T406372: Add support for fake buttons (link buttons)

https://gerrit.wikimedia.org/r/1257891

gerritbot added a comment.Mar 24 2026, 4:03 PM

Change #1260016 had a related patch set uploaded (by ItoroJames; author: ItoroJames):

[design/codex-php@main] Button: Add support for fake buttons (link buttons)

https://gerrit.wikimedia.org/r/1260016

ItoroJames subscribed.Mar 24 2026, 4:06 PM

Hello, I have added a patch:

https://gerrit.wikimedia.org/r/c/design/codex-php/+/1260016

Please review

gerritbot added a comment.Mar 24 2026, 4:56 PM

Change #1257891 had a related patch set uploaded (by Vanessa_bedzra; author: Vanessa_bedzra):

[design/codex-php@main] T406372:Add support for fake buttons (link buttons)

https://gerrit.wikimedia.org/r/1257891

gerritbot added a comment.Mar 24 2026, 4:59 PM

Change #1257891 had a related patch set uploaded (by Vanessa_bedzra; author: Vanessa_bedzra):

[design/codex-php@main] Add support for fake buttons (link buttons)

https://gerrit.wikimedia.org/r/1257891

gerritbot added a comment.Mar 28 2026, 12:41 PM

Change #1262987 had a related patch set uploaded (by EileenBlessing; author: EileenBlessing):

[design/codex-php@main] button: Add support for fake buttons (link buttons)

https://gerrit.wikimedia.org/r/1262987

gerritbot added a comment.Mar 28 2026, 12:41 PM

Change #1262988 had a related patch set uploaded (by EileenBlessing; author: EileenBlessing):

[design/codex-php@main] sandbox: Add examples of link buttons to ButtonExample

https://gerrit.wikimedia.org/r/1262988

LGoto closed this task as Declined.Mar 31 2026, 10:22 PM
LGoto subscribed.

Thanks to all the candidates who showed an interest in this project. Unfortunately, due to changing circumstances, the mentor team is no longer able to move forward with this project proposal. We appreciate all the work that’s been put into this already, and wish all the candidates the best in your future work.

Daimona reopened this task as Open.Apr 1 2026, 12:23 AM
Daimona removed Vanny as the assignee of this task.
Daimona added a subscriber: Vanny.

Even if no longer worked on as part of Outreachy, this remains a valid feature request, hence reopening and adjusting.

Daimona removed a parent task: T418023: Outreachy 32: Vector 2022 Codex PHP migration.Apr 1 2026, 12:23 AM
Vanny added a comment.Apr 1 2026, 7:43 AM

Noted @Daimona

gerritbot added a comment.Apr 1 2026, 5:33 PM

Change #1257891 merged by jenkins-bot:

[design/codex-php@main] Add support for fake buttons (link buttons)

https://gerrit.wikimedia.org/r/1257891

bwang mentioned this in rDCPH998fe074c7b9: Add support for fake buttons (link buttons).Apr 1 2026, 5:35 PM
gerritbot added a comment.Apr 8 2026, 3:24 AM

Change #1262987 abandoned by VolkerE:

[design/codex-php@main] button: Add support for fake buttons (link buttons)

Reason:

Thanks for the contribution! We went with I3fdae440e7807 here instead as the other contribution was slightly more advanced and originally provided earlier. Best regards

https://gerrit.wikimedia.org/r/1262987

gerritbot added a comment.Apr 8 2026, 3:34 AM

Change #1260016 abandoned by VolkerE:

[design/codex-php@main] Button: Add support for fake buttons (link buttons)

Reason:

Thanks for the contribution. We went with I3fdae440e7807 as the patch was provided earlier. Best regards!

https://gerrit.wikimedia.org/r/1260016

gerritbot added a comment.Apr 22 2026, 12:20 AM

Change #1262988 merged by jenkins-bot:

[design/codex-php@main] sandbox: Add additional examples of link buttons to ButtonExample

https://gerrit.wikimedia.org/r/1262988

jenkins-bot mentioned this in rDCPHe4f45376173f: sandbox: Add additional examples of link buttons to ButtonExample.Apr 22 2026, 12:21 AM
Samwilson awarded a token.Sat, Jun 20, 11:11 AM
Samwilson subscribed.Mon, Jun 22, 2:00 AM

Is there anything more to do here? It looks like the functionality was added by @Vanny and that it's now possible to provide the href key in a button's config.

Vanny added a comment.Mon, Jun 22, 4:30 AM

@Samwilson Yes, that's right. I added support for the href key in the button configuration, so the required functionality is already in place. Unless there's another requirement I'm missing, I think this is complete.

Samwilson mentioned this in T429911: Update Article.php and ImagePage.php to use CodexPHP buttons.Tue, Jun 23, 12:56 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits