Page MenuHomePhabricator
Create Task
Maniphest T406382

Make "recovery-codes.txt" file name translatable
Closed, ResolvedPublic
Actions

Description

Right now we have this as a hard-coded English string. Make this translatable, and also change it to "recovery-code.txt" (singular) if there's only one code being downloaded.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
RecoveryCodesTrait: Add issuer to the download filename, make translateablemediawiki/extensions/OATHAuthmaster+8 -1
Customize query in gerrit

Event Timeline

Catrope created this task.Oct 3 2025, 7:35 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 3 2025, 7:35 PM
Catrope moved this task from Inbox to UX cleanup on the FY2025-26 WE 4.6 - Account Security (WE 4.6.4 - 2FA improvements and passkey support) board.Oct 3 2025, 7:35 PM
Reedy moved this task from Backlog to Features/Improvements on the MediaWiki-extensions-OATHAuth board.Oct 3 2025, 7:47 PM
Reedy added a project: I18n.
matmarex subscribed.Oct 14 2025, 12:41 AM
T4NeGMp7P4en added a subtask: T407167: Only One Recovery codes given.Oct 15 2025, 6:29 PM
Reedy removed a subtask: T407167: Only One Recovery codes given.Oct 17 2025, 2:54 PM
Catrope added a comment.Oct 22 2025, 4:56 PM

Per https://gerrit.wikimedia.org/r/c/mediawiki/extensions/OATHAuth/+/1195271 we should also consider changing recoverycodes.txt to something like $1-recovery-codes.txt where $1 is $wgOATHAuthAccountPrefix.

matmarex added a comment.Oct 23 2025, 1:43 PM

and also change it to "recovery-code.txt" (singular) if there's only one code being downloaded.

I guess this is no longer relevant since we generate multiple codes now.

gerritbot added a comment.Oct 23 2025, 1:44 PM

Change #1195271 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/OATHAuth@master] RecoveryCodesTrait: Add issuer to the download filename, make translateable

https://gerrit.wikimedia.org/r/1195271

gerritbot added a project: Patch-For-Review.Oct 23 2025, 1:44 PM
gerritbot added a comment.Oct 25 2025, 10:03 AM

Change #1195271 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@master] RecoveryCodesTrait: Add issuer to the download filename, make translateable

https://gerrit.wikimedia.org/r/1195271

Maintenance_bot removed a project: Patch-For-Review.Oct 25 2025, 10:30 AM
ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.25; 2025-10-28).Oct 25 2025, 11:00 AM
matmarex closed this task as Resolved.Oct 27 2025, 10:19 PM
matmarex claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits