Page MenuHomePhabricator
Create Task
Maniphest T406407

MediaWiki\Title\Title::getPageViewLanguage was deprecated in MediaWiki 1.42
Open, Needs TriagePublicBUG REPORT
Actions

Description

MW 1.43, Metrolook 7.0.0.

Deprecated: Use of MediaWiki\Title\Title::getPageViewLanguage was deprecated in MediaWiki 1.42. [Called from MetrolookTemplate::execute in /var/www/wiki/w/skins/Metrolook/MetrolookTemplate.php at line 173] in /var/www/wiki/w/includes/debug/MWDebug.php on line 385

Call Stack
#	Time	Memory	Function	Location
1	0.0004	505064	{main}( )	.../index.php:0
2	0.0770	4326480	MediaWiki\MediaWikiEntryPoint->run( )	.../index.php:58
3	0.0770	4326480	MediaWiki\Actions\ActionEntryPoint->execute( )	.../MediaWikiEntryPoint.php:200
4	0.5812	11711408	MediaWiki\Output\OutputPage->output( $return = TRUE )	.../ActionEntryPoint.php:163
5	1.3468	12297616	Skin->outputPageFinal( $out = class MediaWiki\Output\OutputPage { (variables skipped) )	.../OutputPage.php:3193
6	1.3468	12314128	SkinTemplate->outputPage( )	.../Skin.php:683
7	1.3497	12323104	SkinTemplate->generateHTML( )	.../SkinTemplate.php:180
8	2.1735	14751080	MetrolookTemplate->execute( )	.../SkinTemplate.php:161
9	2.1775	14752896	MediaWiki\Title\Title->getPageViewLanguage( )	.../MetrolookTemplate.php:173
10	2.1775	14752896	wfDeprecated( $function = 'MediaWiki\\Title\\Title::getPageViewLanguage', $version = '1.42', $component = ???, $callerOffset = ??? )	.../Title.php:3613
11	2.1775	14752896	MediaWiki\Debug\MWDebug::deprecated( $function = 'MediaWiki\\Title\\Title::getPageViewLanguage', $version = '1.42', $component = FALSE, $callerOffset = 3 )	.../GlobalFunctions.php:773
12	2.1775	14753008	MediaWiki\Debug\MWDebug::deprecatedMsg( $msg = 'Use of MediaWiki\\Title\\Title::getPageViewLanguage was deprecated in MediaWiki 1.42.', $version = '1.42', $component = 'MediaWiki', $callerOffset = 4 )	.../MWDebug.php:237
13	2.1775	14754544	MediaWiki\Debug\MWDebug::sendRawDeprecated( $msg = 'Use of MediaWiki\\Title\\Title::getPageViewLanguage was deprecated in MediaWiki 1.42. [Called from MetrolookTemplate::execute in /var/www/wiki/w/skins/Metrolook/MetrolookTemplate.php at line 173]', $sendToLog = TRUE, $callerFunc = 'MetrolookTemplate::execute' )	.../MWDebug.php:355
14	2.1775	14754544	trigger_error( $message = 'Use of MediaWiki\\Title\\Title::getPageViewLanguage was deprecated in MediaWiki 1.42. [Called from MetrolookTemplate::execute in /var/www/wiki/w/skins/Metrolook/MetrolookTemplate.php at line 173]', $error_level = 16384 )	.../MWDebug.php:385

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Replace deprecated Title::getPageViewLanguage with OutputPage::getLanguage() fallback in MetrolookTemplatemediawiki/skins/Metrolookmaster+12 -1
Customize query in gerrit

Event Timeline

alex-mashin created this task.Oct 4 2025, 9:45 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 4 2025, 9:45 AM
Aklapper renamed this task from Deprecation im MW 1.42 to MediaWiki\Title\Title::getPageViewLanguage was deprecated in MediaWiki 1.42.Oct 4 2025, 9:56 AM
Adarsh2406 subscribed.Oct 4 2025, 11:12 AM
Adarsh2406 added a comment.Oct 4 2025, 11:42 AM

Hey I have tried to fix the bug coming on the page MetroLookTemplate.php , "Replaced deprecated Title::getPageViewLanguage with OutputPage::getLanguage() fallback in MetrolookTemplate" you can check it and review the code or if any issue or the changes is wrong let me know !

Aklapper added a comment.Oct 4 2025, 12:09 PM

@Adarsh2406: Hi and welcome! Please follow https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines and edit the commit message of your Gerrit patch so it will automatically be linked to this task. Thanks in advance.

Adarsh2406 added a comment.Oct 4 2025, 12:14 PM

@Aklapper thanks for letting me know this but i have already done this while commiting the changes in Gerrit !

Aklapper added a comment.Oct 4 2025, 12:17 PM

@Adarsh2406: No you have not. If the commit message was correct, then there would be an automated notification in this very task.

Adarsh2406 added a comment.Oct 4 2025, 12:22 PM

okk okk @Aklapper i will check this in the link you provided and will let you know !

Aklapper added a comment.Oct 4 2025, 12:25 PM

@Adarsh2406 Thanks! Please do not let me know - if it works there will be an automated message in this task anyway. :)

Adarsh2406 added a comment.Oct 4 2025, 12:32 PM

okk :D @Aklapper

alex-mashin added a comment.Oct 4 2025, 1:21 PM
In T406407#11243621, @Adarsh2406 wrote:

Hey I have tried to fix the bug coming on the page MetroLookTemplate.php , "Replaced deprecated Title::getPageViewLanguage with OutputPage::getLanguage() fallback in MetrolookTemplate" you can check it and review the code or if any issue or the changes is wrong let me know !

Please, add Bug: T406407 in the end of the commit message, so that I could see the URL of the patch and test it.

gerritbot added a comment.Oct 4 2025, 1:28 PM

Change #1193533 had a related patch set uploaded (by Adarsh2406; author: Adarsh2406):

[mediawiki/skins/Metrolook@master] Metrolook: Use OutputPage::getLanguage() to avoid deprecated Title::getPageViewLanguage\n\nReplace the direct call to Title::getPageViewLanguage() in MetrolookTemplate::execute with OutputPage::getLanguage() when available, falling back to Title::getPageLanguage() as a safe legacy option. This removes the deprecation warning on MediaWiki 1.42+ while preserving behavior for older contexts.\n\nBug: T42\nBug: T406407\nChange-Id: I5db2ef3c6ba6046fa493387891c667f82575a4aa

https://gerrit.wikimedia.org/r/1193533

gerritbot added a project: Patch-For-Review.Oct 4 2025, 1:28 PM
gerritbot added a comment.Oct 4 2025, 1:32 PM

Change #1193534 had a related patch set uploaded (by Adarsh2406; author: Adarsh2406):

[mediawiki/skins/Metrolook@master] Metrolook: Use OutputPage::getLanguage() to avoid deprecated Title::getPageViewLanguage\n\nReplace the direct call to Title::getPageViewLanguage() in MetrolookTemplate::execute with OutputPage::getLanguage() when available, falling back to Title::getPageLanguage() as a safe legacy option. This removes the deprecation warning on MediaWiki 1.42+ while preserving behavior for older contexts.\n\nBug: T42\nBug: T406407\nChange-Id: I5db2ef3c6ba6046fa493387891c667f82575a4aa

https://gerrit.wikimedia.org/r/1193534

gerritbot added a comment.Oct 4 2025, 1:37 PM

Change #1193536 had a related patch set uploaded (by Adarsh2406; author: Adarsh2406):

[mediawiki/skins/Metrolook@master] Metrolook: Use OutputPage::getLanguage() to avoid deprecated Title::getPageViewLanguage\n\nReplace the direct call to Title::getPageViewLanguage() in MetrolookTemplate::execute with OutputPage::getLanguage() when available, falling back to Title::getPageLanguage() as a safe legacy option. This removes the deprecation warning on MediaWiki 1.42+ while preserving behavior for older contexts.\n\nBug: T406407\nChange-Id: I5db2ef3c6ba6046fa493387891c667f82575a4aa

https://gerrit.wikimedia.org/r/1193536

Adarsh2406 added a comment.Oct 4 2025, 1:39 PM

added bug -id
@alex-mashin

Aklapper added a comment.Oct 4 2025, 2:04 PM

@Adarsh2406: Hi, please see https://www.mediawiki.org/wiki/Gerrit/Tutorial#Amending_a_change - there are now 5 patches. I'm going to abandon 4.

gerritbot added a comment.Oct 4 2025, 2:05 PM

Change #1193534 abandoned by Aklapper:

[mediawiki/skins/Metrolook@master] Metrolook: Use OutputPage::getLanguage() to avoid deprecated Title::getPageViewLanguage\n\nReplace the direct call to Title::getPageViewLanguage() in MetrolookTemplate::execute with OutputPage::getLanguage() when available, falling back to Title::getPageLanguage() as a safe legacy option. This removes the deprecation warning on MediaWiki 1.42+ while preserving behavior for older contexts.\n\nBug: T42\nBug: T406407\nChange-Id: I5db2ef3c6ba6046fa493387891c667f82575a4aa

Reason:

Duplicate of https://gerrit.wikimedia.org/r/c/mediawiki/skins/Metrolook/+/1193526

https://gerrit.wikimedia.org/r/1193534

gerritbot added a comment.Oct 4 2025, 2:05 PM

Change #1193533 abandoned by Aklapper:

[mediawiki/skins/Metrolook@master] Metrolook: Use OutputPage::getLanguage() to avoid deprecated Title::getPageViewLanguage\n\nReplace the direct call to Title::getPageViewLanguage() in MetrolookTemplate::execute with OutputPage::getLanguage() when available, falling back to Title::getPageLanguage() as a safe legacy option. This removes the deprecation warning on MediaWiki 1.42+ while preserving behavior for older contexts.\n\nBug: T42\nBug: T406407\nChange-Id: I5db2ef3c6ba6046fa493387891c667f82575a4aa

Reason:

Duplicate of https://gerrit.wikimedia.org/r/c/mediawiki/skins/Metrolook/+/1193526

https://gerrit.wikimedia.org/r/1193533

gerritbot added a comment.Oct 4 2025, 2:05 PM

Change #1193536 abandoned by Aklapper:

[mediawiki/skins/Metrolook@master] Metrolook: Use OutputPage::getLanguage() to avoid deprecated Title::getPageViewLanguage\n\nReplace the direct call to Title::getPageViewLanguage() in MetrolookTemplate::execute with OutputPage::getLanguage() when available, falling back to Title::getPageLanguage() as a safe legacy option. This removes the deprecation warning on MediaWiki 1.42+ while preserving behavior for older contexts.\n\nBug: T406407\nChange-Id: I5db2ef3c6ba6046fa493387891c667f82575a4aa

Reason:

Duplicate of https://gerrit.wikimedia.org/r/c/mediawiki/skins/Metrolook/+/1193526

https://gerrit.wikimedia.org/r/1193536

gerritbot added a comment.Oct 4 2025, 2:05 PM

Change #1193526 had a related patch set uploaded (by Aklapper; author: Adarsh2406):

[mediawiki/skins/Metrolook@master] Replace deprecated Title::getPageViewLanguage with OutputPage::getLanguage() fallback in MetrolookTemplate

https://gerrit.wikimedia.org/r/1193526

alex-mashin added a comment.Oct 4 2025, 2:16 PM
In T406407#11243705, @Adarsh2406 wrote:

added bug -id
@alex-mashin

Thank you, it seems to help.

Adityakumar0545 added a project: RoadToWiki.Oct 4 2025, 5:38 PM
Adarsh2406 added a comment.Oct 4 2025, 5:41 PM

Hi — Verified +2 is green. Could someone with Code-Review/Submit rights please give Code-Review +2 and submit this change?
Also please backport to REL1_43 if accepted.
Bug: T406407. Thanks!

Adarsh2406 claimed this task.Oct 6 2025, 3:56 PM
Paladox subscribed.Oct 6 2025, 4:16 PM

This was already fixed with https://gerrit.wikimedia.org/r/c/mediawiki/skins/Metrolook/+/1134366 just it wasn't in MW 1.43/MW 1.42 branches.

Adarsh2406 added a comment.Oct 12 2025, 6:55 AM

Can anyone please review my changes as its been a long time i pushed the changes and there is no code review ?

alex-mashin added a comment.Oct 12 2025, 7:06 AM
In T406407#11266914, @Adarsh2406 wrote:

Can anyone please review my changes as its been a long time i pushed the changes and there is no code review ?

Looks like this change is no longer needed, because this bug has been fixed earlier by another patch; which is now backported to MW 1.43.

Adarsh2406 added a comment.Oct 12 2025, 7:11 AM

ok okk @alex-mashin then should i abandon this change on my gerrit ?

alex-mashin added a comment.Oct 12 2025, 7:15 AM
In T406407#11266920, @Adarsh2406 wrote:

ok okk @alex-mashin then should i abandon this change on my gerrit ?

I think, yes.

gerritbot added a comment.Oct 12 2025, 7:22 AM

Change #1193526 abandoned by Adarsh2406:

[mediawiki/skins/Metrolook@master] Replace deprecated Title::getPageViewLanguage with OutputPage::getLanguage() fallback in MetrolookTemplate

Reason:

The bug is alreadt fixed by someone !

https://gerrit.wikimedia.org/r/1193526

Maintenance_bot removed a project: Patch-For-Review.Oct 12 2025, 7:30 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits