MW 1.43, Refreshed 4.0.8 (d6593f6).
The more specific Refreshed-this-wiki-wordmark message is ignored, if the less specific wiki-wide $wgLogos['wordmark'] is set.
Should be other way round.
In particular, this does not allow to define a wordmark in inverse color, so that it can be clearly visible against the dark blue background.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Prefer custom, skin-specific wordmark over $wgLogos['wordmark'] | mediawiki/skins/Refreshed | master | +5 -4 |
Change #1193537 had a related patch set uploaded (by Jack Phoenix; author: Jack Phoenix):
[mediawiki/skins/Refreshed@master] Prefer custom, skin-specific wordmark over $wgLogos['wordmark']
Hey I am a newcomer here and tried to fix the bug please check and let me know the changes i made is correct or not or what changes i need to make !
Change #1193540 had a related patch set uploaded (by Adarsh2406; author: Adarsh2406):
[mediawiki/skins/Refreshed@master] Refreshed: prefer skin message refreshed-this-wiki-wordmark over global \['wordmark'\]\n\nMore-specific Refreshed skin message should override the global wordmark so wikis\ncan provide custom/inverse variants. Fall back to \['wordmark'\] only if\nno message is present in user/content languages.\n\nBug: T406412\nChange-Id: I0123456789abcdef0123456789abcdef01234567
Sorry, you're in the wrong bug. Your patch has fixed the problem with Metrolook, and I have posted a message about that there; but this bug concerns the Refreshed skin.
Change #1193540 abandoned by Adarsh2406:
[mediawiki/skins/Refreshed@master] Refreshed: prefer skin message refreshed-this-wiki-wordmark over global \['wordmark'\]\n\nMore-specific Refreshed skin message should override the global wordmark so wikis\ncan provide custom/inverse variants. Fall back to \['wordmark'\] only if\nno message is present in user/content languages.\n\nBug: T406412\nChange-Id: I0123456789abcdef0123456789abcdef01234567
@alex-mashin ohh thats my mistake i abanodoned that change and you can check my another commit i made !
Hi — Verified +2 is green. Could someone with Code-Review/Submit rights please give Code-Review +2 and submit this change?
Bug: T406412. Thanks!
@Adarsh2406: Again: You are in the wrong task. The only patch associated with this task is https://gerrit.wikimedia.org/r/c/1193537 by ashley and this task is assigned to ashley. Please keep discussion on-topic. This is not a forum. Thanks.