Page MenuHomePhabricator

PendingChangesBot: Add former bot detection to SQL query and bot checks
Closed, ResolvedPublic

Description

Modify bot detection so that the initial SQL query also stores information about whether the user is a former bot in the local database and includes it in the bot check. Add separate former bot detection to tests as well.

SQL query which loads the data can be found here

User former groups table information

You can test SQL queries using Quarry and Superset:

Bot detection is located in autoreview.py.

Tests

Event Timeline

Hello, can you assign this to me? I would love to work on it.

@Nirmeetkamble : Check that you get the developer environment running (ie. it works locally) when it is ok you can assign the task for yourself. Also, I would like to get feedback if you need more complex tasks and I will try balance new tasks with the info.

Hey Zache, I can run the server locally, but for some reason, the tests are failing. I will just find the root cause, and then I will assign this issue to me. Thank you for your help.

I fixed one issue which was caused by stylistic change on one SQL query. If you pull the latest version it should work now?

note there is also one RuntimeError: failure on the tests, but it is on purpose to test the error handling.) and it will resolve as OK as result.

Hello Team, I have raised an PR [ https://github.com/Wikimedia-Suomi/PendingChangesBot-ng/pull/5 ]. Please let me know if any changes required

Zache claimed this task.

Pull request successfully merged and closed in github