Page MenuHomePhabricator

WLM app shows duplicate listings when browsing through Map View
Closed, ResolvedPublic

Description

I see numerous points that on the map show "2" but zoomed in only show "1". Switching to list view confirms that their are duplicates.


Version: unspecified
Severity: normal

Details

Reference
bz38645

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 12:59 AM
bzimport set Reference to bz38645.

Do you have examples where this happened? This might be caused by having listings in multiple languages. See https://commons.wikimedia.org/wiki/Commons:Monuments_database/Statistics to see what countries have multiple languages.

The api seems to be sending duplicates:

Look at the result of this for example:

http://toolserver.org/~erfgoed/api/api.php?format=json&action=search&bbox=-122.42446303367615,37.75649954571735,-122.42253184318542,37.75870070450265

There are 2 with
name="[[Liberty Street Historic District (San Francisco, California)|Liberty Street Historic District]]"

and 2 with
name="[[John McMullen House|John McMullen House]]"

These monuments are listed as both country=us and country=us-ca, something wrong with erfgoedbot.

Ah, found my mistake. It was supposed to take the data from https://en.wikipedia.org/wiki/Special:WhatLinksHere/Template:CHL_row and put it in the monuments_us-ca_(en) table. That goes right, but it looks like I forgot a -ca in the import so the wrong table is being imported. Fixed in https://fisheye.toolserver.org/browse/erfgoed/erfgoedbot/sql/fill_table_monuments_all.sql?r1=769&r2=774

I issued "mysql> delete from monuments_all WHERE country='us-ca';", that might take some time to complete