The preview function no longer works. Pressing the button does nothing. There are no errors in the browser console or MW logs.
This was introduced in T402001: Use classes in frontend.
Description
Description
Details
Details
Related Changes in Gerrit:
| Subject | Author | Repo | Branch | Lines +/- | |
|---|---|---|---|---|---|
| Previewing doesn't work on Special:EditLexicon | Viktoria Hillerud WMSE | mediawiki/extensions/Wikispeech | master | +29 -28 |
Related Objects
Related Objects
Event Timeline
Comment Actions
Change #1197592 had a related patch set uploaded (by Viktoria Hillerud WMSE; author: Viktoria Hillerud WMSE):
[mediawiki/extensions/Wikispeech@master] Previewing doesn't work on Special:EditLexicon
Comment Actions
The CI and QUnit test fails with an error that says:
mediawiki.base/track: trackError (1, 6, 7)Rerun2 ms
emit1@ 0 ms
sub@ 1 ms
{"exception":{},"module":"ext.wikispeech.specialEditLexicon","source":"module-execute"}@ 1 ms
foo@ 1 ms
emit2@ 1 ms
bar@ 1 ms
failed@ 1 ms
Expected:
[
"emit1",
"sub",
"foo",
"emit2",
"bar"
]
Result:
[
"emit1",
"sub",
"{\"exception\":{},\"module\":\"ext.wikispeech.specialEditLexicon\",\"source\":\"module-execute\"}",
"foo",
"emit2",
"bar"
]
Diff:
[
"emit1",
"sub",
"{\"exception\":{},\"module\":\"ext.wikispeech.specialEditLexicon\",\"source\":\"module-execute\"}",
"foo",
"emit2",
"bar"
]
Source:
verifySteps@http://localhost:8080/w/resources/lib/qunitjs/qunit.js:1626:14
Source: @http://localhost:8080/w/load.php?modules=%40wikimedia%2Fcodex%2Ccodex-styles%2Coojs%2Coojs-ui%2Coojs-ui-core%2Coojs-ui-toolbars%2Coojs-ui-widgets%2Coojs-ui-windows%2Cpinia%2Csinonjs%2Cvue%2Cvue-test-utils%7Cext.wikispeech%7Cext.wikispeech.specialEditLexicon%7Cjquery.client%2ChighlightText%2ClengthLimit%2CmakeCollapsible%2Ctablesorter%2CtextSelection%7Cjquery.makeCollapsible.styles%7Cjquery.tablesorter.styles%7Cmediawiki.DateFormatter%2CForeignApi%2CString%2CTitle%2CUri%2Capi%2Ccldr%2CconfirmCloseWindow%2Ccookie%2Cdeflate%2Cexperiments%2Cinspect%2CjqueryMsg%2Clanguage%2CmessagePoster%2Cqunit-testrunner%2Crouter%2Cstorage%2Ctemplate%2Ctoc%2Cuser%2Cutil%2CvisibleTimeout%2Cwidgets%7Cmediawiki.ForeignApi.core%7Cmediawiki.language.grammar.testdata%7Cmediawiki.language.jqueryMsg.testdata%7Cmediawiki.language.months%2Ctestdata%7Cmediawiki.libs.pluralruleparser%7Cmediawiki.page.ready%7Cmediawiki.rcfilters.filters.ui%7Cmediawiki.special.block.codex%7Cmediawiki.template.mustache%7Cmediawiki.widgets.MediaSearch%2CTable%2CUserInputWidget%2Cstyles%7Coojs-ui-core.icons%2Cstyles%7Coojs-ui-toolbars.icons%7Coojs-ui-widgets.icons%7Coojs-ui-windows.icons%7Coojs-ui.styles.icons-content%2Cicons-editing-advanced%2Cicons-editing-core%2Cicons-editing-styling%2Cicons-interactions%2Cicons-layout%2Cicons-media%2Cicons-moderation%2Cicons-movement%2Cindicators%7Cskins.vector.clientPreferences%7Ctest.MediaWiki%2CVector%2CWikispeech%2CWikispeech%20Speech%20Data%20Collector&version=o2yvl:2342:366This came after rearranging the order in extension.json (that also fixed the problem with transcription previewer button):
"ext.wikispeech.specialEditLexicon": {
"packageFiles": [
"ext.wikispeech.specialEditLexicon.js",
"ext.wikispeech.transcriptionPreviewer.js",
"ext.wikispeech.util.js"
],Comment Actions
Since we had to move up this in extension.json:
"ext.wikispeech.specialEditLexicon": {
"packageFiles": [
"ext.wikispeech.specialEditLexicon.js", <------ this first!
"ext.wikispeech.transcriptionPreviewer.js",
"ext.wikispeech.util.js"
],Turns out I had to put the ext.wikispeech.specialEditLexicon.js code inside mw.loader.using('mediawiki.api') so it only runs once the API is ready.
Comment Actions
I don't understand why mw.loader.using() is required now and not earlier. Still, it works so 🤷
Comment Actions
I really wonder that too... But maybe it is because it has something with the package files working differently than scripts even in this area..
Comment Actions
Change #1197592 merged by jenkins-bot:
[mediawiki/extensions/Wikispeech@master] Previewing doesn't work on Special:EditLexicon