Page MenuHomePhabricator
Create Task
Maniphest T406569

ArgumentCountError: Too few arguments to function Wikibase\Client\DataAccess\Scribunto\WikibaseLibrary::incrementStatsKey(), 1 passed in /srv/mediawiki/php-1.45.0-wmf.21/extensions/Scribunto/includes/Engines/LuaSandbox/LuaSandb
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
  • mwversion: 1.45.0-wmf.21
  • timestamp: 2025-10-07T07:52:30.866Z
  • phpversion: 8.1.33
  • reqId: 9ed94069-2275-4062-9499-9c244b4cf251
  • Find reqId in Logstash
normalized_message
[{reqId}] {exception_url}   ArgumentCountError: Too few arguments to function Wikibase\Client\DataAccess\Scribunto\WikibaseLibrary::incrementStatsKey(), 1 passed in /srv/mediawiki/php-1.45.0-wmf.21/extensions/Scribunto/includes/Engines/LuaSandbox/LuaSandb
FrameLocationCall
from/srv/mediawiki/php-1.45.0-wmf.21/extensions/Wikibase/client/includes/DataAccess/Scribunto/WikibaseLibrary.php(735)
#0/srv/mediawiki/php-1.45.0-wmf.21/extensions/Scribunto/includes/Engines/LuaSandbox/LuaSandboxCallback.php(31)Wikibase\Client\DataAccess\Scribunto\WikibaseLibrary->incrementStatsKey(string)
#1[internal function]MediaWiki\Extension\Scribunto\Engines\LuaSandbox\LuaSandboxCallback->__call(string, array)
#2/srv/mediawiki/php-1.45.0-wmf.21/extensions/Scribunto/includes/Engines/LuaSandbox/LuaSandboxInterpreter.php(137)LuaSandboxFunction->call(LuaSandboxFunction)
#3/srv/mediawiki/php-1.45.0-wmf.21/extensions/Scribunto/includes/Engines/LuaCommon/LuaEngine.php(318)MediaWiki\Extension\Scribunto\Engines\LuaSandbox\LuaSandboxInterpreter->callFunction(LuaSandboxFunction, LuaSandboxFunction)
#4/srv/mediawiki/php-1.45.0-wmf.21/extensions/Scribunto/includes/Engines/LuaCommon/LuaModule.php(76)MediaWiki\Extension\Scribunto\Engines\LuaCommon\LuaEngine->executeFunctionChunk(LuaSandboxFunction, MediaWiki\Parser\PPTemplateFrame_Hash)
#5/srv/mediawiki/php-1.45.0-wmf.21/extensions/Scribunto/includes/Hooks.php(173)MediaWiki\Extension\Scribunto\Engines\LuaCommon\LuaModule->invoke(string, MediaWiki\Parser\PPTemplateFrame_Hash)
#6/srv/mediawiki/php-1.45.0-wmf.21/includes/parser/Parser.php(3423)MediaWiki\Extension\Scribunto\Hooks->invokeHook(MediaWiki\Parser\Parser, MediaWiki\Parser\PPFrame_Hash, array)
#7/srv/mediawiki/php-1.45.0-wmf.21/includes/parser/Parser.php(3079)MediaWiki\Parser\Parser->callParserFunction(MediaWiki\Parser\PPFrame_Hash, string, array, bool)
#8/srv/mediawiki/php-1.45.0-wmf.21/includes/parser/PPFrame_Hash.php(280)MediaWiki\Parser\Parser->braceSubstitution(array, MediaWiki\Parser\PPFrame_Hash)
#9/srv/mediawiki/php-1.45.0-wmf.21/includes/parser/Parser.php(2901)MediaWiki\Parser\PPFrame_Hash->expand(MediaWiki\Parser\PPNode_Hash_Tree, int)
#10/srv/mediawiki/php-1.45.0-wmf.21/includes/parser/Parser.php(1537)MediaWiki\Parser\Parser->replaceVariables(string)
#11/srv/mediawiki/php-1.45.0-wmf.21/includes/parser/Parser.php(624)MediaWiki\Parser\Parser->internalParse(string)
#12/srv/mediawiki/php-1.45.0-wmf.21/includes/content/WikitextContentHandler.php(389)MediaWiki\Parser\Parser->parse(string, MediaWiki\Title\Title, MediaWiki\Parser\ParserOptions, bool, bool, int)
#13/srv/mediawiki/php-1.45.0-wmf.21/includes/content/ContentHandler.php(1746)MediaWiki\Content\WikitextContentHandler->fillParserOutput(MediaWiki\Content\WikitextContent, MediaWiki\Content\Renderer\ContentParseParams, MediaWiki\Parser\ParserOutput)
#14/srv/mediawiki/php-1.45.0-wmf.21/includes/content/Renderer/ContentRenderer.php(67)MediaWiki\Content\ContentHandler->getParserOutput(MediaWiki\Content\WikitextContent, MediaWiki\Content\Renderer\ContentParseParams)
#15/srv/mediawiki/php-1.45.0-wmf.21/includes/Revision/RenderedRevision.php(261)MediaWiki\Content\Renderer\ContentRenderer->getParserOutput(MediaWiki\Content\WikitextContent, MediaWiki\Page\PageIdentityValue, MediaWiki\Revision\RevisionStoreRecord, MediaWiki\Parser\ParserOptions, array)
#16/srv/mediawiki/php-1.45.0-wmf.21/includes/Revision/RenderedRevision.php(233)MediaWiki\Revision\RenderedRevision->getSlotParserOutputUncached(MediaWiki\Content\WikitextContent, array)
#17/srv/mediawiki/php-1.45.0-wmf.21/includes/Revision/RevisionRenderer.php(237)MediaWiki\Revision\RenderedRevision->getSlotParserOutput(string, array)
#18/srv/mediawiki/php-1.45.0-wmf.21/includes/Revision/RevisionRenderer.php(170)MediaWiki\Revision\RevisionRenderer->combineSlotOutput(MediaWiki\Revision\RenderedRevision, MediaWiki\Parser\ParserOptions, array)
#19/srv/mediawiki/php-1.45.0-wmf.21/includes/Revision/RenderedRevision.php(196)MediaWiki\Revision\RevisionRenderer->MediaWiki\Revision\{closure}(MediaWiki\Revision\RenderedRevision, array)
#20/srv/mediawiki/php-1.45.0-wmf.21/includes/jobqueue/jobs/RefreshLinksJob.php(440)MediaWiki\Revision\RenderedRevision->getRevisionParserOutput(array)
#21/srv/mediawiki/php-1.45.0-wmf.21/includes/jobqueue/jobs/RefreshLinksJob.php(292)MediaWiki\JobQueue\Jobs\RefreshLinksJob->getParserOutput(MediaWiki\Revision\RevisionRenderer, MediaWiki\Parser\ParserCache, MediaWiki\Page\WikiPage, Wikimedia\Stats\StatsFactory)
#22/srv/mediawiki/php-1.45.0-wmf.21/includes/jobqueue/jobs/RefreshLinksJob.php(225)MediaWiki\JobQueue\Jobs\RefreshLinksJob->runForTitle(MediaWiki\Title\Title)
#23/srv/mediawiki/php-1.45.0-wmf.21/extensions/EventBus/includes/JobExecutor.php(94)MediaWiki\JobQueue\Jobs\RefreshLinksJob->run()
#24/srv/mediawiki/rpc/RunSingleJob.php(60)MediaWiki\Extension\EventBus\JobExecutor->execute(array)
#25{main}
Impact
Notes

Details

Request URL
https://mw-jobrunner.discovery.wmnet/rpc/RunSingleJob.php
Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Fix calls to incrementStatsKey()Lucas Werkmeister (WMDE)mediawiki/extensions/WikibaseMediaInfomaster+8 -4
Fix calls to incrementStatsKey()Lucas Werkmeister (WMDE)mediawiki/extensions/WikibaseMediaInfowmf/1.45.0-wmf.21+8 -4
Fix calls to incrementStatsKey()Lucas Werkmeister (WMDE)mediawiki/extensions/WikibaseMediaInfowmf/1.45.0-wmf.22+8 -4
Customize query in gerrit

Event Timeline

Reedy created this task.Oct 7 2025, 11:30 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 7 2025, 11:30 AM
• Lucas_Werkmeister_WMDE subscribed.Oct 7 2025, 12:53 PM
gerritbot added a comment.Oct 7 2025, 12:53 PM

Change #1194190 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseMediaInfo@master] Fix calls to incrementStatsKey()

https://gerrit.wikimedia.org/r/1194190

gerritbot added a project: Patch-For-Review.Oct 7 2025, 12:53 PM
• Lucas_Werkmeister_WMDE added a comment.Oct 7 2025, 12:55 PM

As far as I can tell, this was broken since late April this year. I don’t understand how we didn’t notice – it looks like every call to the WikibaseMediaInfo functions (getCaptionWithLang, getCaption, getCaptionByLang, and overridden getEntityIdForTitle()) must have been broken?

• Lucas_Werkmeister_WMDE added a comment.Oct 7 2025, 12:58 PM

Yup, same ArgumentCountError can be seen at https://commons.wikimedia.org/wiki/User:Premeditated/sandbox. (And that page hasn’t been edited since 2020.)

image.png (973×169 px, 32 KB)

A_smart_kitten added a project: WikibaseMediaInfo.Oct 7 2025, 12:58 PM
Restricted Application added a project: Structured-Data-Backlog. · View Herald TranscriptOct 7 2025, 12:58 PM
• Lucas_Werkmeister_WMDE added a comment.EditedOct 7 2025, 1:02 PM

Logstash finds 55 occurrences of the error in the past 90 days, and judging by the request URLs, all of them are User:Premeditated/sandbox reached via different paths (including via its page ID, 83442019).

Does nobody else use the WikibaseMediaInfo Lua functions at all? (I guess it’s not totally unfeasible; captions are just labels, so you don’t have to use the caption functions, and getEntityIdForTitle() feels like it could be relatively unused.)

gerritbot added a comment.Oct 7 2025, 1:34 PM

Change #1194193 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseMediaInfo@wmf/1.45.0-wmf.22] Fix calls to incrementStatsKey()

https://gerrit.wikimedia.org/r/1194193

gerritbot added a comment.Oct 7 2025, 1:34 PM

Change #1194194 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseMediaInfo@wmf/1.45.0-wmf.21] Fix calls to incrementStatsKey()

https://gerrit.wikimedia.org/r/1194194

gerritbot added a comment.Oct 7 2025, 1:53 PM

Change #1194193 merged by jenkins-bot:

[mediawiki/extensions/WikibaseMediaInfo@wmf/1.45.0-wmf.22] Fix calls to incrementStatsKey()

https://gerrit.wikimedia.org/r/1194193

gerritbot added a comment.Oct 7 2025, 1:53 PM

Change #1194194 merged by jenkins-bot:

[mediawiki/extensions/WikibaseMediaInfo@wmf/1.45.0-wmf.21] Fix calls to incrementStatsKey()

https://gerrit.wikimedia.org/r/1194194

Stashbot added a comment.Oct 7 2025, 1:54 PM

Mentioned in SAL (#wikimedia-operations) [2025-10-07T13:54:00Z] <lucaswerkmeister-wmde@deploy2002> Started scap sync-world: Backport for [[gerrit:1194193|Fix calls to incrementStatsKey() (T406569)]], [[gerrit:1194194|Fix calls to incrementStatsKey() (T406569)]]

Stashbot added a comment.Oct 7 2025, 1:58 PM

Mentioned in SAL (#wikimedia-operations) [2025-10-07T13:58:17Z] <lucaswerkmeister-wmde@deploy2002> lucaswerkmeister-wmde: Backport for [[gerrit:1194193|Fix calls to incrementStatsKey() (T406569)]], [[gerrit:1194194|Fix calls to incrementStatsKey() (T406569)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.21; 2025-09-30).Oct 7 2025, 2:00 PM
Stashbot added a comment.Oct 7 2025, 2:03 PM

Mentioned in SAL (#wikimedia-operations) [2025-10-07T14:03:58Z] <lucaswerkmeister-wmde@deploy2002> Finished scap sync-world: Backport for [[gerrit:1194193|Fix calls to incrementStatsKey() (T406569)]], [[gerrit:1194194|Fix calls to incrementStatsKey() (T406569)]] (duration: 09m 58s)

gerritbot added a comment.Oct 7 2025, 2:29 PM

Change #1194190 merged by jenkins-bot:

[mediawiki/extensions/WikibaseMediaInfo@master] Fix calls to incrementStatsKey()

https://gerrit.wikimedia.org/r/1194190

• Lucas_Werkmeister_WMDE claimed this task.Oct 7 2025, 2:31 PM
• Lucas_Werkmeister_WMDE added a project: Wikidata-Omega (The Board).
• Lucas_Werkmeister_WMDE moved this task from new to the board to In Tech Verification on the Wikidata-Omega (The Board) board.
Maintenance_bot removed a project: Patch-For-Review.Oct 7 2025, 2:31 PM
• Lucas_Werkmeister_WMDE closed this task as Resolved.Oct 7 2025, 2:32 PM
• Lucas_Werkmeister_WMDE edited projects, added: Wikidata-Omega (Completed Tasks); removed: Wikidata-Omega (The Board).
In T406569#11249896, @Lucas_Werkmeister_WMDE wrote:

Yup, same ArgumentCountError can be seen at https://commons.wikimedia.org/wiki/User:Premeditated/sandbox. (And that page hasn’t been edited since 2020.)

image.png (973×169 px, 32 KB)

The page works now (even without WikimediaDebug), so I think this is done. Feel free to reopen if it happens again.

ReleaseTaggerBot edited projects, added: MW-1.45-notes (1.45.0-wmf.23; 2025-10-14); removed: MW-1.45-notes (1.45.0-wmf.21; 2025-09-30).Oct 7 2025, 3:00 PM
A_smart_kitten subscribed.Oct 7 2025, 4:09 PM

FWIW, User:Premeditated/sandbox now displays a few Lua errors that seem like they might also be the fault of the Wikibase[MediaInfo] extension, rather than (e.g.) a coding error onwiki. (I could be wrong, though — I'm not greatly familiar with Scribunto)

karapayneWMDE moved this task from Newly completed tasks to 2025 Q3 on the Wikidata-Omega (Completed Tasks) board.Oct 8 2025, 1:50 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits