Page MenuHomePhabricator

comment wrong in jquery.clickTracking.js
Closed, ResolvedPublic

Description

https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/ClickTracking.git;f=modules/jquery.clickTracking.js;hb=HEAD#l12 says

// Attach a timestamp to the tracked event and append it to the
// logged event array (mw.tracked).

But there's no mw.tracked key! Just:

// Attach a timestamp to the action's data (some tracked event)
// and remember it for $.getTrackedActions()

(I have a local branch fixing this with a few other comment improvements.)


Version: master
Severity: trivial

Details

Reference
bz38659

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:00 AM
bzimport set Reference to bz38659.
bzimport added a subscriber: Unknown Object (MLST).

It should mention the local "actions" array variable instead.

ori added a comment.Aug 27 2012, 9:32 AM

Fixed in Gerrit change #21555.