Page MenuHomePhabricator
Create Task
Maniphest T406606

Suggested investigations: TransactionProfiler warning when creating case
Closed, ResolvedPublic
Actions

Description

The CheckUser-SuggestedInvestigations feature is sometimes creating TransactionProfiler warnings when creating cases. This happens when the trigger is confirming an email address.

url
/wiki/Special:ConfirmEmail/{token}
message
Expectation (writes <= 0) by MediaWiki\MediaWikiEntryPoint::restInPeace not met (actual: 1):
role-primary: INSERT IGNORE INTO `cusi_user` (siu_sic_id,siu_user_id) VALUES '?'
exception.trace
from /srv/mediawiki/php-1.45.0-wmf.21/includes/libs/rdbms/TransactionProfiler.php(558)
#0 /srv/mediawiki/php-1.45.0-wmf.21/includes/libs/rdbms/TransactionProfiler.php(359): Wikimedia\Rdbms\TransactionProfiler->reportExpectationViolated(string, Wikimedia\Rdbms\GeneralizedSql, int, string, string)
#1 /srv/mediawiki/php-1.45.0-wmf.21/includes/libs/rdbms/database/TransactionManager.php(586): Wikimedia\Rdbms\TransactionProfiler->recordQueryCompletion(Wikimedia\Rdbms\GeneralizedSql, float, bool, int, string, string)
#2 /srv/mediawiki/php-1.45.0-wmf.21/includes/libs/rdbms/database/Database.php(865): Wikimedia\Rdbms\TransactionManager->recordQueryCompletion(Wikimedia\Rdbms\GeneralizedSql, float, bool, int, string)
#3 /srv/mediawiki/php-1.45.0-wmf.21/includes/libs/rdbms/database/Database.php(718): Wikimedia\Rdbms\Database->attemptQuery(Wikimedia\Rdbms\Query, string, bool)
#4 /srv/mediawiki/php-1.45.0-wmf.21/includes/libs/rdbms/database/Database.php(645): Wikimedia\Rdbms\Database->executeQuery(Wikimedia\Rdbms\Query, string, int)
#5 /srv/mediawiki/php-1.45.0-wmf.21/includes/libs/rdbms/database/Database.php(1516): Wikimedia\Rdbms\Database->query(Wikimedia\Rdbms\Query, string)
#6 /srv/mediawiki/php-1.45.0-wmf.21/includes/libs/rdbms/database/DBConnRef.php(127): Wikimedia\Rdbms\Database->insert(string, array, string, array)
#7 /srv/mediawiki/php-1.45.0-wmf.21/includes/libs/rdbms/database/DBConnRef.php(450): Wikimedia\Rdbms\DBConnRef->__call(string, array)
#8 /srv/mediawiki/php-1.45.0-wmf.21/includes/libs/rdbms/querybuilder/InsertQueryBuilder.php(340): Wikimedia\Rdbms\DBConnRef->insert(string, array, string, array)
#9 /srv/mediawiki/php-1.45.0-wmf.21/extensions/CheckUser/src/SuggestedInvestigations/Services/SuggestedInvestigationsCaseManagerService.php(161): Wikimedia\Rdbms\InsertQueryBuilder->execute()
#10 /srv/mediawiki/php-1.45.0-wmf.21/extensions/CheckUser/src/SuggestedInvestigations/Services/SuggestedInvestigationsCaseManagerService.php(108): MediaWiki\CheckUser\SuggestedInvestigations\Services\SuggestedInvestigationsCaseManagerService->addUsersToCaseInternal(int, array)
#11 /srv/mediawiki/php-1.45.0-wmf.21/extensions/CheckUser/src/SuggestedInvestigations/Services/SuggestedInvestigationsSignalMatchService.php(143): MediaWiki\CheckUser\SuggestedInvestigations\Services\SuggestedInvestigationsCaseManagerService->addUsersToCase(int, array)
#12 /srv/mediawiki/php-1.45.0-wmf.21/extensions/CheckUser/src/SuggestedInvestigations/Services/SuggestedInvestigationsSignalMatchService.php(116): MediaWiki\CheckUser\SuggestedInvestigations\Services\SuggestedInvestigationsSignalMatchService->addUserToCases(MediaWiki\User\User, array)
#13 /srv/mediawiki/php-1.45.0-wmf.21/extensions/CheckUser/src/SuggestedInvestigations/Services/SuggestedInvestigationsSignalMatchService.php(76): MediaWiki\CheckUser\SuggestedInvestigations\Services\SuggestedInvestigationsSignalMatchService->processMergeableSignal(MediaWiki\User\User, MediaWiki\CheckUser\SuggestedInvestigations\Signals\SuggestedInvestigationsSignalMatchResult)
#14 /srv/mediawiki/php-1.45.0-wmf.21/extensions/CheckUser/src/HookHandler/SuggestedInvestigationsHandler.php(52): MediaWiki\CheckUser\SuggestedInvestigations\Services\SuggestedInvestigationsSignalMatchService->matchSignalsAgainstUser(MediaWiki\User\User, string)
#15 /srv/mediawiki/php-1.45.0-wmf.21/includes/deferred/MWCallableUpdate.php(52): MediaWiki\CheckUser\HookHandler\SuggestedInvestigationsHandler->MediaWiki\CheckUser\HookHandler\{closure}(string)
#16 /srv/mediawiki/php-1.45.0-wmf.21/includes/deferred/DeferredUpdates.php(459): MediaWiki\Deferred\MWCallableUpdate->doUpdate()
#17 /srv/mediawiki/php-1.45.0-wmf.21/includes/deferred/DeferredUpdates.php(201): MediaWiki\Deferred\DeferredUpdates::attemptUpdate(MediaWiki\Deferred\MWCallableUpdate)
#18 /srv/mediawiki/php-1.45.0-wmf.21/includes/deferred/DeferredUpdates.php(288): MediaWiki\Deferred\DeferredUpdates::run(MediaWiki\Deferred\MWCallableUpdate)
#19 /srv/mediawiki/php-1.45.0-wmf.21/includes/deferred/DeferredUpdatesScope.php(243): MediaWiki\Deferred\DeferredUpdates::MediaWiki\Deferred\{closure}(MediaWiki\Deferred\MWCallableUpdate, int)
#20 /srv/mediawiki/php-1.45.0-wmf.21/includes/deferred/DeferredUpdatesScope.php(172): MediaWiki\Deferred\DeferredUpdatesScope->processStageQueue(int, int, Closure)
#21 /srv/mediawiki/php-1.45.0-wmf.21/includes/deferred/DeferredUpdates.php(307): MediaWiki\Deferred\DeferredUpdatesScope->processUpdates(int, Closure)
#22 /srv/mediawiki/php-1.45.0-wmf.21/includes/MediaWikiEntryPoint.php(670): MediaWiki\Deferred\DeferredUpdates::doUpdates()
#23 /srv/mediawiki/php-1.45.0-wmf.21/includes/MediaWikiEntryPoint.php(492): MediaWiki\MediaWikiEntryPoint->restInPeace()
#24 /srv/mediawiki/php-1.45.0-wmf.21/includes/MediaWikiEntryPoint.php(450): MediaWiki\MediaWikiEntryPoint->doPostOutputShutdown()
#25 /srv/mediawiki/php-1.45.0-wmf.21/includes/MediaWikiEntryPoint.php(207): MediaWiki\MediaWikiEntryPoint->postOutputShutdown()
#26 /srv/mediawiki/php-1.45.0-wmf.21/index.php(58): MediaWiki\MediaWikiEntryPoint->run()
#27 /srv/mediawiki/w/index.php(3): require(string)
#28 {main}

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
SI: Ignore primary DB connections and writes for confirming emailmediawiki/extensions/CheckUsermaster+26 -3
Customize query in gerrit

Event Timeline

Dreamy_Jazz created this task.Oct 7 2025, 3:10 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 7 2025, 3:10 PM
Dreamy_Jazz moved this task from Inbox to Next sprint on the Product Safety and Integrity board.Oct 7 2025, 3:10 PM
OKryva-WMF moved this task from Next sprint to Later sprints on the Product Safety and Integrity board.Oct 10 2025, 9:18 AM
Dreamy_Jazz moved this task from Later sprints to Next sprint on the Product Safety and Integrity board.Oct 10 2025, 9:43 AM
OKryva-WMF moved this task from Backlog to Q3 Plan on the CheckUser-SuggestedInvestigations board.Oct 27 2025, 5:43 PM
Dreamy_Jazz moved this task from Next sprint to Essential Work Sprint (Dec 15th - Jan 9th) on the Product Safety and Integrity board.Nov 19 2025, 12:18 PM
Dreamy_Jazz edited projects, added Product Safety and Integrity (Essential Work Sprint (Dec 15th - Jan 9th)); removed Product Safety and Integrity.
Dreamy_Jazz claimed this task.Nov 28 2025, 12:55 PM
Dreamy_Jazz edited projects, added Product Safety and Integrity (Crepes au Chocolat (Sprint Nov 10 - Nov 28)); removed Product Safety and Integrity (Essential Work Sprint (Dec 15th - Jan 9th)).
Dreamy_Jazz removed a project: Essential-Work.
Dreamy_Jazz moved this task from Backlog to In progress on the Product Safety and Integrity (Crepes au Chocolat (Sprint Nov 10 - Nov 28)) board.
gerritbot added a comment.Nov 28 2025, 1:57 PM

Change #1212588 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] SI: Ignore primary DB connections and writes for confirming email

https://gerrit.wikimedia.org/r/1212588

gerritbot added a project: Patch-For-Review.Nov 28 2025, 1:57 PM
Dreamy_Jazz moved this task from In progress to Needs review on the Product Safety and Integrity (Crepes au Chocolat (Sprint Nov 10 - Nov 28)) board.Nov 28 2025, 2:16 PM
Dreamy_Jazz moved this task from Q3 Plan to In Progress on the CheckUser-SuggestedInvestigations board.
OKryva-WMF edited projects, added Product Safety and Integrity (Sprint Mince Pie Dec 1 - Dec 12); removed Product Safety and Integrity (Crepes au Chocolat (Sprint Nov 10 - Nov 28)).Dec 1 2025, 9:10 AM
OKryva-WMF moved this task from Backlog to Needs review on the Product Safety and Integrity (Sprint Mince Pie Dec 1 - Dec 12) board.Dec 1 2025, 9:11 AM
gerritbot added a comment.Dec 2 2025, 12:06 PM

Change #1212588 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] SI: Ignore primary DB connections and writes for confirming email

https://gerrit.wikimedia.org/r/1212588

Dreamy_Jazz moved this task from Needs review to Needs QA on the Product Safety and Integrity (Sprint Mince Pie Dec 1 - Dec 12) board.Dec 2 2025, 12:09 PM

QA will be verifying that the warnings no longer appear on production when this gets deployed everywhere

Maintenance_bot removed a project: Patch-For-Review.Dec 2 2025, 12:30 PM
ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.7; 2025-12-16).Dec 2 2025, 1:00 PM
EChukwukere-WMF subscribed.Dec 4 2025, 2:26 PM

QA Feedback: This will be dev tested by @Dreamy_Jazz

OKryva-WMF edited projects, added Product Safety and Integrity (Sprint Daffodil (Jan 19 - Feb 6)); removed Product Safety and Integrity (Sprint Mince Pie Dec 1 - Dec 12).Dec 19 2025, 10:24 AM
OKryva-WMF moved this task from Backlog to Needs QA on the Product Safety and Integrity (Sprint Daffodil (Jan 19 - Feb 6)) board.Dec 19 2025, 10:24 AM
Dreamy_Jazz closed this task as Resolved.Tue, Jan 27, 4:29 PM
Dreamy_Jazz moved this task from Needs QA to Done on the Product Safety and Integrity (Sprint Daffodil (Jan 19 - Feb 6)) board.

Logs have stopped

hector.arroyo moved this task from In Progress to Done on the CheckUser-SuggestedInvestigations board.Mon, Feb 2, 5:26 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits