Page MenuHomePhabricator

ConfirmEdit hCaptcha: Expand QUnit test coverage on secure enclave code
Closed, ResolvedPublic

Description

In T406615: hCaptcha: Get QUnit tests to pass locally, we fixed the hCaptcha QUnit tests. We should now also expand the QUnit tests to cover code that was added but has not been properly tested

Background

  • In T406231: ConfirmEdit hCaptcha: Get QUnit tests to run in CI we found that the hCaptcha QUnit tests were not being run in MediaWiki CI
    • This meant that they did not block merges when they failed and as such several tests for the secure enclave JS code were failing
  • These failures were a mixture of the tests not being updated and the tests catching problems with the secure enclave handling
    • For example, no error was being displayed if the hCaptcha SDK failed to load
  • We should expand the QUnit tests so that the secure enclave handling is better tested
    • This is to make up for recent work that did not expand the QUnit tests

Acceptance criteria

Event Timeline

Change #1194269 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/ConfirmEdit@master] [WIP] Expand test coverage for hCaptcha secure enclave JS code

https://gerrit.wikimedia.org/r/1194269

Change #1194269 merged by jenkins-bot:

[mediawiki/extensions/ConfirmEdit@master] Expand test coverage for hCaptcha secure enclave JS code

https://gerrit.wikimedia.org/r/1194269