(I was trying to undelete https://meta.wikimedia.org/wiki/Community_Wishlist/W318 since I don't think being a duplicate is a valid reason to outright delete a wish; the later version should have remained as a historical record)

The easiest solution is probably to use one of the undelete hooks and set CommuntiyRequestsHooks::allowManualEditing = true.

That doesn't work; the only hook that runs before getUserPermissionExpensive checking for edit is getUserPermissionExpensive checking for undelete. I guess you could set a flag in the undelete hook to allow edits of that specific page, but that feels very very wrong.

Change #1221223 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[mediawiki/extensions/CommunityRequests@master] PermissionHooks: allow admins/Wishlist managers to undelete entities

https://gerrit.wikimedia.org/r/1221223

In T406668#11483559, @Pppery wrote:

The easiest solution is probably to use one of the undelete hooks and set CommuntiyRequestsHooks::allowManualEditing = true.

That doesn't work; the only hook that runs before getUserPermissionExpensive checking for edit is getUserPermissionExpensive checking for undelete.

You're right there apparently is no suitable undeletion hook to use. There used to be, but my team actually removed as part of an earlier project, hehe! (T290021 – though I don't know if that worked for the action API).

I guess you could set a flag in the undelete hook to allow edits of that specific page, but that feels very very wrong.

How so? What we're doing here with the static variable I think should be safe. It's good for only one request. getUserPermissionExpensive won't even get called if the user doesn't have undelete right, so we should be able to set the static var and allow subsequent calls (in the same request) to the hook handler to return true so things work as expected.

I'm saying it feels ugly as a code-organization principle for the getUserPermissionExpensive hook to mutate state. I agree you're right it's probably safe, but I don't like it.

Change #1221223 merged by jenkins-bot:

[mediawiki/extensions/CommunityRequests@master] PermissionHooks: allow admins/Wishlist managers to undelete entities

https://gerrit.wikimedia.org/r/1221223

@HMonroy Can you please review the side issue video below and whether I should create a separate task for it or if it's fine?

Test Result - Meta Beta

Status: ✅ PASS
Environment: Meta Beta
OS: macOS Tahoe 26.3
Browser: Chrome 143
Device: MBA
Emulated Device: NA

Test Artifact(s): Deleted wishlist page, Special\:Undelete interface

https://meta.wikimedia.beta.wmcloud.org/wiki/Special:Undelete/Community_Wishlist/W46

Test Steps

Preconditions:

• A Community Wishlist wish page exists (e.g., Community_Wishlist/W123).
• The page has been deleted.
• One administrator account and one non-admin account are available.

Test Case 1: Ensure administrators can undelete wishlist entities

1. Log in as an administrator.
2. Navigate to Special\:Undelete/Community_Wishlist/W123.
3. Observe whether the "Undelete revisions" form is displayed.
4. Restore the deleted revision.
5. Verify the wish page is accessible again.
6. Delete the page again to reset state (if needed).
7. ✅ AC1: The administrator can see and use the "Undelete revisions" form to restore the page.

Test Case 2: Ensure non-admin users cannot undelete wishlist entities

1. Log in as a non-admin user.
2. Navigate to Special\:{F72561874}Undelete/Community_Wishlist/W123.
3. Observe the page behavior.
4. ✅ AC2: The "Undelete revisions" form is not available and the non-admin user cannot restore the deleted page.

❓Side Issue-
Did you want the voting comment removed, or should everything be as it was when you undeleted it?

Did you want the voting comment removed, or should everything be as it was when you undeleted it?

Undeleting the Votes subpage sounds appropriate given we auto-delete it, but yeah, that should be a separate task. What we did here was just about access control as opposed to actually hooking to the undelete action.

@MusikAnimal you may be able to read that task with your staff account, any suggestions would be welcome

Ok sounds good, I created T419180: Voting comment is removed after deleting and undeleting a wish , regarding the voting comment no reappearing after undeleting the wish. As for the task, I will mark this as Resolved. Thanks for all your work!