Page MenuHomePhabricator

Associated edit dialog should not appear behind enable event registration dialog
Closed, ResolvedPublic

Description

Noticed behavior:

When I am registered for an event that has collaborative contributions enabled
And I create a new event
Then the associated event dialog should not appear behind the enable event dialog
and only the enable event registration dialog should appear

current behaviorgif of current behavior
Screenshot 2025-10-07 at 6.57.54 PM.png (1×1 px, 407 KB)
Screen Recording 2025-10-07 at 5.45.39 PM.gif (1×1 px, 845 KB)

Acceptance Criteria:

  • Do not allow the edit association modal for collaborative contributions to be displayed for the event namespace

Notes:

  • This should not be a problem for events in other namespaces, since the modal for edit association only appears for the event namespace.
  • We will prevent the modal from appearing in the event namespace, but we will not prevent edit association for pages in the event namespace in general if people want to make that association through other means in the future. The issue we are aiming to solve here is the visual confusion of having 2 modals.

Event Timeline

Potential solution : Disallow collaborative contributions associated with creating pages in the Event namespace?

Potential solution : Disallow collaborative contributions associated with creating pages in the Event namespace?

Yeah, I think this could be an accetable workaround. The general problem doesn't seem easy to solve, as there is no native concept of "dialogs shown after edits" in MW, so we can't add to a queue or anything.

Change #1196691 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] Disable post-edit contribution association dialog in the Event: namepace

https://gerrit.wikimedia.org/r/1196691

Change #1196691 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Disable post-edit contribution association dialog in the Event: namepace

https://gerrit.wikimedia.org/r/1196691

✅ Do not allow the edit association modal for collaborative contributions to be displayed for the event namespace

Screenshot 2025-10-21 at 11.02.26 PM.png (1×1 px, 207 KB)

AC met, nice work, sending to product sign off