Page MenuHomePhabricator

Closing edit notices steals keyboard focus
Open, Needs TriagePublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:

Nothing, because the keyboard focus has been placed onto the edit notices button in the toolbar.

What should have happened instead?:

The keyboard focus should have been returned to the surface, particularly if pressing ESC was the method used to close the notices.

As-is this is fairly unfriendly to users who want to only use the keyboard, as the notice covers potentially a large chunk of the screen and doesn't automatically dismiss itself when you scroll or start to edit the document. Once your focus is on the notices icon, it takes four tabs to get back to the edit surface.

(It's plausible that typing in the surface should also close the notices, since it's at least as explicit a signal as clicking the surface which closes it...)