Page MenuHomePhabricator
Create Task
Maniphest T406869

[Epic] VisualEditor must stop relying on synthetic LDRs to access main content
Open, Needs TriagePublic
Actions

Assigned To
None
Authored By
awight
Oct 9 2025, 1:44 PM
Tags
Referenced Files
None
Subscribers
Aklapper
awight
matmarex
thiemowmde
WMDE-Fisch

Description

Context

In VE we're currently relying in synthetic LDRs to access the main content of sub-refs. The synthetic MWReferenceNodes currently seem to be needed in some places to guarantee that we can access the InternalItemNodes storing the main content.

Task

The task is done, when all the accessors of main content from sub-refs can retrieve that content without relying on the presence of MWReferenceNodes using that content as their main content.

Implementation

The goal is that wherever we need to retrieve the main content using the mainRefKey we can use internalList.getKeyIndex( group, key ) to get to the to InternalItemNode. See also https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Cite/+/1194657/6

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Maintain keyIndexes when rebuilding InternalListVisualEditor/VisualEditormaster+68 -27
Update VE core submodule to master (4b7ec1130)mediawiki/extensions/VisualEditormaster+1 -1
Add missing listIndex to "stubReference" test setupVisualEditor/VisualEditormaster+16 -3
Update VE core submodule to master (20c4837bc)mediawiki/extensions/VisualEditormaster+1 -1
Maintain keyIndexes when rebuilding InternalListVisualEditor/VisualEditormaster+8 -0
[refactor] Can render a reflist item without ref nodemediawiki/extensions/Citemaster+8 -1
[refactor] Don't count synthetic refs when placing bodymediawiki/extensions/Citemaster+4 -6
Customize query in gerrit

Related Objects
Search...

Event Timeline

awight created this task.Oct 9 2025, 1:44 PM
Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptOct 9 2025, 1:44 PM
awight added a parent task: T406871: [refactor] Stop emitting synthetic list-defined refs from Parsoid.Oct 9 2025, 1:51 PM
awight added a subtask: T406588: [refactor] Don't remove internal item nodes from InternalList's indexes.
gerritbot added a comment.Oct 9 2025, 2:04 PM

Change #1194659 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/Cite@master] [refactor] Don't count synthetic refs when placing body

https://gerrit.wikimedia.org/r/1194659

gerritbot added a project: Patch-For-Review.Oct 9 2025, 2:04 PM

Change #1194658 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/Cite@master] [refactor] Can render a reflist item without ref node

https://gerrit.wikimedia.org/r/1194658

awight renamed this task from [refactor] Visual Editor can avoid orphaning subrefs, without using synthetic ref to [refactor] Visual Editor must stop relying on synthetic ref.Oct 9 2025, 2:05 PM
awight updated the task description. (Show Details)
awight added a subtask: T406570: [refactor] Parsoid must always emit data-mw for reference list items.Oct 9 2025, 2:33 PM
awight added a parent task: T406866: [refactor] Stop creating new synthetic refs in Visual Editor.Oct 9 2025, 2:38 PM
awight added a project: WMDE-TechWish-Sprint-2025-10-14-Choco-Soufflé.Oct 14 2025, 8:23 AM
gerritbot added a comment.Oct 15 2025, 1:13 PM

Change #1196434 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/Cite@master] [refactor] references list uses internal item

https://gerrit.wikimedia.org/r/1196434

gerritbot added a comment.Oct 15 2025, 1:53 PM

Change #1196452 had a related patch set uploaded (by Awight; author: Awight):

[VisualEditor/VisualEditor@master] Maintain keyIndexes when rebuilding InternalList

https://gerrit.wikimedia.org/r/1196452

awight closed subtask T406570: [refactor] Parsoid must always emit data-mw for reference list items as Invalid.Oct 16 2025, 12:23 PM
gerritbot added a comment.Oct 17 2025, 8:49 AM

Change #1196863 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[VisualEditor/VisualEditor@master] Add missing listIndex to "stubReference" test setup

https://gerrit.wikimedia.org/r/1196863

gerritbot added a comment.Oct 20 2025, 5:02 PM

Change #1196452 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Maintain keyIndexes when rebuilding InternalList

https://gerrit.wikimedia.org/r/1196452

awight added a comment.Oct 21 2025, 8:38 AM

Update: 20c4837bc23a2 is merged and now we're waiting for the next VisualEditor/lib/ve submodule bump.

gerritbot added a comment.Oct 21 2025, 11:43 AM

Change #1197291 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (20c4837bc)

https://gerrit.wikimedia.org/r/1197291

gerritbot added a comment.Oct 21 2025, 2:46 PM

Change #1197667 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (6caeeb2e4)

https://gerrit.wikimedia.org/r/1197667

matmarex subscribed.Oct 21 2025, 3:20 PM

The attempted submodule bump revealed test failures in the Cite extension bisecting to this change :( Reverted for now via https://gerrit.wikimedia.org/r/c/VisualEditor/VisualEditor/+/1197674

gerritbot added a comment.Oct 24 2025, 12:29 AM

Change #1197291 abandoned by DLynch:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (20c4837bc)

https://gerrit.wikimedia.org/r/1197291

gerritbot added a comment.Oct 24 2025, 2:25 PM

Change #1198544 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Cite@master] VE: Improve MWReferenceModel QUnit reuse test

https://gerrit.wikimedia.org/r/1198544

WMDE-Fisch claimed this task.Oct 27 2025, 11:00 AM
WMDE-Fisch moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2025-10-14-Choco-Soufflé board.
gerritbot added a comment.Oct 27 2025, 1:36 PM

Change #1198980 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Cite@master] VE: Add MWReferenceModel QUnit test for internal item updates

https://gerrit.wikimedia.org/r/1198980

gerritbot added a comment.Oct 27 2025, 3:22 PM

Change #1199001 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Cite@master] VE: Simplify ve.dm.Transaction test runner

https://gerrit.wikimedia.org/r/1199001

WMDE-Fisch removed WMDE-Fisch as the assignee of this task.Oct 28 2025, 10:01 AM
WMDE-Fisch moved this task from Doing to Sprint Backlog on the WMDE-TechWish-Sprint-2025-10-14-Choco-Soufflé board.
WMDE-Fisch removed a project: Patch-For-Review.Oct 28 2025, 10:03 AM
WMDE-Fisch moved this task from Sprint Backlog to Watching / Stalled on the WMDE-TechWish-Sprint-2025-10-14-Choco-Soufflé board.
gerritbot added a comment.Oct 28 2025, 1:08 PM

Change #1199001 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Cite@master] VE: Simplify ve.dm.Transaction test runner

https://gerrit.wikimedia.org/r/1199001

gerritbot added a project: Patch-For-Review.Oct 28 2025, 1:08 PM
gerritbot added a comment.Nov 5 2025, 1:31 PM

Change #1202126 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[VisualEditor/VisualEditor@master] Maintain keyIndexes when rebuilding InternalList

https://gerrit.wikimedia.org/r/1202126

gerritbot added a comment.Nov 6 2025, 3:49 PM

Change #1196863 abandoned by Thiemo Kreuz (WMDE):

[VisualEditor/VisualEditor@master] Add missing listIndex to "stubReference" test setup

Reason:

Done again as part of I9d9a60f.

https://gerrit.wikimedia.org/r/1196863

gerritbot added a comment.Nov 27 2025, 1:34 PM

Change #1202126 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Maintain keyIndexes when rebuilding InternalList

https://gerrit.wikimedia.org/r/1202126

gerritbot added a comment.Nov 28 2025, 11:31 AM

Change #1212557 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (4b7ec1130)

https://gerrit.wikimedia.org/r/1212557

gerritbot added a comment.Nov 28 2025, 1:35 PM

Change #1212557 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (4b7ec1130)

https://gerrit.wikimedia.org/r/1212557

WMDE-Fisch added a subtask: T411396: Paste regressions when rebuilding keyIndexes.Dec 1 2025, 5:54 PM
WMDE-Fisch removed a parent task: T397501: [Epic] Use InternalItems only instead of synthetic LDRs to store content for sub-refs.Dec 5 2025, 9:29 AM
WMDE-Fisch moved this task from Incoming to Dev-Work on the Cite (Sub-referencing) board.Dec 5 2025, 11:26 AM
WMDE-Fisch closed subtask T408535: Look into the failing tests when rebuilding keyIndexes as Resolved.Dec 9 2025, 10:19 AM
awight updated the task description. (Show Details)Mon, Jan 19, 9:29 AM
lilients_WMDE added a project: WMDE-TechWish-Sprint-2026-01-20-Carrots-of-many-colors.Tue, Jan 20, 10:51 AM
lilients_WMDE moved this task from Sprint Backlog to Epics / Watching / Stalled on the WMDE-TechWish-Sprint-2026-01-20-Carrots-of-many-colors board.Tue, Jan 20, 1:42 PM
awight created subtask T415521: Display InternalList keyIndex mapping and InternalItem indexes in VE debug mode.Mon, Jan 26, 10:16 AM
lilients_WMDE added a subtask: T415526: [Refactoring] Create a dev only feature flag that disables synthetic refs in Visual Editor.Mon, Jan 26, 10:52 AM
WMDE-Fisch renamed this task from [refactor] Visual Editor must stop relying on synthetic ref to [Epic] VisualEditor must stop relying on synthetic LDRs to access main content.Tue, Jan 27, 12:51 PM
WMDE-Fisch updated the task description. (Show Details)
WMDE-Fisch mentioned this in T397501: [Epic] Use InternalItems only instead of synthetic LDRs to store content for sub-refs.Tue, Jan 27, 4:16 PM
WMDE-Fisch closed subtask T406588: [refactor] Don't remove internal item nodes from InternalList's indexes as Declined.Fri, Jan 30, 12:30 PM
WMDE-Fisch closed subtask T411396: Paste regressions when rebuilding keyIndexes as Resolved.Thu, Feb 12, 11:09 AM
WMDE-Fisch edited parent tasks, added: T402900: Avoid orphaning subrefs when a reference list is deleted, T404297: Main content is lost when converting last main ref when editing articles without refs; removed: T406871: [refactor] Stop emitting synthetic list-defined refs from Parsoid.Tue, Feb 17, 8:12 AM
WMDE-Fisch mentioned this in T404297: Main content is lost when converting last main ref when editing articles without refs.
WMDE-Fisch mentioned this in T402900: Avoid orphaning subrefs when a reference list is deleted.
thiemowmde closed subtask T415521: Display InternalList keyIndex mapping and InternalItem indexes in VE debug mode as Resolved.Tue, Feb 17, 9:22 AM
thiemowmde closed subtask T415526: [Refactoring] Create a dev only feature flag that disables synthetic refs in Visual Editor as Resolved.
lilients_WMDE added a project: WMDE-TechWish-Sprint-2026-02-17-Beautiful-Beetroots.Tue, Feb 17, 3:26 PM
lilients_WMDE moved this task from Sprint Backlog to Epics / Watching / Stalled on the WMDE-TechWish-Sprint-2026-02-17-Beautiful-Beetroots board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits