Page MenuHomePhabricator

[MEX] M3.1.2 - add value to a new statements/ edit statements
Open, Needs TriagePublic

Description

Split off from T405454: [MEX] 3.1.2 - add statement opens edit statement modal

As a user, i want to be able to add values to existing statements.

Screenshot 2025-11-04 at 11.06.19.png (1×1 px, 217 KB)

- - This functionality already exists but it is currently embeded directly in the main edit statement window without opening a modal. After revising and discussing, the agreement is that it should open a modal (see comments) - -

AC
The functionality moves to a modal:

  • when the user clicks add value in the main edit statement modal, he goes to a modal very similar to "add statement", but in this case there is no input field for property since it will be the same (in this case, occupation). The main property for this statement is indicated in the header, under the headline "add value"
  • The field for value is already in active state when the user enters the modal
  • After the user added the new value, the user can also add references and qualifiers to it (aim is to improve data quality)
  • the user can then save his changes and see them on the main edit screen
  • once he publishes the main edit screen, the changes are effectively saved and appear on the display page

You can try the look and flow of this feature in this prototype Steps: Edit statement Occupation - Add value - pick businessperson, publish (ignore the feedback ask at the end)

Figma design here

Event Timeline

karapayneWMDE renamed this task from [MEX] M3.1.2 - add value to a new statement to [MEX] M3.1.2 - add value to a new statements/ edit statements.Oct 14 2025, 9:10 AM
karapayneWMDE assigned this task to Alice.moutinho.

dropdown only appears with datatypes that trigger a dropdown

Hello team, since i will be on holiday next week, my 2 cents to the discussion of should this happen on an extra modal vs should happen in the edit stament modal.

First off, i had a look and we could make it work in the main window, but we need automatic scrolling to happen or it gets super messy:

Screenshot 2025-10-17 at 12.13.47.png (996×2 px, 239 KB)

I honestly hadn't seriously looked at this option because my course of action was simply codexify what was on the prototype. TBH at the start i wondered why we went for modals at all and didn't follow the route we had at desktop, but was told i was too late for changes, especially since user tests proved this to be working - and i agreed to stick to it. FYI: This action was user tested in a different modal 2x.

My biggest concerns about this new possibility after seriously looking at it are the scrolling and cognitive overload - because of the already populated modal. And the other concern i mentioned during task time: everything "adds" opens a new modal - this would be the only exception, and exceptions to patterns are enemies of consistency and consistency helps users know what to expect.

Alice.moutinho updated the task description. (Show Details)
Alice.moutinho subscribed.

Change #1204604 had a related patch set uploaded (by Sadiya.mohammed13; author: Sadiya.mohammed13):

[mediawiki/extensions/Wikibase@master] add value to a new statements/ edit statements

https://gerrit.wikimedia.org/r/1204604