Page MenuHomePhabricator

[MEX] M3.1.2 - also use wbparsevalue API to normalize string values in qualifiers and references
Closed, ResolvedPublic

Description

Use the approach in the parent task not just for the main snak of a statement, but also for qualifiers and references.

This will probably need some thought as to how we deal with qualifiers in data types that aren’t supported yet. For main snaks this isn’t really a problem, as we just don’t support opening the edit statement dialog. But what happens if I start editing a string statement with an item qualifier? Ideally I’d still see the qualifier in the edit dialog, but it’s not yet clear what the editStatementsStore should contain in this case.

Event Timeline

from task time: we'll revisit the details about user experience once the parent task is completed

I rebased my qualifiers patch and it looks like we'll get wbparsevalue support everywhere because of the editableSnakValue component. So that part of the ticket is addressed. Generally what we do with string-type statement with non-string-type references / qualifiers is not resolved - we still need a decision what to do here (but I think the question probably belongs in T405739 and not here).

I'm increasingly convinced that this will be covered by T405739, in case someone wants to take a look at this or the other ticket.