Page MenuHomePhabricator
Create Task
Maniphest T406910

TypeError: Cannot read properties of null (reading 'getView')
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

2,738 errors in last 7 days. Increasing in volume (possibly with new roll outs?)
https://logstash.wikimedia.org/goto/98f31d4691685b232b9ec93b02fd3175

at Controller.onSelect  https://fa.wikipedia.org/w/load.php?lang=fa&modules=ext.visualEditor.editCheck&skin=minerva&version=ad38n:12:366
at later  https://fa.wikipedia.org/w/load.php?lang=fa&modules=ext.echo.dm%2Cmobile%2Csecondaryicons%2Cui%7Cmoment%2Coojs-ui-core&skin=minerva&version=6bokv:209:115

Steps to replicate the issue (include links if applicable):

What happens?:

What should have happened instead?:

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Edit check: Add a wrapper to automate avoiding post-teardown debounce callsDLynchmediawiki/extensions/VisualEditormaster+14 -28
Edit check: Watch out for onSelect being called after teardown by debounceDLynchmediawiki/extensions/VisualEditormaster+4 -0
Customize query in gerrit

Event Timeline

Jdlrobson-WMF created this task.Oct 9 2025, 5:41 PM
Restricted Application changed the subtype of this task from "Bug Report" to "Production Error". · View Herald TranscriptOct 9 2025, 5:41 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a comment.Oct 9 2025, 10:29 PM

Change #1195071 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@master] Edit check: Watch out for onSelect being called after teardown by debounce

https://gerrit.wikimedia.org/r/1195071

gerritbot added a project: Patch-For-Review.Oct 9 2025, 10:29 PM

Change #1195072 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@master] Edit check: Add a wrapper to automate avoiding post-teardown debounce calls

https://gerrit.wikimedia.org/r/1195072

DLynch claimed this task.Oct 9 2025, 10:30 PM
DLynch added projects: VisualEditor, Editing-team (Kanban Board).
DLynch moved this task from Inbox to Code Review on the Editing-team (Kanban Board) board.
gerritbot added a comment.Oct 10 2025, 12:24 PM

Change #1195071 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Edit check: Watch out for onSelect being called after teardown by debounce

https://gerrit.wikimedia.org/r/1195071

gerritbot added a comment.Oct 10 2025, 12:51 PM

Change #1195072 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Edit check: Add a wrapper to automate avoiding post-teardown debounce calls

https://gerrit.wikimedia.org/r/1195072

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.23; 2025-10-14).Oct 10 2025, 1:00 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 10 2025, 1:30 PM
DLynch closed this task as Resolved.Oct 10 2025, 2:52 PM
DLynch added a project: Skipped QA.
VPuffetMichel added a project: Essential-Work.Dec 8 2025, 9:57 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits