hCaptcha: Fix execute duration timings and execution error logging
Closed, ResolvedPublic
Actions

Description

Summary

We have been tracking hcaptcha.execute() duration and execution error counts in Grafana, and this broke when wmf.22 arrived at group2, likely as part of the refactoring in T406126: Export selected secureEnclave.js methods to allow easier reuse

Acceptance criteria

trackPerformanceTiming() records the correct duration for hcaptcha.execute()
hCaptcha execution error counts are reported correctly in Grafana

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	ext.confirmEdit.hCaptcha.utils: Track hCaptcha execution rejections	Kosta Harlan	mediawiki/extensions/ConfirmEdit	wmf/1.45.0-wmf.22	+6 -0
	ext.confirmEdit.hCaptcha.utils: Track hCaptcha execution rejections	Dreamy Jazz	mediawiki/extensions/ConfirmEdit	master	+13 -1

Customize query in gerrit

Related Objects

Mentioned Here: rECOE53f68060f1f3: Fix locally failing QUnit tests
T406126: Export selected secureEnclave.js methods to allow easier reuse

Event Timeline

kostajh created this task.Oct 9 2025, 8:20 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 9 2025, 8:20 PM

kostajh added a project: Product Safety and Integrity (Sprint Apfel Strudel (Sep 29 - Oct 17)).Oct 9 2025, 8:20 PM

kostajh renamed this task from hCaptcha: Fix execute duration timings to hCaptcha: Fix execute duration timings and execution error logging.Oct 10 2025, 8:29 AM

kostajh updated the task description. (Show Details)

Noting that this was likely fixed as part of fixing the QUnit tests in 53f68060f1f311c5d073c28494e1e20992d3932c, and so the relevant fixes from that commit (or the entire commit) should likely be backported next week to wmf.22

In T406925#11263427, @Dreamy_Jazz wrote:

Noting that this was likely fixed as part of fixing the QUnit tests in 53f68060f1f311c5d073c28494e1e20992d3932c, and so the relevant fixes from that commit (or the entire commit) should likely be backported next week to wmf.22

OK, then let's backport that to wmf.22 on Monday.

However, the bit about the hCaptcha execution error counts still seems unfixed

Change #1195165 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/ConfirmEdit@master] ext.confirmEdit.hCaptcha.utils: Track hCaptcha execution rejections

https://gerrit.wikimedia.org/r/1195165

gerritbot added a project: Patch-For-Review.Oct 10 2025, 9:20 AM

Dreamy_Jazz moved this task from In progress to Needs review on the Product Safety and Integrity (Sprint Apfel Strudel (Sep 29 - Oct 17)) board.Oct 10 2025, 9:21 AM

Change #1195165 merged by jenkins-bot:

[mediawiki/extensions/ConfirmEdit@master] ext.confirmEdit.hCaptcha.utils: Track hCaptcha execution rejections

https://gerrit.wikimedia.org/r/1195165

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.23; 2025-10-14).Oct 10 2025, 12:00 PM

In T406925#11264108, @gerritbot wrote:

Change #1195165 merged by jenkins-bot:

[mediawiki/extensions/ConfirmEdit@master] ext.confirmEdit.hCaptcha.utils: Track hCaptcha execution rejections

https://gerrit.wikimedia.org/r/1195165

Thanks for this patch! I think the next thing we need here is a wmf.22 backport patch that we can sync on Monday. This will be a little complicated due to the various refactorings we've made since wmf.22.

Maintenance_bot removed a project: Patch-For-Review.Oct 10 2025, 12:31 PM

Change #1195628 had a related patch set uploaded (by Kosta Harlan; author: Dreamy Jazz):

[mediawiki/extensions/ConfirmEdit@wmf/1.45.0-wmf.22] ext.confirmEdit.hCaptcha.utils: Track hCaptcha execution rejections

https://gerrit.wikimedia.org/r/1195628

gerritbot added a project: Patch-For-Review.Oct 13 2025, 8:36 AM

Change #1195628 merged by jenkins-bot:

[mediawiki/extensions/ConfirmEdit@wmf/1.45.0-wmf.22] ext.confirmEdit.hCaptcha.utils: Track hCaptcha execution rejections

https://gerrit.wikimedia.org/r/1195628

Mentioned in SAL (#wikimedia-operations) [2025-10-13T09:01:08Z] <kharlan@deploy2002> Started scap sync-world: Backport for [[gerrit:1195628|ext.confirmEdit.hCaptcha.utils: Track hCaptcha execution rejections (T406925)]]

Mentioned in SAL (#wikimedia-operations) [2025-10-13T09:05:17Z] <kharlan@deploy2002> kharlan: Backport for [[gerrit:1195628|ext.confirmEdit.hCaptcha.utils: Track hCaptcha execution rejections (T406925)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2025-10-13T09:10:27Z] <kharlan@deploy2002> Finished scap sync-world: Backport for [[gerrit:1195628|ext.confirmEdit.hCaptcha.utils: Track hCaptcha execution rejections (T406925)]] (duration: 09m 19s)

Dreamy_Jazz closed this task as Resolved.Oct 13 2025, 9:11 AM

Dreamy_Jazz moved this task from Needs review to Done on the Product Safety and Integrity (Sprint Apfel Strudel (Sep 29 - Oct 17)) board.

Dreamy_Jazz updated the task description. (Show Details)

Maintenance_bot removed a project: Patch-For-Review.Oct 13 2025, 9:30 AM

ReleaseTaggerBot edited projects, added: MW-1.45-notes (1.45.0-wmf.22; 2025-10-07); removed: MW-1.45-notes (1.45.0-wmf.23; 2025-10-14).Oct 13 2025, 10:00 AM

kostajh moved this task from Backlog to Done on the Bot detection and mitigation (WE4.2 hCaptcha editing trial) board.Oct 30 2025, 8:29 AM

hCaptcha: Fix execute duration timings and execution error loggingClosed, ResolvedPublicActions